Linux console tools development discussion
 help / color / mirror / Atom feed
* [kbd] [Lint][Bug report] src/openvt.c:386: 'pid' may be used uninitialized
@ 2019-06-11 18:20 Vladislav Ivanishin
  2019-06-20  8:59 ` Alexey Gladkov
  2019-07-11 18:03 ` Vladislav Ivanishin
  0 siblings, 2 replies; 4+ messages in thread
From: Vladislav Ivanishin @ 2019-06-11 18:20 UTC (permalink / raw)
  To: kbd

Hi,

I've found this bug using a static analyzer (slightly improved GCC).

Consider variable `pid` in function main from src/openvt.c:

src/openvt.c:166:       int opt, pid, i;
src/openvt.c:303:       if (direct_exec || ((pid = fork()) == 0)) {
src/openvt.c:386:       if (pid < 0)
src/openvt.c:393:               waitpid(pid, &retval, 0);

If direct_exec is TRUE, then pid doesn't get initialized, but it is used
outside the conditional regardless of that.

-- 
Vlad


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-11 19:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-11 18:20 [kbd] [Lint][Bug report] src/openvt.c:386: 'pid' may be used uninitialized Vladislav Ivanishin
2019-06-20  8:59 ` Alexey Gladkov
2019-07-11 18:03 ` Vladislav Ivanishin
2019-07-11 19:22   ` Alexey Gladkov

Linux console tools development discussion

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
		kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
	public-inbox-index kbd

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.kbd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git