From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vlad@ispras.ru>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD
 autolearn=ham autolearn_force=no version=3.4.1
From: Vladislav Ivanishin <vlad@ispras.ru>
To: kbd@lists.altlinux.org
Date: Tue, 11 Jun 2019 21:20:04 +0300
Message-ID: <87v9xcugq3.fsf@ispras.ru>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailman-Approved-At: Fri, 14 Jun 2019 11:29:26 +0300
Subject: [kbd] [Lint][Bug report] src/openvt.c:386: 'pid' may be used
	uninitialized
X-BeenThere: kbd@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Linux console tools development discussion <kbd@lists.altlinux.org>
List-Id: Linux console tools development discussion <kbd.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/kbd>
List-Post: <mailto:kbd@lists.altlinux.org>
List-Help: <mailto:kbd-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jun 2019 18:20:10 -0000
Archived-At: <http://lore.altlinux.org/kbd/87v9xcugq3.fsf@ispras.ru/>
List-Archive: <http://lore.altlinux.org/kbd/>

Hi,

I've found this bug using a static analyzer (slightly improved GCC).

Consider variable `pid` in function main from src/openvt.c:

src/openvt.c:166:       int opt, pid, i;
src/openvt.c:303:       if (direct_exec || ((pid = fork()) == 0)) {
src/openvt.c:386:       if (pid < 0)
src/openvt.c:393:               waitpid(pid, &retval, 0);

If direct_exec is TRUE, then pid doesn't get initialized, but it is used
outside the conditional regardless of that.

-- 
Vlad