Make-initrd development discussion
 help / color / mirror / Atom feed
From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: make-initrd@lists.altlinux.org
Subject: [make-initrd] [PATCH 3/3] ueventd: Drop obsolete declarations
Date: Sat, 20 May 2023 18:37:48 +0200
Message-ID: <20230520163748.177260-3-gladkov.alexey@gmail.com> (raw)
In-Reply-To: <d26b7e31-fd63-8c30-8b7f-a471f5cce793@gmail.com>

After the logging functions were moved to the common library, they were
not removed from the header.

Also includes have been grouped at the top of the header to increase
readability.

Fixes: 78769ff4 ("Move logging functions to the separate library")
Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
---
 datasrc/ueventd/path.c            |  1 +
 datasrc/ueventd/queue-processor.c |  1 +
 datasrc/ueventd/ueventd.c         |  1 +
 datasrc/ueventd/ueventd.h         | 32 +++----------------------------
 4 files changed, 6 insertions(+), 29 deletions(-)

diff --git a/datasrc/ueventd/path.c b/datasrc/ueventd/path.c
index 835f4fbb..330e8c82 100644
--- a/datasrc/ueventd/path.c
+++ b/datasrc/ueventd/path.c
@@ -5,6 +5,7 @@
 #include <fcntl.h>
 #include <errno.h>
 
+#include "rd/logging.h"
 #include "ueventd.h"
 
 int is_dot_dir(struct dirent *ent)
diff --git a/datasrc/ueventd/queue-processor.c b/datasrc/ueventd/queue-processor.c
index b8383f51..908492a7 100644
--- a/datasrc/ueventd/queue-processor.c
+++ b/datasrc/ueventd/queue-processor.c
@@ -13,6 +13,7 @@
 #include <errno.h>
 
 #include "rd/memory.h"
+#include "rd/logging.h"
 #include "ueventd.h"
 
 static void event_handler(struct watch *queue, char *path) __attribute__((nonnull(1, 2)));
diff --git a/datasrc/ueventd/ueventd.c b/datasrc/ueventd/ueventd.c
index 2d510d62..857d3b4f 100644
--- a/datasrc/ueventd/ueventd.c
+++ b/datasrc/ueventd/ueventd.c
@@ -20,6 +20,7 @@
 #include <errno.h>
 
 #include "rd/memory.h"
+#include "rd/logging.h"
 #include "ueventd.h"
 
 #define default_logfile "/var/log/ueventd.log"
diff --git a/datasrc/ueventd/ueventd.h b/datasrc/ueventd/ueventd.h
index 375fa40f..653549f7 100644
--- a/datasrc/ueventd/ueventd.h
+++ b/datasrc/ueventd/ueventd.h
@@ -5,6 +5,8 @@
 
 #include <sys/types.h>
 #include <stdint.h>
+#include <unistd.h>
+#include <dirent.h>
 
 #define F_ROOT_DIR  (1 << 0)
 #define F_QUEUE_DIR (1 << 1)
@@ -31,8 +33,7 @@ extern uint64_t session;
 extern void process_events(struct watch *queue) __attribute__((nonnull(1), noreturn));
 
 /* path.c */
-#include <dirent.h>
-
+extern int is_dot_dir(struct dirent *ent)                           __attribute__((nonnull(1)));
 extern DIR *xopendir(const char *path)                              __attribute__((nonnull(1)));
 extern struct dirent *xreaddir(DIR *d, const char *path)            __attribute__((nonnull(1, 2)));
 extern int empty_directory(const char *path)                        __attribute__((nonnull(1)));
@@ -43,31 +44,4 @@ extern ssize_t write_loop(int fd, const char *buffer, size_t count) __attribute_
 /* process.c */
 extern pid_t waitpid_retry(pid_t pid, int *wstatus, int options);
 
-#include <dirent.h>
-
-extern  int is_dot_dir(struct dirent *ent) __attribute__((nonnull(1)));
-
-/* logging.c */
-#include <unistd.h>
-#include <syslog.h>
-#include <stdlib.h>
-#include <stdarg.h>
-
-extern void rd_logging_init(int log_fd, int level, const char *progname);
-extern void rd_logging_close(void);
-extern int rd_logging_level(const char *lvl)                           __attribute__((nonnull(1)));
-extern void rd_vmessage(const char *fmt, va_list ap)                   __attribute__((format(printf, 1, 0)));
-extern void rd_log_vmessage(int priority, const char *fmt, va_list ap) __attribute__((format(printf, 2, 0)));
-extern void rd_log_message(int priority, const char *fmt, ...)         __attribute__((format(printf, 2, 3)));
-
-#define rd_fatal(format, arg...)                    \
-	do {                                        \
-		rd_log_message(LOG_CRIT, "%s:%d: " format, __FILE__, __LINE__, ##arg); \
-		_exit(EXIT_FAILURE);                \
-	} while (0)
-
-#define rd_err(format, arg...)  rd_log_message(LOG_ERR,   format, ##arg)
-#define rd_info(format, arg...) rd_log_message(LOG_INFO,  format, ##arg)
-#define rd_dbg(format, arg...)  rd_log_message(LOG_DEBUG, format, ##arg)
-
 #endif /* __UEVENTD_H__ */
-- 
2.33.8



  parent reply	other threads:[~2023-05-20 16:37 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 13:42 [make-initrd] [PATCH 0/3] Reimplement ueventd Alexey Gladkov
2023-05-04 13:42 ` [make-initrd] [PATCH 1/3] " Alexey Gladkov
2023-05-05  3:08   ` Leonid Krivoshein
2023-05-05 17:02     ` Alexey Gladkov
2023-05-05  4:03   ` Leonid Krivoshein
2023-05-05 17:16     ` Alexey Gladkov
2023-05-05  5:21   ` Leonid Krivoshein
2023-05-05 17:24     ` Alexey Gladkov
2023-05-14 20:12   ` Leonid Krivoshein
2023-05-14 20:45     ` Alexey Gladkov
2023-05-14 20:57   ` Leonid Krivoshein
2023-05-15  8:52     ` Alexey Gladkov
2023-05-14 23:08   ` Leonid Krivoshein
2023-05-15  9:05     ` Alexey Gladkov
2023-05-15  0:47   ` Leonid Krivoshein
2023-05-15  9:12     ` Alexey Gladkov
2023-05-15  4:38   ` Leonid Krivoshein
2023-05-15 10:43     ` Alexey Gladkov
2023-05-18  6:39         ` Leonid Krivoshein
2023-05-18  7:05           ` Alexey Gladkov
2023-05-20  9:00   ` Leonid Krivoshein
2023-05-20 13:18     ` Alexey Gladkov
2023-05-20 15:17       ` Vladimir D. Seleznev
2023-05-20 17:23       ` Leonid Krivoshein
2023-05-20 18:51         ` Alexey Gladkov
2023-05-21  8:53         ` [make-initrd] [PATCH] ueventd: Don't use a epoll timeout when it's not needed Alexey Gladkov
2023-05-22  4:46           ` Leonid Krivoshein
2023-05-22  7:54             ` Alexey Gladkov
2023-05-22  9:19               ` Alexey Gladkov
2023-05-22  7:57             ` [make-initrd] [PATCH 1/2] ueventd: Fix memory leak Alexey Gladkov
2023-05-22  7:57             ` [make-initrd] [PATCH 2/2] ueventd: Change interface rd_asprintf_or_die Alexey Gladkov
2023-05-22  9:36               ` [make-initrd] [PATCH v2] " Alexey Gladkov
2023-05-20 16:37     ` [make-initrd] [PATCH 1/3] ueventd: Simplify call of the queue handler Alexey Gladkov
2023-05-20 16:37     ` [make-initrd] [PATCH 2/3] ueventd: Rename fd_list to fd_handler_list Alexey Gladkov
2023-05-20 16:37     ` Alexey Gladkov [this message]
2023-05-04 13:42 ` [make-initrd] [PATCH 2/3] Replace polld by uevent queue Alexey Gladkov
2023-05-04 13:42 ` [make-initrd] [PATCH 3/3] feature/kickstart: Reset rootdelay timer after kickstart Alexey Gladkov
2023-05-06 19:45 ` [make-initrd] ueventd: Add a prefix to the logging functions to avoid name collisions Alexey Gladkov
2023-05-06 19:45 ` [make-initrd] ueventd: Allow to configure the log destination Alexey Gladkov
2023-05-06 19:45 ` [make-initrd] ueventd: Pass the program name when initializing the logger Alexey Gladkov
2023-05-06 19:45 ` [make-initrd] ueventd: Rewrite logging function to make it more atomic Alexey Gladkov
2023-05-07 12:48 ` [make-initrd] [PATCH 0/3] Reimplement ueventd Alexey Gladkov
2023-05-13 11:50 ` Alexey Gladkov
2023-05-14 20:15   ` Leonid Krivoshein
2023-05-14 20:49     ` Alexey Gladkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230520163748.177260-3-gladkov.alexey@gmail.com \
    --to=gladkov.alexey@gmail.com \
    --cc=make-initrd@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Make-initrd development discussion

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/make-initrd/0 make-initrd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 make-initrd make-initrd/ http://lore.altlinux.org/make-initrd \
		make-initrd@lists.altlinux.org make-initrd@lists.altlinux.ru make-initrd@lists.altlinux.com
	public-inbox-index make-initrd

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.make-initrd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git