From: Alexey Gladkov <gladkov.alexey@gmail.com> To: make-initrd@lists.altlinux.org Subject: [make-initrd] ueventd: Allow to configure the log destination Date: Sat, 6 May 2023 21:45:02 +0200 Message-ID: <20230506194504.1471267-2-gladkov.alexey@gmail.com> (raw) In-Reply-To: <cover.1683200226.git.gladkov.alexey@gmail.com> Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com> --- datasrc/ueventd/logging.c | 27 ++++++--------------------- datasrc/ueventd/ueventd.c | 19 ++++++++++++++++++- datasrc/ueventd/ueventd.h | 2 +- 3 files changed, 25 insertions(+), 23 deletions(-) diff --git a/datasrc/ueventd/logging.c b/datasrc/ueventd/logging.c index 3a04a5a9..525ff7fd 100644 --- a/datasrc/ueventd/logging.c +++ b/datasrc/ueventd/logging.c @@ -8,9 +8,8 @@ #include "ueventd.h" -#define default_logfile "/var/log/ueventd.log" - int log_priority = LOG_INFO; +int log_fd = STDERR_FILENO; int rd_logging_level(const char *name) { @@ -21,24 +20,10 @@ int rd_logging_level(const char *name) return log_priority; } -void rd_logging_init(int loglevel) +void rd_logging_init(int fd, int loglevel) { - if (!getenv("UEVENTD_USE_STDERR")) { - char *rdlog = getenv("RDLOG"); - const char *logfile = default_logfile; - - if (rdlog && !strcasecmp(rdlog, "console")) - logfile = "/dev/console"; - - FILE *cons = fopen(logfile, "w+"); - if (!cons) - rd_fatal("open(%s): %m", logfile); - - fclose(stderr); - stderr = cons; - } - log_priority = loglevel; + log_fd = fd; } void rd_logging_close(void) @@ -52,12 +37,12 @@ void rd_message(int priority, const char *fmt, ...) if (priority <= log_priority) { time_t ts = time(NULL); struct tm *t = localtime(&ts); - fprintf(stderr, "[%04d-%02d-%02d %02d:%02d:%02d] %s: ", + dprintf(log_fd, "[%04d-%02d-%02d %02d:%02d:%02d] %s: ", t->tm_year + 1900, t->tm_mon + 1, t->tm_mday, t->tm_hour, t->tm_min, t->tm_sec, program_invocation_short_name); - vfprintf(stderr, fmt, ap); - fprintf(stderr, "\n"); + vdprintf(log_fd, fmt, ap); + dprintf(log_fd, "\n"); } va_end(ap); } diff --git a/datasrc/ueventd/ueventd.c b/datasrc/ueventd/ueventd.c index f4b89cb9..d015d3da 100644 --- a/datasrc/ueventd/ueventd.c +++ b/datasrc/ueventd/ueventd.c @@ -21,6 +21,8 @@ #include "ueventd.h" +#define default_logfile "/var/log/ueventd.log" + char *uevent_confdb; char *filter_dir; char *uevent_dir; @@ -474,7 +476,22 @@ int main(int argc, char **argv) if (optind == argc) rd_fatal("specify handler program"); - rd_logging_init(loglevel); + if (!getenv("UEVENTD_USE_STDERR")) { + char *rdlog = getenv("RDLOG"); + const char *logfile = default_logfile; + + if (rdlog && !strcasecmp(rdlog, "console")) + logfile = "/dev/console"; + + FILE *cons = fopen(logfile, "w+"); + if (!cons) + rd_fatal("open(%s): %m", logfile); + + fclose(stderr); + stderr = cons; + } + + rd_logging_init(fileno(stderr), loglevel); rd_info("starting server ..."); diff --git a/datasrc/ueventd/ueventd.h b/datasrc/ueventd/ueventd.h index e7ee1a8b..a783d48d 100644 --- a/datasrc/ueventd/ueventd.h +++ b/datasrc/ueventd/ueventd.h @@ -56,7 +56,7 @@ extern int is_dot_dir(struct dirent *ent) __attribute__((nonnull(1))); #include <syslog.h> #include <stdlib.h> -extern void rd_logging_init(int level); +extern void rd_logging_init(int log_fd, int level); extern void rd_logging_close(void); extern int rd_logging_level(const char *lvl) __attribute__((nonnull(1))); extern void rd_message(int priority, const char *fmt, ...) __attribute__((format(printf, 2, 3))); -- 2.33.7
next prev parent reply other threads:[~2023-05-06 19:45 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-04 13:42 [make-initrd] [PATCH 0/3] Reimplement ueventd Alexey Gladkov 2023-05-04 13:42 ` [make-initrd] [PATCH 1/3] " Alexey Gladkov 2023-05-05 3:08 ` Leonid Krivoshein 2023-05-05 17:02 ` Alexey Gladkov 2023-05-05 4:03 ` Leonid Krivoshein 2023-05-05 17:16 ` Alexey Gladkov 2023-05-05 5:21 ` Leonid Krivoshein 2023-05-05 17:24 ` Alexey Gladkov 2023-05-14 20:12 ` Leonid Krivoshein 2023-05-14 20:45 ` Alexey Gladkov 2023-05-14 20:57 ` Leonid Krivoshein 2023-05-15 8:52 ` Alexey Gladkov 2023-05-14 23:08 ` Leonid Krivoshein 2023-05-15 9:05 ` Alexey Gladkov 2023-05-15 0:47 ` Leonid Krivoshein 2023-05-15 9:12 ` Alexey Gladkov 2023-05-15 4:38 ` Leonid Krivoshein 2023-05-15 10:43 ` Alexey Gladkov 2023-05-18 6:39 ` Leonid Krivoshein 2023-05-18 7:05 ` Alexey Gladkov 2023-05-20 9:00 ` Leonid Krivoshein 2023-05-20 13:18 ` Alexey Gladkov 2023-05-20 15:17 ` Vladimir D. Seleznev 2023-05-20 17:23 ` Leonid Krivoshein 2023-05-20 18:51 ` Alexey Gladkov 2023-05-21 8:53 ` [make-initrd] [PATCH] ueventd: Don't use a epoll timeout when it's not needed Alexey Gladkov 2023-05-22 4:46 ` Leonid Krivoshein 2023-05-22 7:54 ` Alexey Gladkov 2023-05-22 9:19 ` Alexey Gladkov 2023-05-22 7:57 ` [make-initrd] [PATCH 1/2] ueventd: Fix memory leak Alexey Gladkov 2023-05-22 7:57 ` [make-initrd] [PATCH 2/2] ueventd: Change interface rd_asprintf_or_die Alexey Gladkov 2023-05-22 9:36 ` [make-initrd] [PATCH v2] " Alexey Gladkov 2023-05-20 16:37 ` [make-initrd] [PATCH 1/3] ueventd: Simplify call of the queue handler Alexey Gladkov 2023-05-20 16:37 ` [make-initrd] [PATCH 2/3] ueventd: Rename fd_list to fd_handler_list Alexey Gladkov 2023-05-20 16:37 ` [make-initrd] [PATCH 3/3] ueventd: Drop obsolete declarations Alexey Gladkov 2023-05-04 13:42 ` [make-initrd] [PATCH 2/3] Replace polld by uevent queue Alexey Gladkov 2023-05-04 13:42 ` [make-initrd] [PATCH 3/3] feature/kickstart: Reset rootdelay timer after kickstart Alexey Gladkov 2023-05-06 19:45 ` [make-initrd] ueventd: Add a prefix to the logging functions to avoid name collisions Alexey Gladkov 2023-05-06 19:45 ` Alexey Gladkov [this message] 2023-05-06 19:45 ` [make-initrd] ueventd: Pass the program name when initializing the logger Alexey Gladkov 2023-05-06 19:45 ` [make-initrd] ueventd: Rewrite logging function to make it more atomic Alexey Gladkov 2023-05-07 12:48 ` [make-initrd] [PATCH 0/3] Reimplement ueventd Alexey Gladkov 2023-05-13 11:50 ` Alexey Gladkov 2023-05-14 20:15 ` Leonid Krivoshein 2023-05-14 20:49 ` Alexey Gladkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230506194504.1471267-2-gladkov.alexey@gmail.com \ --to=gladkov.alexey@gmail.com \ --cc=make-initrd@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Make-initrd development discussion This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/make-initrd/0 make-initrd/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 make-initrd make-initrd/ http://lore.altlinux.org/make-initrd \ make-initrd@lists.altlinux.org make-initrd@lists.altlinux.ru make-initrd@lists.altlinux.com public-inbox-index make-initrd Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.make-initrd AGPL code for this site: git clone https://public-inbox.org/public-inbox.git