Linux console tools development discussion
 help / color / mirror / Atom feed
* [kbd] [PATCH] libkeymap: fix kmap on big-endian machines
@ 2014-03-14 23:32 Aaro Koskinen
  2014-03-15 11:08 ` Alexey Gladkov
  0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2014-03-14 23:32 UTC (permalink / raw)
  To: Alexey Gladkov, kbd; +Cc: Aaro Koskinen

Currently "loadkeys" does not work properly (no keys are ever changed)
on big-endian machines (e.g. SPARC and other classic hardware)
due to incorrect typing. The patch fixes this.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
 src/libkeymap/kmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libkeymap/kmap.c b/src/libkeymap/kmap.c
index e529136..85a3bb3 100644
--- a/src/libkeymap/kmap.c
+++ b/src/libkeymap/kmap.c
@@ -37,7 +37,7 @@ int
 lk_key_exists(struct lk_ctx *ctx, unsigned int k_table, unsigned int k_index)
 {
 	struct lk_array *map;
-	u_short *key;
+	unsigned int *key;
 
 	map = lk_array_get_ptr(ctx->keymap, k_table);
 	if (!map) {
-- 
1.9.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [kbd] [PATCH] libkeymap: fix kmap on big-endian machines
  2014-03-14 23:32 [kbd] [PATCH] libkeymap: fix kmap on big-endian machines Aaro Koskinen
@ 2014-03-15 11:08 ` Alexey Gladkov
  0 siblings, 0 replies; 2+ messages in thread
From: Alexey Gladkov @ 2014-03-15 11:08 UTC (permalink / raw)
  To: Aaro Koskinen, kbd

15.03.2014 03:32, Aaro Koskinen wrote:
> Currently "loadkeys" does not work properly (no keys are ever changed)
> on big-endian machines (e.g. SPARC and other classic hardware)
> due to incorrect typing. The patch fixes this.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>

Thanks!

> ---
>  src/libkeymap/kmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libkeymap/kmap.c b/src/libkeymap/kmap.c
> index e529136..85a3bb3 100644
> --- a/src/libkeymap/kmap.c
> +++ b/src/libkeymap/kmap.c
> @@ -37,7 +37,7 @@ int
>  lk_key_exists(struct lk_ctx *ctx, unsigned int k_table, unsigned int k_index)
>  {
>  	struct lk_array *map;
> -	u_short *key;
> +	unsigned int *key;
>  
>  	map = lk_array_get_ptr(ctx->keymap, k_table);
>  	if (!map) {
> 


-- 
Rgrds, legion



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-15 11:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-14 23:32 [kbd] [PATCH] libkeymap: fix kmap on big-endian machines Aaro Koskinen
2014-03-15 11:08 ` Alexey Gladkov

Linux console tools development discussion

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
		kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
	public-inbox-index kbd

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.kbd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git