From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on sa.int.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,SPF_SOFTFAIL autolearn=no version=3.2.5 Message-ID: <532434BC.6080903@gmail.com> Date: Sat, 15 Mar 2014 15:08:44 +0400 From: Alexey Gladkov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Aaro Koskinen , kbd@lists.altlinux.org References: <1394839976-18297-1-git-send-email-aaro.koskinen@iki.fi> In-Reply-To: <1394839976-18297-1-git-send-email-aaro.koskinen@iki.fi> X-Enigmail-Version: 1.6 OpenPGP: id=4CFFD434; url=http://pgp.mit.edu:11371/pks/lookup?op=vindex&fingerprint=on&search=0xA45ABA544CFFD434 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [kbd] [PATCH] libkeymap: fix kmap on big-endian machines X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Mar 2014 11:08:50 -0000 Archived-At: List-Archive: 15.03.2014 03:32, Aaro Koskinen wrote: > Currently "loadkeys" does not work properly (no keys are ever changed) > on big-endian machines (e.g. SPARC and other classic hardware) > due to incorrect typing. The patch fixes this. > > Signed-off-by: Aaro Koskinen Thanks! > --- > src/libkeymap/kmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libkeymap/kmap.c b/src/libkeymap/kmap.c > index e529136..85a3bb3 100644 > --- a/src/libkeymap/kmap.c > +++ b/src/libkeymap/kmap.c > @@ -37,7 +37,7 @@ int > lk_key_exists(struct lk_ctx *ctx, unsigned int k_table, unsigned int k_index) > { > struct lk_array *map; > - u_short *key; > + unsigned int *key; > > map = lk_array_get_ptr(ctx->keymap, k_table); > if (!map) { > -- Rgrds, legion