From: Alexey Sheplyakov <asheplyakov@basealt.ru> To: devel-kernel@lists.altlinux.org Cc: "Роман Ставцев" <rst@basealt.ru>, "Игорь Чудов" <nir@basealt.ru>, "Евгений Синельников" <sin@basealt.ru>, "Дмитрий Терёхин" <jqt4@basealt.ru> Subject: [d-kernel] [PATCH 31/32] phy: realtek: leds configuration for RTL8211f Date: Wed, 14 Dec 2022 17:19:18 +0400 Message-ID: <20221214131919.681481-31-asheplyakov@basealt.ru> (raw) In-Reply-To: <20221214131919.681481-1-asheplyakov@basealt.ru> Configure leds according to 'realtek,led-mode', 'realtek,led[0-2]-control' knobs (specified in DTB). Note that *all* of these parameters must be set in DTB for this to work. See https://my.basealt.space/issues/85133 X-feature-Baikal-M DONTUPSTREAM --- drivers/net/phy/realtek.c | 55 +++++++++++++++++++ .../dt-bindings/net/realtek-phy-rtl8211f.h | 26 +++++++++ 2 files changed, 81 insertions(+) create mode 100644 include/dt-bindings/net/realtek-phy-rtl8211f.h diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index 3d99fd6664d7..dd343b07ec8d 100644 --- a/drivers/net/phy/realtek.c +++ b/drivers/net/phy/realtek.c @@ -9,6 +9,7 @@ */ #include <linux/bitops.h> #include <linux/of.h> +#include <dt-bindings/net/realtek-phy-rtl8211f.h> #include <linux/phy.h> #include <linux/module.h> #include <linux/delay.h> @@ -30,6 +31,7 @@ #define RTL8211F_PHYCR1 0x18 #define RTL8211F_PHYCR2 0x19 #define RTL8211F_INSR 0x1d +#define RTL8211F_LCR 0x10 #define RTL8211F_TX_DELAY BIT(8) #define RTL8211F_RX_DELAY BIT(3) @@ -328,6 +330,56 @@ static int rtl8211_config_aneg(struct phy_device *phydev) return 0; } +static void rtl8211f_config_led(struct phy_device *phydev) +{ + struct device *dev = &phydev->mdio.dev; + struct device_node *of_node = dev->of_node; + u16 val; + u32 led_mode, led0_ctrl, led1_ctrl, led2_ctrl; + int ret; + + ret = of_property_read_u32(of_node, "realtek,led-mode", &led_mode); + if (ret < 0) { + dev_dbg(dev, "refusing to reconfigure leds: no 'realtek,led-mode' in dtb\n"); + return; + } + ret = of_property_read_u32(of_node, "realtek,led0-control", &led0_ctrl); + if (ret < 0) { + dev_dbg(dev, "refusing to reconfigure leds: no 'realtek,led0-control' in dtb\n"); + return; + } + ret = of_property_read_u32(of_node, "realtek,led1-control", &led1_ctrl); + if (ret < 0) { + dev_dbg(dev, "refusing to reconfigure leds: no 'realtek,led1-control' in dtb\n"); + return; + } + ret = of_property_read_u32(of_node, "realtek,led2-control", &led2_ctrl); + if (ret < 0) { + dev_dbg(dev, "refusing to reconfigure leds: no 'realtek,led-control' in dtb\n"); + return; + } + + val = (led_mode << 15) | (led2_ctrl << 10) | + (led1_ctrl << 5) | led0_ctrl; + + ret = phy_write_paged(phydev, 0xd04, RTL8211F_LCR, val); + if (ret < 0) + dev_dbg(dev, "Failed to update the LED control register\n"); +} + +static int rtl8211f_config_aneg(struct phy_device *phydev) +{ + int ret; + + rtl8211f_config_led(phydev); + + ret = genphy_config_aneg(phydev); + if (ret < 0) + return ret; + + return 0; +} + static int rtl8211c_config_init(struct phy_device *phydev) { /* RTL8211C has an issue when operating in Gigabit slave mode */ @@ -342,6 +394,8 @@ static int rtl8211f_config_init(struct phy_device *phydev) u16 val_txdly, val_rxdly; int ret; + rtl8211f_config_led(phydev); + ret = phy_modify_paged_changed(phydev, 0xa43, RTL8211F_PHYCR1, RTL8211F_ALDPS_PLL_OFF | RTL8211F_ALDPS_ENABLE | RTL8211F_ALDPS_XTAL_OFF, priv->phycr1); @@ -923,6 +977,7 @@ static struct phy_driver realtek_drvs[] = { PHY_ID_MATCH_EXACT(0x001cc916), .name = "RTL8211F Gigabit Ethernet", .probe = rtl821x_probe, + .config_aneg = rtl8211f_config_aneg, .config_init = &rtl8211f_config_init, .read_status = rtlgen_read_status, .config_intr = &rtl8211f_config_intr, diff --git a/include/dt-bindings/net/realtek-phy-rtl8211f.h b/include/dt-bindings/net/realtek-phy-rtl8211f.h new file mode 100644 index 000000000000..46d17644119d --- /dev/null +++ b/include/dt-bindings/net/realtek-phy-rtl8211f.h @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _DT_BINDINGS_REALTEK_PHY_RTL8211F_H +#define _DT_BINDINGS_REALTEK_PHY_RTL8211F_H + +/* LED modes for RTL8211F PHY */ + +#define RTL8211F_LED_MODE_A 0 +#define RTL8211F_LED_MODE_B 1 + +#define RTL8211F_LINK_10 1 +#define RTL8211F_LINK_100 2 +#define RTL8211F_LINK_10_100 3 +#define RTL8211F_LINK_1000 8 +#define RTL8211F_LINK_10_1000 9 +#define RTL8211F_LINK_100_1000 10 +#define RTL8211F_LINK_10_100_1000 11 +#define RTL8211F_ACTIVITY 16 +#define RTL8211F_LINK_10_ACTIVITY 17 +#define RTL8211F_LINK_100_ACTIVITY 18 +#define RTL8211F_LINK_10_100_ACTIVITY 19 +#define RTL8211F_LINK_1000_ACTIVITY 24 +#define RTL8211F_LINK_10_1000_ACTIVITY 25 +#define RTL8211F_LINK_100_1000_ACTIVITY 26 +#define RTL8211F_LINK_10_100_1000_ACTIVITY 27 + +#endif -- 2.33.5
next prev parent reply other threads:[~2022-12-14 13:19 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-14 13:18 [d-kernel] [PATCH 01/32] clk: added Baikal-M clock management unit driver Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 02/32] cpufreq-dt: don't load on Baikal-M SoC Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 03/32] serial: 8250_dw: verify clock rate in dw8250_set_termios Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 04/32] usb: dwc3: of-simple: added compatible string for Baikal-M SoC Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 05/32] dw-pcie: refuse to load on Baikal-M with recent firmware Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 06/32] arm64: Enable armv8 based Baikal-M SoC support Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 07/32] efi-rtc: avoid calling efi.get_time on Baikal-M SoC Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 08/32] arm64-stub: fixed secondary cores boot " Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 09/32] pm: disable all sleep states on Baikal-M based boards Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 10/32] net: fwnode_get_phy_id: consider all compatible strings Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 11/32] net: stmmac: inital support of Baikal-T1/M SoCs GMAC Alexey Sheplyakov 2022-12-14 13:18 ` [d-kernel] [PATCH 12/32] dt-bindings: dwmac: Add bindings for Baikal-T1/M SoCs Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 13/32] net: dwmac-baikal: added compatible strings Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 14/32] Added TF307/TF306 board management controller driver Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 15/32] hwmon: bt1-pvt: access registers via pvt_{readl, writel} helpers Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 16/32] hwmon: bt1-pvt: define pvt_readl/pvt_writel for Baikal-M SoC Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 17/32] hwmon: bt1-pvt: adjusted probing " Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 18/32] hwmon: bt1-pvt: added compatible baikal, pvt Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 19/32] drm: new bridge driver - stdp4028 Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 20/32] drm: added Baikal-M SoC video display unit driver Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 21/32] drm/bridge: dw-hdmi: support ahb audio hw revision 0x2a Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 22/32] dt-bindings: dw-hdmi: added ahb-audio-regshift Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 23/32] drm/bridge: dw-hdmi: force ahb audio register offset for Baikal-M Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 24/32] drm/panfrost: forcibly set dma-coherent on Baikal-M Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 25/32] drm/panfrost: disable devfreq " Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 26/32] ALSA: hda: Baikal-M support Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 27/32] PCI: pcie-baikal: driver for Baikal-M with new firmware Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 28/32] (BROKEN) dwc-i2s: support Baikal-M SoC Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 29/32] input: added TF307 serio PS/2 emulator driver Alexey Sheplyakov 2022-12-14 13:19 ` [d-kernel] [PATCH 30/32] input: new driver - serdev-serio Alexey Sheplyakov 2022-12-14 13:19 ` Alexey Sheplyakov [this message] 2022-12-14 15:06 ` [d-kernel] [PATCH 01/32] clk: added Baikal-M clock management unit driver Vitaly Chikunov 2022-12-16 9:54 ` Alexey Sheplyakov 2022-12-16 12:34 ` Vitaly Chikunov 2022-12-16 12:40 ` Vitaly Chikunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221214131919.681481-31-asheplyakov@basealt.ru \ --to=asheplyakov@basealt.ru \ --cc=devel-kernel@lists.altlinux.org \ --cc=jqt4@basealt.ru \ --cc=nir@basealt.ru \ --cc=rst@basealt.ru \ --cc=sin@basealt.ru \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
ALT Linux kernel packages development This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/devel-kernel/0 devel-kernel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 devel-kernel devel-kernel/ http://lore.altlinux.org/devel-kernel \ devel-kernel@altlinux.org devel-kernel@altlinux.ru devel-kernel@altlinux.com public-inbox-index devel-kernel Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.devel-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git