* [make-initrd] [PATCH v1 16/41] fork pipeline: waitdev: get_dev_wpfx() function added
@ 2021-09-24 15:57 Leonid Krivoshein
2021-09-26 14:06 ` Alexey Gladkov
0 siblings, 1 reply; 4+ messages in thread
From: Leonid Krivoshein @ 2021-09-24 15:57 UTC (permalink / raw)
To: make-initrd
---
.../data/lib/uevent/filters/bootchain-waitdev | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git
a/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
b/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
index 272aee7..13d90fa 100755
---
a/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
+++
b/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
@@ -3,6 +3,23 @@
. /.initrd/initenv
. initrd-sh-functions
+get_dev_wpfx()
+{
+ local retval="$1" name="$2"
+
+ case "$name" in
+ CDROM:*)
+ [ "${ID_CDROM-}" = 1 ] ||
+ [ "${ID_FS_TYPE-}" = iso9660 ] ||
+ return 1
+ name="${name#CDROM:}"
+ name="${name:-/dev/sr0}"
+ ;;
+ esac
+
+ get_dev "$retval" "$name"
+}
+
mkdir -p -- /.initrd/bootchain/waitdev
cd /.initrd/bootchain/waitdev/
@@ -10,7 +27,7 @@ i=0
while [ "$i" -lt "${WAITDEV:-0}" ]; do
eval "spec=\"\${WAITDEV$i-}\""
- if [ -n "$spec" ] && get_dev dev "$spec"; then
+ if [ -n "$spec" ] && get_dev_wpfx dev "$spec"; then
printf '%s\n' "$dev" > "$i"
fi
-- 2.21.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [make-initrd] [PATCH v1 16/41] fork pipeline: waitdev: get_dev_wpfx() function added
2021-09-24 15:57 [make-initrd] [PATCH v1 16/41] fork pipeline: waitdev: get_dev_wpfx() function added Leonid Krivoshein
@ 2021-09-26 14:06 ` Alexey Gladkov
2021-09-26 19:42 ` Leonid Krivoshein
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Gladkov @ 2021-09-26 14:06 UTC (permalink / raw)
To: make-initrd
On Fri, Sep 24, 2021 at 06:57:08PM +0300, Leonid Krivoshein wrote:
> ---
> .../data/lib/uevent/filters/bootchain-waitdev | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev b/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
> index 272aee7..13d90fa 100755
> --- a/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
> +++ b/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
> @@ -3,6 +3,23 @@
> . /.initrd/initenv
> . initrd-sh-functions
> +get_dev_wpfx()
Я-то думал, что только чехи на гласных экономят!
Что такое wpfx ?
Добавь описание коммиту.
> +{
> + local retval="$1" name="$2"
> +
> + case "$name" in
> + CDROM:*)
> + [ "${ID_CDROM-}" = 1 ] ||
> + [ "${ID_FS_TYPE-}" = iso9660 ] ||
> + return 1
> + name="${name#CDROM:}"
> + name="${name:-/dev/sr0}"
> + ;;
> + esac
> +
> + get_dev "$retval" "$name"
> +}
> +
> mkdir -p -- /.initrd/bootchain/waitdev
> cd /.initrd/bootchain/waitdev/
> @@ -10,7 +27,7 @@ i=0
> while [ "$i" -lt "${WAITDEV:-0}" ]; do
> eval "spec=\"\${WAITDEV$i-}\""
> - if [ -n "$spec" ] && get_dev dev "$spec"; then
> + if [ -n "$spec" ] && get_dev_wpfx dev "$spec"; then
> printf '%s\n' "$dev" > "$i"
> fi
> -- 2.21.0
>
>
> _______________________________________________
> Make-initrd mailing list
> Make-initrd@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/make-initrd
>
--
Rgrds, legion
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [make-initrd] [PATCH v1 16/41] fork pipeline: waitdev: get_dev_wpfx() function added
2021-09-26 14:06 ` Alexey Gladkov
@ 2021-09-26 19:42 ` Leonid Krivoshein
2021-09-27 9:01 ` Alexey Gladkov
0 siblings, 1 reply; 4+ messages in thread
From: Leonid Krivoshein @ 2021-09-26 19:42 UTC (permalink / raw)
To: make-initrd
26.09.2021 17:06, Alexey Gladkov пишет:
> On Fri, Sep 24, 2021 at 06:57:08PM +0300, Leonid Krivoshein wrote:
>> ---
>> .../data/lib/uevent/filters/bootchain-waitdev | 19 ++++++++++++++++++-
>> 1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev b/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
>> index 272aee7..13d90fa 100755
>> --- a/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
>> +++ b/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
>> @@ -3,6 +3,23 @@
>> . /.initrd/initenv
>> . initrd-sh-functions
>> +get_dev_wpfx()
> Я-то думал, что только чехи на гласных экономят!
>
> Что такое wpfx ?
with prefix
Извини, я думал это распространённое сокращение.
Можно обозвать get_dev_prefixed, так нормально?
> Добавь описание коммиту.
OK
>> +{
>> + local retval="$1" name="$2"
>> +
>> + case "$name" in
>> + CDROM:*)
>> + [ "${ID_CDROM-}" = 1 ] ||
>> + [ "${ID_FS_TYPE-}" = iso9660 ] ||
>> + return 1
>> + name="${name#CDROM:}"
>> + name="${name:-/dev/sr0}"
>> + ;;
>> + esac
>> +
>> + get_dev "$retval" "$name"
>> +}
>> +
>> mkdir -p -- /.initrd/bootchain/waitdev
>> cd /.initrd/bootchain/waitdev/
>> @@ -10,7 +27,7 @@ i=0
>> while [ "$i" -lt "${WAITDEV:-0}" ]; do
>> eval "spec=\"\${WAITDEV$i-}\""
>> - if [ -n "$spec" ] && get_dev dev "$spec"; then
>> + if [ -n "$spec" ] && get_dev_wpfx dev "$spec"; then
>> printf '%s\n' "$dev" > "$i"
>> fi
>> -- 2.21.0
>>
>>
>> _______________________________________________
>> Make-initrd mailing list
>> Make-initrd@lists.altlinux.org
>> https://lists.altlinux.org/mailman/listinfo/make-initrd
>>
--
Best regards,
Leonid Krivoshein.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [make-initrd] [PATCH v1 16/41] fork pipeline: waitdev: get_dev_wpfx() function added
2021-09-26 19:42 ` Leonid Krivoshein
@ 2021-09-27 9:01 ` Alexey Gladkov
0 siblings, 0 replies; 4+ messages in thread
From: Alexey Gladkov @ 2021-09-27 9:01 UTC (permalink / raw)
To: make-initrd
On Sun, Sep 26, 2021 at 10:42:11PM +0300, Leonid Krivoshein wrote:
>
> 26.09.2021 17:06, Alexey Gladkov пишет:
> > On Fri, Sep 24, 2021 at 06:57:08PM +0300, Leonid Krivoshein wrote:
> > > ---
> > > .../data/lib/uevent/filters/bootchain-waitdev | 19 ++++++++++++++++++-
> > > 1 file changed, 18 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev b/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
> > > index 272aee7..13d90fa 100755
> > > --- a/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
> > > +++ b/make-initrd/features/bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev
> > > @@ -3,6 +3,23 @@
> > > . /.initrd/initenv
> > > . initrd-sh-functions
> > > +get_dev_wpfx()
> > Я-то думал, что только чехи на гласных экономят!
> >
> > Что такое wpfx ?
>
> with prefix
>
> Извини, я думал это распространённое сокращение.
> Можно обозвать get_dev_prefixed, так нормально?
Да. Так лучше.
--
Rgrds, legion
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-27 9:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 15:57 [make-initrd] [PATCH v1 16/41] fork pipeline: waitdev: get_dev_wpfx() function added Leonid Krivoshein
2021-09-26 14:06 ` Alexey Gladkov
2021-09-26 19:42 ` Leonid Krivoshein
2021-09-27 9:01 ` Alexey Gladkov
Make-initrd development discussion
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/make-initrd/0 make-initrd/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 make-initrd make-initrd/ http://lore.altlinux.org/make-initrd \
make-initrd@lists.altlinux.org make-initrd@lists.altlinux.ru make-initrd@lists.altlinux.com
public-inbox-index make-initrd
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.make-initrd
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git