Linux console tools development discussion
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	linux-kernel@vger.kernel.org, kbd@lists.altlinux.org
Subject: Re: [kbd] [patchv2 1/3] VT: Add height parameter to con_font_get/set consw operations
Date: Thu, 19 Jan 2023 16:09:10 +0100
Message-ID: <Y8ldFjz7d6/CMA0w@kroah.com> (raw)
In-Reply-To: <20221218003237.350270019@ens-lyon.org>

On Sun, Dec 18, 2022 at 01:32:10AM +0100, Samuel Thibault wrote:
> The current con_font_get/set API currently hardcodes a 32-pixel-tall
> limitation, which only dates from the old VGA hardware which could not
> handle taller fonts than that.
> 
> This change just adds a vpitch parameter to release this
> constraint. Drivers which do not support vpitch != 32 can just return
> EINVAL when it is not 32, font loading tools will revert to trying 32
> and succeed.
> 
> This change makes the fbcon driver consider vpitch appropriately, thus
> making it able to load large fonts.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> 
> ---
> V1 -> V2: Drop (bogus) sisusb_con.c change, it is being phased out
> 
> Index: linux-6.0/drivers/tty/vt/vt.c

6.0 was really old when you sent this, and because of that:

> Index: linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
> ===================================================================

This file is not even in the tree anymore.

Can you rebase this against 6.2-rc4 and resubmit it so that I can apply
it?  As-is, it will not apply at all :(

thanks,

greg k-h


  reply	other threads:[~2023-01-19 15:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-18  0:32 [kbd] [patchv2 0/3] VT: Support >32x32 fonts for hidpi displays Samuel Thibault
2022-12-18  0:32 ` [kbd] [patchv2 1/3] VT: Add height parameter to con_font_get/set consw operations Samuel Thibault
2023-01-19 15:09   ` Greg Kroah-Hartman [this message]
2023-01-19 15:20     ` Samuel Thibault
2022-12-18  0:32 ` [kbd] [patchv2 2/3] VT: Add KD_FONT_OP_SET/GET_TALL operations Samuel Thibault
2022-12-18  0:32 ` [kbd] [patchv2 3/3] VT: Bump font size limitation to 64x128 pixels Samuel Thibault
2022-12-18 14:39   ` Alexey Gladkov
2022-12-18 14:55     ` Samuel Thibault
2022-12-18 15:25       ` Alexey Gladkov
2022-12-18 15:28         ` Samuel Thibault
2022-12-18 15:38           ` Alexey Gladkov
2023-01-19 14:55             ` Greg Kroah-Hartman
2022-12-18  0:33 ` [kbd] [patch] font: Leverage KD_FONT_OP_GET/SET_TALL font operations Samuel Thibault
2023-01-11 20:00   ` Alexey Gladkov
2023-01-16 22:44     ` Samuel Thibault
2023-01-10 20:55 ` [kbd] [patchv2 0/3] VT: Support >32x32 fonts for hidpi displays Samuel Thibault
2023-01-18 14:00   ` Alexey Gladkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8ldFjz7d6/CMA0w@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kbd@lists.altlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux console tools development discussion

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
		kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
	public-inbox-index kbd

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.kbd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git