From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674140952; bh=guV+7vZU2mp7GLs0aTWp0QCEGimoOkaahg6PxJ1vaLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=isoK5H4UzpNEDiK7U/JPxRpHowtEBJKWH/I8q5mldwVgwYBF+ptPdPmQD3tRpSXQ3 Qqm0cveU5vcUyB4d1nCG8e8/Eh0hUrtKKF4qLa1/lAHGNy3+hNeUxhQsHrWybXpsy7 ggkhIpog1JYFflNQj/CtUi3tOOKAyZE2F8Wjau54= Date: Thu, 19 Jan 2023 16:09:10 +0100 From: Greg Kroah-Hartman To: Samuel Thibault Message-ID: References: <20221218003209.503539532@ens-lyon.org> <20221218003237.350270019@ens-lyon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221218003237.350270019@ens-lyon.org> Cc: Jiri Slaby , linux-kernel@vger.kernel.org, kbd@lists.altlinux.org Subject: Re: [kbd] [patchv2 1/3] VT: Add height parameter to con_font_get/set consw operations X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2023 15:09:15 -0000 Archived-At: List-Archive: On Sun, Dec 18, 2022 at 01:32:10AM +0100, Samuel Thibault wrote: > The current con_font_get/set API currently hardcodes a 32-pixel-tall > limitation, which only dates from the old VGA hardware which could not > handle taller fonts than that. > > This change just adds a vpitch parameter to release this > constraint. Drivers which do not support vpitch != 32 can just return > EINVAL when it is not 32, font loading tools will revert to trying 32 > and succeed. > > This change makes the fbcon driver consider vpitch appropriately, thus > making it able to load large fonts. > > Signed-off-by: Samuel Thibault > > --- > V1 -> V2: Drop (bogus) sisusb_con.c change, it is being phased out > > Index: linux-6.0/drivers/tty/vt/vt.c 6.0 was really old when you sent this, and because of that: > Index: linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c > =================================================================== This file is not even in the tree anymore. Can you rebase this against 6.2-rc4 and resubmit it so that I can apply it? As-is, it will not apply at all :( thanks, greg k-h