From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: Felix Janda <felix.janda@posteo.de>
Cc: kbd@lists.altlinux.org
Subject: Re: [kbd] [PATCH 5/5] Replace error() by fprintf() and perror()
Date: Tue, 05 May 2015 02:10:27 +0300
Message-ID: <5547FC63.5090205@gmail.com> (raw)
In-Reply-To: <20150504195148.GA3967@euler>
04.05.2015 22:51, Felix Janda пишет:
> Спасибо, looks like much more consistent and also more informative
> error reporting.
:))))
> Now that there is also kbd_warning(), it is no longer necessary to let
> kbd_error() treat 0 specially and it can get an __attribute__(noreturn).
> See attached patch.
Good catch!
I prefer to save compatibility with the error() function. It costs
nothing, but it does not require to keep in mind the difference
between two implementations.
--
Rgrds, legion
next prev parent reply other threads:[~2015-05-04 23:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 19:06 Felix Janda
2015-04-26 11:18 ` Alexey Gladkov
2015-04-28 22:08 ` Alexey Gladkov
2015-04-29 18:11 ` Felix Janda
2015-04-30 19:21 ` Alexey Gladkov
2015-04-30 20:36 ` Felix Janda
2015-05-04 18:38 ` Alexey Gladkov
2015-05-04 23:10 ` Alexey Gladkov [this message]
2015-05-06 19:34 ` Felix Janda
2015-05-11 22:00 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547FC63.5090205@gmail.com \
--to=gladkov.alexey@gmail.com \
--cc=felix.janda@posteo.de \
--cc=kbd@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux console tools development discussion
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
public-inbox-index kbd
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.kbd
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git