From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on sa.local.altlinux.org X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DNS_FROM_AHBL_RHSBL,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.0 Message-ID: <5547FC63.5090205@gmail.com> Date: Tue, 05 May 2015 02:10:27 +0300 From: Alexey Gladkov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Felix Janda References: <20150422190649.GE3170@euler> <554004DA.3060108@gmail.com> <20150429181152.GC1364@euler> <5547BCB9.3030200@gmail.com> <20150504195148.GA3967@euler> In-Reply-To: <20150504195148.GA3967@euler> OpenPGP: id=4CFFD434; url=http://pgp.mit.edu:11371/pks/lookup?op=vindex&fingerprint=on&search=0xA45ABA544CFFD434 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kbd@lists.altlinux.org Subject: Re: [kbd] [PATCH 5/5] Replace error() by fprintf() and perror() X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 23:09:45 -0000 Archived-At: List-Archive: 04.05.2015 22:51, Felix Janda пишет: > Спасибо, looks like much more consistent and also more informative > error reporting. :)))) > Now that there is also kbd_warning(), it is no longer necessary to let > kbd_error() treat 0 specially and it can get an __attribute__(noreturn). > See attached patch. Good catch! I prefer to save compatibility with the error() function. It costs nothing, but it does not require to keep in mind the difference between two implementations. -- Rgrds, legion