Re: [kbd] [PATCH] vlock: Handle tty dying

[Alexey Gladkov <gladkov.alexey@gmail.com>]

23.01.2015 20:46, Dmitry V. Levin пишет:
> Hi,
> 
> On Fri, Sep 26, 2014 at 05:42:14AM +0000, Kyle Manna wrote:
>> Hi guys,
>>
>> I ran into a problem where if vlock was running over ssh and the ssh
>> session died my system logs would get spammed by the now orphaned vlock
>> process on Arch Linux:
>>
>>     Sep 25 20:51:12 hostname vlock[31336]: pam_unix(vlock:auth): auth could not identify password for [user]
>>     Sep 25 20:51:13 hostname vlock[31336]: pam_unix(vlock:auth): auth could not identify password for [user]
>>     Sep 25 20:51:14 hostname vlock[31336]: pam_unix(vlock:auth): auth could not identify password for [user]
>>
>> I was able to re-create this in many other situations (ssh, xterm
>> window/tab, tmux window/pane, etc).
>>
>> The patch know checks for a tty on stdin where PAM will likely ask for
>> the password and exits if it's not found.
> 
> I've never seen this myself because in systems where I use vlock
> pam_authenticate consistently returns PAM_INCOMPLETE in such cases.
> 
> I'll shortly post patches to handle these cases gracefully.

Applied. Thanks a lot!

-- 
Rgrds, legion