From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on sa.local.altlinux.org X-Spam-Level: *** X-Spam-Status: No, score=4.0 required=5.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED, DNS_FROM_AHBL_RHSBL, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.0 Message-ID: <54C4D119.40209@gmail.com> Date: Sun, 25 Jan 2015 14:18:49 +0300 From: Alexey Gladkov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: kbd@lists.altlinux.org References: <20140926054204.GH3701@kylemanna.com> <20150123174626.GA9914@altlinux.org> In-Reply-To: <20150123174626.GA9914@altlinux.org> OpenPGP: id=4CFFD434; url=http://pgp.mit.edu:11371/pks/lookup?op=vindex&fingerprint=on&search=0xA45ABA544CFFD434 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [kbd] [PATCH] vlock: Handle tty dying X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Jan 2015 14:18:52 -0000 Archived-At: List-Archive: 23.01.2015 20:46, Dmitry V. Levin пишет: > Hi, > > On Fri, Sep 26, 2014 at 05:42:14AM +0000, Kyle Manna wrote: >> Hi guys, >> >> I ran into a problem where if vlock was running over ssh and the ssh >> session died my system logs would get spammed by the now orphaned vlock >> process on Arch Linux: >> >> Sep 25 20:51:12 hostname vlock[31336]: pam_unix(vlock:auth): auth could not identify password for [user] >> Sep 25 20:51:13 hostname vlock[31336]: pam_unix(vlock:auth): auth could not identify password for [user] >> Sep 25 20:51:14 hostname vlock[31336]: pam_unix(vlock:auth): auth could not identify password for [user] >> >> I was able to re-create this in many other situations (ssh, xterm >> window/tab, tmux window/pane, etc). >> >> The patch know checks for a tty on stdin where PAM will likely ask for >> the password and exits if it's not found. > > I've never seen this myself because in systems where I use vlock > pam_authenticate consistently returns PAM_INCOMPLETE in such cases. > > I'll shortly post patches to handle these cases gracefully. Applied. Thanks a lot! -- Rgrds, legion