Linux console tools development discussion
 help / color / mirror / Atom feed
* [kbd] unicode option for not working correctly since commit: bad17ea03
@ 2016-06-16  1:06 Michal Soltys
  2016-09-06 19:26 ` Alexey Gladkov
  2016-09-21  9:53 ` Alexey Gladkov
  0 siblings, 2 replies; 10+ messages in thread
From: Michal Soltys @ 2016-06-16  1:06 UTC (permalink / raw)
  To: kbd

Hi,

The last commit (found through biscection) where kbd worked correctly with:

loadkeys -u

when the console is set to proper unicode mode was

http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=8d37c0e76fdb487845da74bdf0bbce13eebf7596

So for example (assuming LANG is set correctly as well to utf8 locale):

unicode_start LatArCyrHeb-16
loadkeys -u pl

still behaved fine.

But after two subsequent commits:

1) 
http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=3fdbff332a6ef88a2447584c47a8616dceb19548 
(kbd doesn't compile as-is in this commit)

2) 
http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=bad17ea033bf571e03b05e1330e81e6238fd61f0 
(kbd compiles fine here)

loadkeys -u no longer works and despite the console operating in utf-8 
mode requires console map (in this case -m 8859-2).



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [kbd] unicode option for not working correctly since commit: bad17ea03
  2016-06-16  1:06 [kbd] unicode option for not working correctly since commit: bad17ea03 Michal Soltys
@ 2016-09-06 19:26 ` Alexey Gladkov
  2016-09-19 20:10   ` Michal Soltys
  2016-09-21  9:53 ` Alexey Gladkov
  1 sibling, 1 reply; 10+ messages in thread
From: Alexey Gladkov @ 2016-09-06 19:26 UTC (permalink / raw)
  To: Linux console tools development discussion

On Thu, Jun 16, 2016 at 03:06:43AM +0200, Michal Soltys wrote:
> Hi,
> 
> So for example (assuming LANG is set correctly as well to utf8 locale):
> 
> unicode_start LatArCyrHeb-16
> loadkeys -u pl

Can you show me your keymap ?

> still behaved fine.
> 
> loadkeys -u no longer works and despite the console operating in utf-8 
> mode requires console map (in this case -m 8859-2).

You mean `setfont -m 8859-2 ...` ?

-- 
Rgrds, legion



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [kbd] unicode option for not working correctly since commit: bad17ea03
  2016-09-06 19:26 ` Alexey Gladkov
@ 2016-09-19 20:10   ` Michal Soltys
  2016-09-19 23:58     ` Felix Janda
  0 siblings, 1 reply; 10+ messages in thread
From: Michal Soltys @ 2016-09-19 20:10 UTC (permalink / raw)
  To: Linux console tools development discussion

On 2016-09-06 21:26, Alexey Gladkov wrote:
> On Thu, Jun 16, 2016 at 03:06:43AM +0200, Michal Soltys wrote:
>> Hi,
>> 
>> So for example (assuming LANG is set correctly as well to utf8 locale):
>> 
>> unicode_start LatArCyrHeb-16
>> loadkeys -u pl
> 
> Can you show me your keymap ?
> 

It's standard kbd keymap (pl.map.gz).

>> still behaved fine.
>> 
>> loadkeys -u no longer works and despite the console operating in utf-8 
>> mode requires console map (in this case -m 8859-2).
> 
> You mean `setfont -m 8859-2 ...` ?
> 

Yea, it still seems to handle input with 8th bit set providing
workaround for the issue.

Simple test:

1) log on console, assure proper LANG (e.g. pl_PL.utf8 or en_US.utf8)
2) unicode_start LatArCyrHeb-16
3) loadkeys -u pl

This basically should work just fine. Polish glyphs are under
alt-a,c,e,l,n,o,s,x,z

On pre-2.0 versions all will be working fine (or to be precise,
pre-commit I bisected). After that commit some will be failing. If you
do setfont -m 8859-2 - this will provide the workaround.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [kbd] unicode option for not working correctly since commit: bad17ea03
  2016-09-19 20:10   ` Michal Soltys
@ 2016-09-19 23:58     ` Felix Janda
  2016-09-20 18:13       ` Michal Soltys
  0 siblings, 1 reply; 10+ messages in thread
From: Felix Janda @ 2016-09-19 23:58 UTC (permalink / raw)
  To: Linux console tools development discussion

Michal Soltys wrote:
[..]
> On pre-2.0 versions all will be working fine (or to be precise,
> pre-commit I bisected). After that commit some will be failing. If you
> do setfont -m 8859-2 - this will provide the workaround.

It might be useful to further bisect: I can see that compilation of
dumpkeys will fail directly after commit

http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=3fdbff332a6ef88a2447584c47a8616dceb19548

(e.g. because of missing lk_list_charsets). But is it in this situation
maybe still possible to directly build loadkeys ("make loadkeys" in the
src directory)?

Felix


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [kbd] unicode option for not working correctly since commit: bad17ea03
  2016-09-19 23:58     ` Felix Janda
@ 2016-09-20 18:13       ` Michal Soltys
  2016-09-20 19:33         ` Felix Janda
  0 siblings, 1 reply; 10+ messages in thread
From: Michal Soltys @ 2016-09-20 18:13 UTC (permalink / raw)
  To: Linux console tools development discussion

On 2016-09-20 01:58, Felix Janda wrote:
> Michal Soltys wrote:
> [..]
>> On pre-2.0 versions all will be working fine (or to be precise,
>> pre-commit I bisected). After that commit some will be failing. If you
>> do setfont -m 8859-2 - this will provide the workaround.
> 
> It might be useful to further bisect: I can see that compilation of
> dumpkeys will fail directly after commit
> 
> http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=3fdbff332a6ef88a2447584c47a8616dceb19548
> 
> (e.g. because of missing lk_list_charsets). But is it in this situation
> maybe still possible to directly build loadkeys ("make loadkeys" in the
> src directory)?
> 

The last commit that did compile (where it was working fine) was:

http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=8d37c0e76fdb487845da74bdf0bbce13eebf7596

(so directly preceeding the one you mentioned)

And since:

http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=bad17ea033bf571e03b05e1330e81e6238fd61f0

loadkeys -u have issues


My earlier mail where I reported it:

https://lists.altlinux.org/pipermail/kbd/2016-June/000591.html



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [kbd] unicode option for not working correctly since commit: bad17ea03
  2016-09-20 18:13       ` Michal Soltys
@ 2016-09-20 19:33         ` Felix Janda
  0 siblings, 0 replies; 10+ messages in thread
From: Felix Janda @ 2016-09-20 19:33 UTC (permalink / raw)
  To: Linux console tools development discussion

Michal Soltys wrote:
> On 2016-09-20 01:58, Felix Janda wrote:
> > Michal Soltys wrote:
> > [..]
> >> On pre-2.0 versions all will be working fine (or to be precise,
> >> pre-commit I bisected). After that commit some will be failing. If you
> >> do setfont -m 8859-2 - this will provide the workaround.
> > 
> > It might be useful to further bisect: I can see that compilation of
> > dumpkeys will fail directly after commit
> > 
> > http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=3fdbff332a6ef88a2447584c47a8616dceb19548
> > 
> > (e.g. because of missing lk_list_charsets). But is it in this situation
> > maybe still possible to directly build loadkeys ("make loadkeys" in the
> > src directory)?
> > 
> 
> The last commit that did compile (where it was working fine) was:
> 
> http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=8d37c0e76fdb487845da74bdf0bbce13eebf7596
> 
> (so directly preceeding the one you mentioned)
> 
> And since:
> 
> http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=bad17ea033bf571e03b05e1330e81e6238fd61f0
> 
> loadkeys -u have issues

I understand that.

It would just be nice to see more clearly which of the two commits
causes the issue. (I think the compilation failure is unrelated to your
issue.)

So, with the broken commit, does only the compilation of dumpkeys fail
or also something else? If only dumpkeys fails, it should be no problem
to build loadkeys, and you could test if already that commit breaks
loadkeys.

Felix


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [kbd] unicode option for not working correctly since commit: bad17ea03
  2016-06-16  1:06 [kbd] unicode option for not working correctly since commit: bad17ea03 Michal Soltys
  2016-09-06 19:26 ` Alexey Gladkov
@ 2016-09-21  9:53 ` Alexey Gladkov
  2016-10-19 19:36   ` Alexey Gladkov
  1 sibling, 1 reply; 10+ messages in thread
From: Alexey Gladkov @ 2016-09-21  9:53 UTC (permalink / raw)
  To: Linux console tools development discussion

On Thu, Jun 16, 2016 at 03:06:43AM +0200, Michal Soltys wrote:
> http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=3fdbff332a6ef88a2447584c47a8616dceb19548 
> (kbd doesn't compile as-is in this commit)

I think problem in this commit.

-- 
Rgrds, legion



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [kbd] unicode option for not working correctly since commit: bad17ea03
  2016-09-21  9:53 ` Alexey Gladkov
@ 2016-10-19 19:36   ` Alexey Gladkov
  2016-10-19 21:36     ` Michal Soltys
  2016-10-31 15:28     ` Michal Soltys
  0 siblings, 2 replies; 10+ messages in thread
From: Alexey Gladkov @ 2016-10-19 19:36 UTC (permalink / raw)
  To: Linux console tools development discussion

On Wed, Sep 21, 2016 at 11:53:37AM +0200, Alexey Gladkov wrote:
> On Thu, Jun 16, 2016 at 03:06:43AM +0200, Michal Soltys wrote:
> > http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=3fdbff332a6ef88a2447584c47a8616dceb19548 
> > (kbd doesn't compile as-is in this commit)
> 
> I think problem in this commit.

http://git.altlinux.org/people/legion/packages/kbd.git?p=kbd.git;a=commit;h=64dfc1442011b3d9d892fd20476efa46fcaa992f

Can you test this fix ?

P.S. I will also appreciate the wider testing of all concerned.

-- 
Rgrds, legion



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [kbd] unicode option for not working correctly since commit: bad17ea03
  2016-10-19 19:36   ` Alexey Gladkov
@ 2016-10-19 21:36     ` Michal Soltys
  2016-10-31 15:28     ` Michal Soltys
  1 sibling, 0 replies; 10+ messages in thread
From: Michal Soltys @ 2016-10-19 21:36 UTC (permalink / raw)
  To: Alexey Gladkov; +Cc: Linux console tools development discussion

On 2016-10-19 21:36, Alexey Gladkov wrote:
> On Wed, Sep 21, 2016 at 11:53:37AM +0200, Alexey Gladkov wrote:
>> On Thu, Jun 16, 2016 at 03:06:43AM +0200, Michal Soltys wrote:
>> > http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=3fdbff332a6ef88a2447584c47a8616dceb19548 
>> > (kbd doesn't compile as-is in this commit)
>> 
>> I think problem in this commit.
> 
> http://git.altlinux.org/people/legion/packages/kbd.git?p=kbd.git;a=commit;h=64dfc1442011b3d9d892fd20476efa46fcaa992f
> 
> Can you test this fix ?

Of course will do.

> 
> P.S. I will also appreciate the wider testing of all concerned.
> 



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [kbd] unicode option for not working correctly since commit: bad17ea03
  2016-10-19 19:36   ` Alexey Gladkov
  2016-10-19 21:36     ` Michal Soltys
@ 2016-10-31 15:28     ` Michal Soltys
  1 sibling, 0 replies; 10+ messages in thread
From: Michal Soltys @ 2016-10-31 15:28 UTC (permalink / raw)
  To: Alexey Gladkov, Linux console tools development discussion

On 2016-10-19 21:36, Alexey Gladkov wrote:
> On Wed, Sep 21, 2016 at 11:53:37AM +0200, Alexey Gladkov wrote:
>> On Thu, Jun 16, 2016 at 03:06:43AM +0200, Michal Soltys wrote:
>> > http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=3fdbff332a6ef88a2447584c47a8616dceb19548 
>> > (kbd doesn't compile as-is in this commit)
>> 
>> I think problem in this commit.
> 
> http://git.altlinux.org/people/legion/packages/kbd.git?p=kbd.git;a=commit;h=64dfc1442011b3d9d892fd20476efa46fcaa992f
> 
> Can you test this fix ?
> 

Fix seems to be working fine. At least no issues with any of the pl keymaps.



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2016-10-31 15:28 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-16  1:06 [kbd] unicode option for not working correctly since commit: bad17ea03 Michal Soltys
2016-09-06 19:26 ` Alexey Gladkov
2016-09-19 20:10   ` Michal Soltys
2016-09-19 23:58     ` Felix Janda
2016-09-20 18:13       ` Michal Soltys
2016-09-20 19:33         ` Felix Janda
2016-09-21  9:53 ` Alexey Gladkov
2016-10-19 19:36   ` Alexey Gladkov
2016-10-19 21:36     ` Michal Soltys
2016-10-31 15:28     ` Michal Soltys

Linux console tools development discussion

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
		kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
	public-inbox-index kbd

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.kbd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git