From: "Dmitry V. Levin" <ldv@altlinux.org>
To: devel@lists.altlinux.org
Subject: Re: [devel] I: brp-verify-unit: "bad permissions on ..."
Date: Sat, 10 Feb 2024 12:12:53 +0200
Message-ID: <20240210101253.GA11939@altlinux.org> (raw)
In-Reply-To: <ZcdIDkqFam9JFxH_@cello>
On Sat, Feb 10, 2024 at 12:55:26PM +0300, Arseny Maslennikov wrote:
> Hi!
>
> В опубликованный сегодня Sisyphus вошёл новый rpm-build:
[...]
> > - Introduced brp-verify-unit to check sanity of systemd units included
> > in built packages.
>
> Новый brp-модуль проверяет юниты systemd на вшивость. Пока он содержит
> две проверки:
> * на файле с systemd-юнитом не должно быть x-бита;
Проверять права доступа на упакованные файлы лучше в sisyphus_check.
На мой взгляд, brp-скриптам лучше бы сразу исправлять эту ошибку,
по аналогии с тем, как уже более 20 лет делают scripts/brp-fix-perms
и scripts/fixup-libraries.
Вот цитата из лога сборки пакета, в которой это хорошо видно:
+ /usr/lib/rpm/brp-alt
Cleaning files in /usr/src/tmp/cpufreqd-buildroot (auto)
mode of './usr/lib64/cpufreqd/cpufreqd_tau.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_governor_parameters.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_exec.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_sensors.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_pmu.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_apm.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_nforce2.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_acpi.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_cpu.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_programs.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
Verifying and fixing files in /usr/src/tmp/cpufreqd-buildroot (binconfig,pkgconfig,libtool,desktop,gnuconfig)
Checking contents of files in /usr/src/tmp/cpufreqd-buildroot/ (default)
Compressing files in /usr/src/tmp/cpufreqd-buildroot (auto)
Verifying systemd units in /usr/src/tmp/cpufreqd-buildroot
044-verify-unit.brp: bad permissions on "/lib/systemd/system/cpufreqd.service": -rwxr-xr-x
--
ldv
next prev parent reply other threads:[~2024-02-10 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 9:55 Arseny Maslennikov
2024-02-10 10:01 ` Anton Farygin
2024-02-10 10:22 ` Arseny Maslennikov
2024-02-10 10:12 ` Dmitry V. Levin [this message]
2024-02-10 10:36 ` Arseny Maslennikov
2024-02-10 10:47 ` Dmitry V. Levin
2024-02-10 10:42 ` Arseny Maslennikov
2024-02-10 10:49 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240210101253.GA11939@altlinux.org \
--to=ldv@altlinux.org \
--cc=devel@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git