From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ldv@altlinux.org>
Date: Sat, 10 Feb 2024 12:12:53 +0200
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: devel@lists.altlinux.org
Message-ID: <20240210101253.GA11939@altlinux.org>
References: <ZcdIDkqFam9JFxH_@cello>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZcdIDkqFam9JFxH_@cello>
Subject: Re: [devel] I: brp-verify-unit: "bad permissions on ..."
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Feb 2024 10:12:54 -0000
Archived-At: <http://lore.altlinux.org/devel/20240210101253.GA11939@altlinux.org/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

On Sat, Feb 10, 2024 at 12:55:26PM +0300, Arseny Maslennikov wrote:
> Hi!
> 
> В опубликованный сегодня Sisyphus вошёл новый rpm-build:
[...]
> > - Introduced brp-verify-unit to check sanity of systemd units included
> >   in built packages.
> 
> Новый brp-модуль проверяет юниты systemd на вшивость. Пока он содержит
> две проверки:
> * на файле с systemd-юнитом не должно быть x-бита;

Проверять права доступа на упакованные файлы лучше в sisyphus_check.

На мой взгляд, brp-скриптам лучше бы сразу исправлять эту ошибку,
по аналогии с тем, как уже более 20 лет делают scripts/brp-fix-perms
и scripts/fixup-libraries.

Вот цитата из лога сборки пакета, в которой это хорошо видно:
+ /usr/lib/rpm/brp-alt
Cleaning files in /usr/src/tmp/cpufreqd-buildroot (auto)
mode of './usr/lib64/cpufreqd/cpufreqd_tau.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_governor_parameters.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_exec.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_sensors.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_pmu.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_apm.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_nforce2.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_acpi.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_cpu.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
mode of './usr/lib64/cpufreqd/cpufreqd_programs.so' changed from 0755 (rwxr-xr-x) to 0644 (rw-r--r--)
Verifying and fixing files in /usr/src/tmp/cpufreqd-buildroot (binconfig,pkgconfig,libtool,desktop,gnuconfig)
Checking contents of files in /usr/src/tmp/cpufreqd-buildroot/ (default)
Compressing files in /usr/src/tmp/cpufreqd-buildroot (auto)
Verifying systemd units in /usr/src/tmp/cpufreqd-buildroot
044-verify-unit.brp: bad permissions on "/lib/systemd/system/cpufreqd.service": -rwxr-xr-x


-- 
ldv