Re: [devel] [SCM] packages/mkve: heads/sisyphus

Re: [devel] [SCM] packages/mkve: heads/sisyphus

[Dmitry V. Levin]

[-- Attachment #1: Type: text/plain, Size: 2046 bytes --]

On Wed, Oct 23, 2019 at 08:03:30AM +0000, Andrey Bychkov wrote:
> Update of /people/mrdrew/packages/mkve.git
> 
> Changes statistics since `0.22-alt1' follows:
>  mkve.spec | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> Changelog since `0.22-alt1' follows:
> commit 9e218d0ae48fecfa74b9809cd629cae6e6fe366d
> Author: Andrey Bychkov <mrdrew@altlinux.org>
> Date:   Wed Oct 23 10:52:20 2019 +0300
> 
>     0.22-alt2
>     
>     - python2 -> python3
> 
> Full diff since `0.22-alt1' follows:
> diff --git a/mkve.spec b/mkve.spec
> index 9f3e33d..abbf6ab 100644
> --- a/mkve.spec
> +++ b/mkve.spec
> @@ -1,6 +1,6 @@
>  Name: mkve
>  Version: 0.22
> -Release: alt1
> +Release: alt2
>  Source: %name-%version.tar
>  
>  Summary: Package for initial managing of virtual environments
> @@ -11,6 +11,11 @@ Requires: su
>  Requires: mkve-cache
>  Conflicts: ve-build-scripts
>  
> +BuildRequires: python-tools-2to3
> +Requires: python3-module-libvirt
> +Requires: python3-module-lxml

Зачем вы добавляете Requires вручную?
Если они нужны, то почему они не добавляются автоматически?

Вообще, поскольку это наш проект, использовать в нём 2to3 противоестественно.

> +
> +
>  %description
>  Package for managing virtual environments, creating caches for such
>  environments.
> @@ -27,6 +32,11 @@ A tool to create caches for virtual environments.
>  %prep
>  %setup
>  
> +find -type f \( -name "%name" -o -name "%name-config" \) -exec 2to3 -w '{}' +
> +
> +sed -i 's|#! /usr/bin/env python|#! /usr/bin/env python3|' \
> +        $(find ./ \( -name "%name" -o -name "%name-config" \))
> +
>  %install
>  %makeinstall
>  
> @@ -43,6 +53,9 @@ A tool to create caches for virtual environments.
>  %_man1dir/mkve-cache*
>  
>  %changelog
> +* Wed Oct 23 2019 Andrey Bychkov <mrdrew@altlinux> 0.22-alt2
> +- python2 -> python3
> +
>  * Wed Aug 28 2019 Dmitry V. Levin <ldv@altlinux> 0.22-alt1
>  - mkve-cache:
>    + updated for hsh-fakedev removal;

-- 
ldv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]