From: Mikhail Novosyolov <mikhailnov@altlinux.org>
To: Alexey Gladkov <legion@altlinux.ru>
Cc: devel@lists.altlinux.org
Subject: Re: [devel] [PATCH hasher-priv v1 2/3] Add systemd and sysvinit service files
Date: Thu, 18 Jun 2020 01:53:36 +0300
Message-ID: <05ba22f1-38b1-4189-8b48-317f3d999ef6@rosalinux.ru> (raw)
In-Reply-To: <20200617224350.bjy2ga6eynonjrrf@comp-core-i7-2640m-0182e6>
18.06.2020 01:43, Alexey Gladkov пишет:
> On Thu, Jun 18, 2020 at 01:31:38AM +0300, Mikhail Novosyolov wrote:
>> 13.12.2019 14:42, Alex Gladkov пишет:
>>> From: Alexey Gladkov <legion@altlinux.org>
>>>
>>> Signed-off-by: Alexey Gladkov <legion@altlinux.org>
>>> ---
>>> hasher-priv/Makefile | 4 ++
>>> hasher-priv/hasher-privd.service | 11 ++++
>>> hasher-priv/hasher-privd.sysvinit | 86 +++++++++++++++++++++++++++++++
>>> 3 files changed, 101 insertions(+)
>>> create mode 100644 hasher-priv/hasher-privd.service
>>> create mode 100755 hasher-priv/hasher-privd.sysvinit
>>>
>>> diff --git a/hasher-priv/Makefile b/hasher-priv/Makefile
>>> index 82aa385..c73216f 100644
>>> --- a/hasher-priv/Makefile
>>> +++ b/hasher-priv/Makefile
>>> @@ -14,6 +14,8 @@ MAN8PAGES = $(PROJECT).8 hasher-useradd.8
>>> TARGETS = $(PROJECT) hasher-privd hasher-useradd $(HELPERS) $(MAN5PAGES) $(MAN8PAGES)
>>>
>>> sysconfdir = /etc
>>> +initdir=$(sysconfdir)/rc.d/init.d
>>> +systemd_unitdir=/lib/systemd/system
>>> libexecdir = /usr/lib
>>> sbindir = /usr/sbin
>>> mandir = /usr/share/man
>>> @@ -72,6 +74,8 @@ install: all
>>> $(MKDIR_P) -m750 $(DESTDIR)$(helperdir)
>>> $(INSTALL) -p -m700 $(PROJECT) $(DESTDIR)$(helperdir)/
>>> $(INSTALL) -p -m755 $(HELPERS) $(DESTDIR)$(helperdir)/
>>> + $(MKDIR_P) -m755 $(DESTDIR)$(initdir)
>>> + $(INSTALL) -p -m755 hasher-privd.sysvinit $(DESTDIR)$(initdir)/hasher-privd
>>> $(MKDIR_P) -m755 $(DESTDIR)$(sbindir)
>>> $(INSTALL) -p -m755 hasher-privd $(DESTDIR)$(sbindir)/
>>> $(INSTALL) -p -m755 hasher-useradd $(DESTDIR)$(sbindir)/
>>> diff --git a/hasher-priv/hasher-privd.service b/hasher-priv/hasher-privd.service
>>> new file mode 100644
>>> index 0000000..e5ed9ac
>>> --- /dev/null
>>> +++ b/hasher-priv/hasher-privd.service
>>> @@ -0,0 +1,11 @@
>>> +[Unit]
>>> +Description=A privileged helper for the hasher project
>>> +ConditionVirtualization=!container
>> А если контейнеру выданы нужные привелегии/capabilities, то почему нельзя? Может, лучше ConditionCapability=?
> Я не специалист в systemd. Я не смогу написать ConditionCapability
> правильно. Я брал за основу какой-то другой сервис. Если вы считаете, что
> это критично, то могу убрать этот сервис вообще.
Критичным не считаю, я вообще не очень в курсе, как работает хешер, мимо проходил, но эту строку бы убрал из сервиса systemd.
next prev parent reply other threads:[~2020-06-17 22:53 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 11:42 [devel] [PATCH hasher-priv v1 0/3] Make a daemon from the hasher-priv Alex Gladkov
2019-12-13 11:42 ` [devel] [PATCH hasher-priv v1 1/3] " Alex Gladkov
2020-09-17 13:10 ` Arseny Maslennikov
2020-10-01 19:43 ` Alexey Gladkov
2020-10-01 21:24 ` Arseny Maslennikov
2020-10-01 23:38 ` Alexey Gladkov
2020-09-17 13:10 ` [devel] [PATCH hasher-priv v1 1/3] *literacy* Arseny Maslennikov
2020-09-17 13:11 ` [devel] [PATCH hasher-priv v1 1/3] caller.c Arseny Maslennikov
2020-09-17 13:55 ` Arseny Maslennikov
2020-09-17 13:11 ` [devel] [PATCH hasher-priv v1 1/3] caller_server.c, caller_task.c Arseny Maslennikov
2020-10-01 19:47 ` Alexey Gladkov
2020-09-17 13:11 ` [devel] [PATCH hasher-priv v1 1/3] config.c Arseny Maslennikov
2020-09-18 10:42 ` Dmitry V. Levin
2020-09-17 13:12 ` [devel] [PATCH hasher-priv v1 1/3] hasher-privd.c Arseny Maslennikov
2020-09-17 13:12 ` [devel] [PATCH hasher-priv v1 1/3] logging.c Arseny Maslennikov
2020-09-17 13:12 ` [devel] [PATCH hasher-priv v1 1/3] Makefile Arseny Maslennikov
2020-09-17 15:09 ` Vladimir D. Seleznev
2020-09-18 10:48 ` Dmitry V. Levin
2020-09-18 10:54 ` Andrey Savchenko
2020-09-18 11:33 ` Dmitry V. Levin
2020-09-18 12:24 ` Arseny Maslennikov
2020-09-17 13:12 ` [devel] [PATCH hasher-priv v1 1/3] server.conf Arseny Maslennikov
2020-09-18 10:50 ` Dmitry V. Levin
2020-09-18 10:57 ` Arseny Maslennikov
2019-12-13 11:42 ` [devel] [PATCH hasher-priv v1 2/3] Add systemd and sysvinit service files Alex Gladkov
2020-06-17 22:31 ` Mikhail Novosyolov
2020-06-17 22:38 ` Mikhail Novosyolov
2020-06-17 22:50 ` Alexey Gladkov
2020-06-17 22:43 ` Alexey Gladkov
2020-06-17 22:53 ` Mikhail Novosyolov [this message]
2020-09-17 13:10 ` Arseny Maslennikov
2020-10-01 17:25 ` Alexey Gladkov
2020-10-01 17:50 ` Arseny Maslennikov
2019-12-13 11:42 ` [devel] [PATCH hasher-priv v1 3/3] Add cgroup support Alex Gladkov
2020-09-17 13:11 ` Arseny Maslennikov
2020-10-01 19:17 ` Alexey Gladkov
2020-10-01 20:23 ` Arseny Maslennikov
2020-10-02 0:42 ` Alexey Gladkov
2020-10-02 11:46 ` Arseny Maslennikov
2020-10-02 12:58 ` Alexey Gladkov
2019-12-15 8:50 ` [devel] [PATCH hasher-priv v1 0/3] Make a daemon from the hasher-priv Alexey Tourbin
2019-12-15 23:33 ` Andrey Savchenko
2019-12-16 9:35 ` Dmitry V. Levin
2019-12-29 11:03 ` Alexey Tourbin
2020-03-16 10:34 ` Alexey Gladkov
2020-06-17 22:01 ` Alexey Gladkov
2020-09-17 13:09 ` Arseny Maslennikov
2020-10-01 17:21 ` Alexey Gladkov
2020-10-01 17:44 ` Arseny Maslennikov
2020-10-01 20:01 ` Alexey Gladkov
2020-10-01 21:53 ` Arseny Maslennikov
2020-10-01 23:55 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05ba22f1-38b1-4189-8b48-317f3d999ef6@rosalinux.ru \
--to=mikhailnov@altlinux.org \
--cc=devel@lists.altlinux.org \
--cc=legion@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git