From: "Ivan A. Melnikov" <iv@altlinux.org>
To: Daniil Gnusarev <gnusarevda@basealt.ru>
Cc: devel-kernel@lists.altlinux.org
Subject: [d-kernel] Патчи на dts(i) и изменения в DT Bindings // was: Re: [PATCH 2/7] arm64: dts: rockchip: Add SPDIF nodes to RK3588(s) device trees
Date: Tue, 18 Aug 2026 14:56:27 +0400
Message-ID: <aoQ45bNwu8ly1a2q@iv-work> (raw)
In-Reply-To: <20260211084122.353558-3-gnusarevda@basealt.ru>
On Wed, Feb 11, 2026 at 12:41:14PM +0400, Daniil Gnusarev wrote:
> From: Alexey Charkov <alchark@gmail.com>
>
> RK3588s has four SPDIF transmitters, and the full RK3588 has six.
> They are software compatible to RK3568 ones. Add respective nodes
> to .dtsi files.
>
> Adapted from vendor sources at [1] and [2], respectively
>
> [1] https://github.com/rockchip-linux/kernel/blob/develop-5.10/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> [2] https://github.com/rockchip-linux/kernel/blob/develop-5.10/arch/arm64/boot/dts/rockchip/rk3588.dtsi
Как будто бы вместе с этим патчем надо брать изменения на binding'и[1],
иначе в dtbs_check появляются новые ошибки:
arch/arm64/boot/dts/edelweiss/rk3588-thin_88rk-1a-001.dtb: spdif-tx@fddb0000 (rockchip,rk3588-spdif): compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif'] is too long
'rockchip,rk3066-spdif' was expected
'rockchip,rk3228-spdif' was expected
'rockchip,rk3328-spdif' was expected
'rockchip,rk3366-spdif' was expected
'rockchip,rk3368-spdif' was expected
'rockchip,rk3399-spdif' was expected
'rockchip,rk3568-spdif' was expected
'rockchip,rk3588-spdif' is not one of ['rockchip,rk3128-spdif', 'rockchip,rk3188-spdif', 'rockchip,rk3288-spdif', 'rockchip,rk3308-spdif']
from schema $id: http://devicetree.org/schemas/sound/rockchip-spdif.yaml
Однако я вижу, что по традиции при бекпортировании патчей на dts(i) такого
не происходило, и это кажется достаточно разумным, так как изменения
в bindings могут приводить к конфликтам при merge (как и любые изменения),
а на функциональность они не влияют.
Если по этому поводу другие мнения?
--
wbr,
iv m.
next prev parent reply other threads:[~2026-08-18 10:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 8:41 [d-kernel] [PATCH 0/7] Enable HDMI1 output on RK3588, kernels 6.12 Daniil Gnusarev
2026-02-11 8:41 ` [d-kernel] [PATCH 1/7] drm/rockchip: dw_hdmi_qp: Add support for RK3588 HDMI1 output Daniil Gnusarev
2026-02-11 8:41 ` [d-kernel] [PATCH 2/7] arm64: dts: rockchip: Add SPDIF nodes to RK3588(s) device trees Daniil Gnusarev
2026-08-18 10:56 ` Ivan A. Melnikov [this message]
2026-02-11 8:41 ` [d-kernel] [PATCH 3/7] arm64: dts: rockchip: Add PHY node for HDMI1 TX port on RK3588 Daniil Gnusarev
2026-02-11 8:41 ` [d-kernel] [PATCH 4/7] arm64: dts: rockchip: Add HDMI1 node " Daniil Gnusarev
2026-02-11 8:41 ` [d-kernel] [PATCH 5/7] arm64: dts: rockchip: Enable HDMI1 PHY clk provider " Daniil Gnusarev
2026-02-11 8:41 ` [d-kernel] [PATCH 6/7] drm/rockchip: vop2: Improve display modes handling on RK3588 HDMI1 Daniil Gnusarev
2026-02-11 8:41 ` [d-kernel] [PATCH 7/7] arm64: dts: rk3588-thin_88rk-1a: enable second hdmi output Daniil Gnusarev
2026-08-18 10:57 ` Ivan A. Melnikov
2026-08-18 11:17 ` Ivan A. Melnikov
2026-08-17 16:35 ` [d-kernel] [PATCH 0/7] Enable HDMI1 output on RK3588, kernels 6.12 Anton Midyukov
2026-08-18 11:14 ` Ivan A. Melnikov
2026-08-19 11:21 ` Ivan A. Melnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoQ45bNwu8ly1a2q@iv-work \
--to=iv@altlinux.org \
--cc=devel-kernel@lists.altlinux.org \
--cc=gnusarevda@basealt.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux kernel packages development
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel-kernel/0 devel-kernel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel-kernel devel-kernel/ http://lore.altlinux.org/devel-kernel \
devel-kernel@altlinux.org devel-kernel@altlinux.ru devel-kernel@altlinux.com
public-inbox-index devel-kernel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel-kernel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git