From: Daniil Gnusarev <gnusarevda@basealt.ru>
To: gnusarevda@basealt.ru, devel-kernel@lists.altlinux.org
Subject: [d-kernel] [PATCH 5/5] pci: baikal-pcie: forced enable dma-coherent for pcie on Baikal-M
Date: Fri, 24 Apr 2026 18:33:26 +0400
Message-ID: <20260424143329.427971-6-gnusarevda@basealt.ru> (raw)
In-Reply-To: <20260424143329.427971-1-gnusarevda@basealt.ru>
When using the CONFIG_INIT_ON_ALLOC_DEFAULT_ON=Y kernel option or
the init_on_alloc=1 boot parameter, errors are observed when initializing
nvme on the PCIe bus:
[ 71.480815] nvme nvme0: I/O tag 16 (0010) QID 0 timeout, disable controller
[ 71.489912] nvme nvme0: Device not ready; aborting shutdown, CSTS=0x1
[ 71.496838] nvme nvme0: Identify Controller failed (-4)
[ 71.502910] nvme 0000:01:00.0: probe with driver nvme failed with error -5
As a solution, Baikal Electronics proposed to add the 'dma-coherent'
property to the PCIe device description in dts. To support devices with
older firmware versions, this property is forced into the device driver.
Signed-off-by: Daniil Gnusarev <gnusarevda@basealt.ru>
Do-not-upstream: this is a feature of Baikal-M
---
drivers/pci/controller/dwc/pcie-baikal-core.c | 36 ++++++++++++++-----
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-baikal-core.c b/drivers/pci/controller/dwc/pcie-baikal-core.c
index 7f597b8a17f94..6300957b39007 100644
--- a/drivers/pci/controller/dwc/pcie-baikal-core.c
+++ b/drivers/pci/controller/dwc/pcie-baikal-core.c
@@ -162,6 +162,14 @@ struct bm1000_pcie {
bool retrained;
};
+static const struct regmap_config bm1000_pcie_syscon_regmap_config = {
+ .reg_bits = 32,
+ .val_bits = 32,
+ .reg_stride = 4,
+ .fast_io = true,
+ .use_raw_spinlock = true,
+};
+
void bm1000_pcie_phy_enable(struct dw_pcie *pci)
{
struct bm1000_pcie *bm = dev_get_drvdata(pci->dev);
@@ -1135,14 +1143,6 @@ static int bm1000_pcie_get_irq_acpi(struct device *dev,
static struct regmap *bm1000_regmap;
-static const struct regmap_config bm1000_pcie_syscon_regmap_config = {
- .reg_bits = 32,
- .val_bits = 32,
- .reg_stride = 4,
- .fast_io = true,
- .use_raw_spinlock = true,
-};
-
static struct regmap *bm1000_pcie_get_gpr_acpi(struct bm1000_pcie *bm)
{
struct device *dev;
@@ -2250,11 +2250,31 @@ static int baikal_pcie_probe(struct platform_device *pdev)
union baikal_pcie *bp;
const struct baikal_pcie_of_data *data;
int ret;
+ struct of_changeset ocs;
data = of_device_get_match_data(dev);
if (!data)
return -EINVAL;
+ if (!of_property_present(dev->of_node, "dma-coherent") &&
+ !of_property_present(dev->of_node, "dma-noncoherent")) {
+ dev->dma_coherent = true;
+
+ of_changeset_init(&ocs);
+
+ ret = of_changeset_add_prop_bool(&ocs, dev->of_node, "dma-coherent");
+ if (ret) {
+ dev_err(dev, "failed to append dma-coherent property\n");
+ return ret;
+ }
+
+ ret = of_changeset_apply(&ocs);
+ if (ret) {
+ dev_err(dev, "failed to append dma-coherent property\n");
+ return ret;
+ }
+ }
+
bp = devm_kzalloc(dev, sizeof(*bp), GFP_KERNEL);
if (!bp)
return -ENOMEM;
--
2.42.2
next prev parent reply other threads:[~2026-04-24 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 14:33 [d-kernel] [PATCH 0/5] Kernel 6.18 with support for the Baikal-M SoC Daniil Gnusarev
2026-04-24 14:33 ` [d-kernel] [PATCH 1/5] pci: baikal-pcie: add support for PCIe controller for Baikal BE-M1000 Daniil Gnusarev
2026-04-24 14:33 ` [d-kernel] [PATCH 2/5] pci: baikal-pcie: driver compatibility with SDK earlier than 5.7 Daniil Gnusarev
2026-04-24 14:33 ` [d-kernel] [PATCH 3/5] pci: baikal-pcie: driver compatibility with SDK versions 5.4 Daniil Gnusarev
2026-04-24 14:33 ` [d-kernel] [PATCH 4/5] pci: baikal-pcie: use raw_spinlock for regmap of gbr registers Daniil Gnusarev
2026-04-24 14:33 ` Daniil Gnusarev [this message]
2026-04-26 6:06 ` [d-kernel] [PATCH 0/5] Kernel 6.18 with support for the Baikal-M SoC Vitaly Chikunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424143329.427971-6-gnusarevda@basealt.ru \
--to=gnusarevda@basealt.ru \
--cc=devel-kernel@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux kernel packages development
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel-kernel/0 devel-kernel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel-kernel devel-kernel/ http://lore.altlinux.org/devel-kernel \
devel-kernel@altlinux.org devel-kernel@altlinux.ru devel-kernel@altlinux.com
public-inbox-index devel-kernel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel-kernel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git