ALT Linux kernel packages development
 help / color / mirror / Atom feed
* [d-kernel] [PATCH 0/1] Fix sudden sound disappearance in kernels after 5.10.156
@ 2022-12-29  6:37 nickel
  2022-12-29  6:37 ` [d-kernel] [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" nickel
  0 siblings, 1 reply; 3+ messages in thread
From: nickel @ 2022-12-29  6:37 UTC (permalink / raw)
  To: devel-kernel

[PATCH 1/1] Revert "ASoC: soc-pcm: Don't zero TDM masks in



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [d-kernel] [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()"
  2022-12-29  6:37 [d-kernel] [PATCH 0/1] Fix sudden sound disappearance in kernels after 5.10.156 nickel
@ 2022-12-29  6:37 ` nickel
  2022-12-29 14:44   ` Vitaly Chikunov
  0 siblings, 1 reply; 3+ messages in thread
From: nickel @ 2022-12-29  6:37 UTC (permalink / raw)
  To: devel-kernel; +Cc: Oleg Obidin

From: Nikolai Kostrigin <nickel@altlinux.org>

This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee.

Sudden sound disappearance was reported for some laptops, e.g.
Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz

lspci
0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
        Subsystem: Acer Incorporated [ALI] Device 148c
        Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
        Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
        Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
        Capabilities: [50] Power Management version 3
        Capabilities: [80] Vendor Specific Information: Len=14 <?>
        Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Kernel driver in use: sof-audio-pci

Bisection revealed the commit being reverted.

Reported-by: Oleg Obidin <obidinog@basealt.ru>
Link: https://bugzilla.altlinux.org/44690
Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org>
---
 sound/soc/soc-pcm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 0e2261ee07b67..8b8a9aca2912f 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -723,6 +723,11 @@ static int soc_pcm_open(struct snd_pcm_substream *substream)
 		ret = snd_soc_dai_startup(dai, substream);
 		if (ret < 0)
 			goto err;
+
+		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+			dai->tx_mask = 0;
+		else
+			dai->rx_mask = 0;
 	}
 
 	/* Dynamic PCM DAI links compat checks use dynamic capabilities */
-- 
2.33.5



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [d-kernel] [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()"
  2022-12-29  6:37 ` [d-kernel] [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" nickel
@ 2022-12-29 14:44   ` Vitaly Chikunov
  0 siblings, 0 replies; 3+ messages in thread
From: Vitaly Chikunov @ 2022-12-29 14:44 UTC (permalink / raw)
  To: ALT Linux kernel packages development; +Cc: Oleg Obidin

On Thu, Dec 29, 2022 at 09:37:35AM +0300, nickel@altlinux.org wrote:
> From: Nikolai Kostrigin <nickel@altlinux.org>
> 
> This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee.
> 
> Sudden sound disappearance was reported for some laptops, e.g.
> Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> 
> lspci
> 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
>         Subsystem: Acer Incorporated [ALI] Device 148c
>         Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
>         Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
>         Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
>         Capabilities: [50] Power Management version 3
>         Capabilities: [80] Vendor Specific Information: Len=14 <?>
>         Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
>         Kernel driver in use: sof-audio-pci
> 
> Bisection revealed the commit being reverted.
> 
> Reported-by: Oleg Obidin <obidinog@basealt.ru>
> Link: https://bugzilla.altlinux.org/44690
> Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org>

Applied, thanks!

> ---
>  sound/soc/soc-pcm.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index 0e2261ee07b67..8b8a9aca2912f 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -723,6 +723,11 @@ static int soc_pcm_open(struct snd_pcm_substream *substream)
>  		ret = snd_soc_dai_startup(dai, substream);
>  		if (ret < 0)
>  			goto err;
> +
> +		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> +			dai->tx_mask = 0;
> +		else
> +			dai->rx_mask = 0;
>  	}
>  
>  	/* Dynamic PCM DAI links compat checks use dynamic capabilities */
> -- 
> 2.33.5
> 
> _______________________________________________
> devel-kernel mailing list
> devel-kernel@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/devel-kernel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-29 14:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-29  6:37 [d-kernel] [PATCH 0/1] Fix sudden sound disappearance in kernels after 5.10.156 nickel
2022-12-29  6:37 ` [d-kernel] [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" nickel
2022-12-29 14:44   ` Vitaly Chikunov

ALT Linux kernel packages development

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/devel-kernel/0 devel-kernel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 devel-kernel devel-kernel/ http://lore.altlinux.org/devel-kernel \
		devel-kernel@altlinux.org devel-kernel@altlinux.ru devel-kernel@altlinux.com
	public-inbox-index devel-kernel

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.devel-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git