* Re: [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities
@ 2021-10-26 11:12 ` Alexey Gladkov
2021-10-26 11:28 ` Leonid Krivoshein
0 siblings, 1 reply; 7+ messages in thread
From: Alexey Gladkov @ 2021-10-26 11:12 UTC (permalink / raw)
To: make-initrd
On Sun, Oct 24, 2021 at 08:21:28PM +0300, Leonid Krivoshein wrote:
> Adds support for reverse addressing relative to the current step,
> as well as calculating the path to the special device node obtained
> in the previous step.
>
> Signed-off-by: Leonid Krivoshein <klark.devel@gmail.com>
> ---
> features/bootchain-core/README.md | 6 +++
> .../data/bin/bootchain-sh-functions | 37 ++++++++++++++++---
> 2 files changed, 38 insertions(+), 5 deletions(-)
>
> diff --git a/features/bootchain-core/README.md b/features/bootchain-core/README.md
> index 8d341e0..ba66259 100644
> --- a/features/bootchain-core/README.md
> +++ b/features/bootchain-core/README.md
> @@ -49,6 +49,12 @@ us to optimize fill in `initramfs` only which we are need.
>
> - Modularity: loading methods are initially separated from the common
> code and daemon.
> +- Via resolve_target() supports not only forward, but also reverse addressing,
> + relative to the current step. For example, a record like `step-3/dir1/dev`
> + will process the result of `dir1/dev`, made in the third step from the current
> + one. Together with the overload of the chain of steps, direct addressing is safe
> + only when storing the numbers of the completed steps in files, whereas reverse
> + relative addressing it is safe in any case and can often be more convenient.
На мой взгляд очень непонятный синтаксис. step1 и step-1 кажется
одинаковым. Хотя бы current-1
> - Allows you to work with shorter and more familiar paths to special files
> devices thanks to the use of `DEVNAME` along with `dev`.
>
> diff --git a/features/bootchain-core/data/bin/bootchain-sh-functions b/features/bootchain-core/data/bin/bootchain-sh-functions
> index e73fd35..0eebbaf 100644
> --- a/features/bootchain-core/data/bin/bootchain-sh-functions
> +++ b/features/bootchain-core/data/bin/bootchain-sh-functions
> @@ -27,19 +27,46 @@ get_parameter()
> resolve_target()
> {
> local target="$1"
> + local where="${target%%/*}"
> + local n="${#where}"
>
> - case "${target%%/*}" in
> + target="${target:$n}"
> +
> + case "$where" in
> '')
> ;;
> pipe[0-9]|pipe[0-9][0-9]|pipe[0-9][0-9][0-9])
> - target="$mntdir/dst/step${target:4}"
> + [ -d "$mntdir/dst/step${where:4}" ] ||
> + return 0
> + target="$(readlink-e "$mntdir/dst/step${where:4}")${target}"
> + ;;
> + step-[1-9]|step-[1-9][0-9]|step-[1-9][0-9][0-9])
> + case "$destdir" in
> + "$mntdir"/dst/step[0-9]*)
> + n="${destdir##*/}"
> + n="$(( ${n:4} - ${where:5} ))"
> + ;;
> + *)
> + return 0
> + ;;
> + esac
> + [ "$n" -ge 0 ] && [ -d "$mntdir/dst/step$n" ] ||
> + return 0
> + target="$(readlink-e "$mntdir/dst/step$n")${target}"
> ;;
> *)
> if [ -z "${prevdir-}" ]; then
> - message "no previous stop to use"
> - return
> + message "no previous step results to use with $name"
> + return 0
> + fi
> + if [ -z "$target" ] &&
> + [ "$where" = DEVNAME ] &&
> + [ -s "$prevdir"/DEVNAME ]
> + then
> + read -r target <"$prevdir"/DEVNAME ||:
> + else
> + target="$prevdir/${where#/}${target}"
> fi
> - target="$prevdir/${target#/}"
> ;;
> esac
>
> --
> 2.24.1
>
> _______________________________________________
> Make-initrd mailing list
> Make-initrd@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/make-initrd
>
--
Rgrds, legion
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities
2021-10-26 11:12 ` [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities Alexey Gladkov
@ 2021-10-26 11:28 ` Leonid Krivoshein
2021-10-26 13:58 ` Alexey Gladkov
0 siblings, 1 reply; 7+ messages in thread
From: Leonid Krivoshein @ 2021-10-26 11:28 UTC (permalink / raw)
To: make-initrd
26.10.2021 14:12, Alexey Gladkov пишет:
> On Sun, Oct 24, 2021 at 08:21:28PM +0300, Leonid Krivoshein wrote:
>> Adds support for reverse addressing relative to the current step,
>> as well as calculating the path to the special device node obtained
>> in the previous step.
>>
>> Signed-off-by: Leonid Krivoshein <klark.devel@gmail.com>
>> ---
>> features/bootchain-core/README.md | 6 +++
>> .../data/bin/bootchain-sh-functions | 37 ++++++++++++++++---
>> 2 files changed, 38 insertions(+), 5 deletions(-)
>>
>> diff --git a/features/bootchain-core/README.md b/features/bootchain-core/README.md
>> index 8d341e0..ba66259 100644
>> --- a/features/bootchain-core/README.md
>> +++ b/features/bootchain-core/README.md
>> @@ -49,6 +49,12 @@ us to optimize fill in `initramfs` only which we are need.
>>
>> - Modularity: loading methods are initially separated from the common
>> code and daemon.
>> +- Via resolve_target() supports not only forward, but also reverse addressing,
>> + relative to the current step. For example, a record like `step-3/dir1/dev`
>> + will process the result of `dir1/dev`, made in the third step from the current
>> + one. Together with the overload of the chain of steps, direct addressing is safe
>> + only when storing the numbers of the completed steps in files, whereas reverse
>> + relative addressing it is safe in any case and can often be more convenient.
> На мой взгляд очень непонятный синтаксис. step1 и step-1 кажется
> одинаковым. Хотя бы current-1
OK. Давай переделаю так:
step<N> = pipe<N> -- прямая адресация, так первоначально и было.
curr-<N> -- обратная относительная адресация.
Так будет лучше?
>
>> - Allows you to work with shorter and more familiar paths to special files
>> devices thanks to the use of `DEVNAME` along with `dev`.
>>
>> diff --git a/features/bootchain-core/data/bin/bootchain-sh-functions b/features/bootchain-core/data/bin/bootchain-sh-functions
>> index e73fd35..0eebbaf 100644
>> --- a/features/bootchain-core/data/bin/bootchain-sh-functions
>> +++ b/features/bootchain-core/data/bin/bootchain-sh-functions
>> @@ -27,19 +27,46 @@ get_parameter()
>> resolve_target()
>> {
>> local target="$1"
>> + local where="${target%%/*}"
>> + local n="${#where}"
>>
>> - case "${target%%/*}" in
>> + target="${target:$n}"
>> +
>> + case "$where" in
>> '')
>> ;;
>> pipe[0-9]|pipe[0-9][0-9]|pipe[0-9][0-9][0-9])
>> - target="$mntdir/dst/step${target:4}"
>> + [ -d "$mntdir/dst/step${where:4}" ] ||
>> + return 0
>> + target="$(readlink-e "$mntdir/dst/step${where:4}")${target}"
>> + ;;
>> + step-[1-9]|step-[1-9][0-9]|step-[1-9][0-9][0-9])
>> + case "$destdir" in
>> + "$mntdir"/dst/step[0-9]*)
>> + n="${destdir##*/}"
>> + n="$(( ${n:4} - ${where:5} ))"
>> + ;;
>> + *)
>> + return 0
>> + ;;
>> + esac
>> + [ "$n" -ge 0 ] && [ -d "$mntdir/dst/step$n" ] ||
>> + return 0
>> + target="$(readlink-e "$mntdir/dst/step$n")${target}"
>> ;;
>> *)
>> if [ -z "${prevdir-}" ]; then
>> - message "no previous stop to use"
>> - return
>> + message "no previous step results to use with $name"
>> + return 0
>> + fi
>> + if [ -z "$target" ] &&
>> + [ "$where" = DEVNAME ] &&
>> + [ -s "$prevdir"/DEVNAME ]
>> + then
>> + read -r target <"$prevdir"/DEVNAME ||:
>> + else
>> + target="$prevdir/${where#/}${target}"
>> fi
>> - target="$prevdir/${target#/}"
>> ;;
>> esac
>>
>> --
>> 2.24.1
>>
>> _______________________________________________
>> Make-initrd mailing list
>> Make-initrd@lists.altlinux.org
>> https://lists.altlinux.org/mailman/listinfo/make-initrd
>>
--
Best regards,
Leonid Krivoshein.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities
2021-10-26 11:28 ` Leonid Krivoshein
@ 2021-10-26 13:58 ` Alexey Gladkov
2021-10-29 23:50 ` Gleb Fotengauer-Malinovskiy
0 siblings, 1 reply; 7+ messages in thread
From: Alexey Gladkov @ 2021-10-26 13:58 UTC (permalink / raw)
To: make-initrd
On Tue, Oct 26, 2021 at 02:28:53PM +0300, Leonid Krivoshein wrote:
>
>
> 26.10.2021 14:12, Alexey Gladkov пишет:
> > On Sun, Oct 24, 2021 at 08:21:28PM +0300, Leonid Krivoshein wrote:
> > > Adds support for reverse addressing relative to the current step,
> > > as well as calculating the path to the special device node obtained
> > > in the previous step.
> > >
> > > Signed-off-by: Leonid Krivoshein <klark.devel@gmail.com>
> > > ---
> > > features/bootchain-core/README.md | 6 +++
> > > .../data/bin/bootchain-sh-functions | 37 ++++++++++++++++---
> > > 2 files changed, 38 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/features/bootchain-core/README.md b/features/bootchain-core/README.md
> > > index 8d341e0..ba66259 100644
> > > --- a/features/bootchain-core/README.md
> > > +++ b/features/bootchain-core/README.md
> > > @@ -49,6 +49,12 @@ us to optimize fill in `initramfs` only which we are need.
> > > - Modularity: loading methods are initially separated from the common
> > > code and daemon.
> > > +- Via resolve_target() supports not only forward, but also reverse addressing,
> > > + relative to the current step. For example, a record like `step-3/dir1/dev`
> > > + will process the result of `dir1/dev`, made in the third step from the current
> > > + one. Together with the overload of the chain of steps, direct addressing is safe
> > > + only when storing the numbers of the completed steps in files, whereas reverse
> > > + relative addressing it is safe in any case and can often be more convenient.
> > На мой взгляд очень непонятный синтаксис. step1 и step-1 кажется
> > одинаковым. Хотя бы current-1
>
> OK. Давай переделаю так:
>
> step<N> = pipe<N> -- прямая адресация, так первоначально и было.
> curr-<N> -- обратная относительная адресация.
>
> Так будет лучше?
Мне будет понятнее. Но я хотел бы спросить помощи зала.
Глеб, Антон, как вы думаете, как будет понятнее ?
>
> >
> > > - Allows you to work with shorter and more familiar paths to special files
> > > devices thanks to the use of `DEVNAME` along with `dev`.
> > > diff --git a/features/bootchain-core/data/bin/bootchain-sh-functions b/features/bootchain-core/data/bin/bootchain-sh-functions
> > > index e73fd35..0eebbaf 100644
> > > --- a/features/bootchain-core/data/bin/bootchain-sh-functions
> > > +++ b/features/bootchain-core/data/bin/bootchain-sh-functions
> > > @@ -27,19 +27,46 @@ get_parameter()
> > > resolve_target()
> > > {
> > > local target="$1"
> > > + local where="${target%%/*}"
> > > + local n="${#where}"
> > > - case "${target%%/*}" in
> > > + target="${target:$n}"
> > > +
> > > + case "$where" in
> > > '')
> > > ;;
> > > pipe[0-9]|pipe[0-9][0-9]|pipe[0-9][0-9][0-9])
> > > - target="$mntdir/dst/step${target:4}"
> > > + [ -d "$mntdir/dst/step${where:4}" ] ||
> > > + return 0
> > > + target="$(readlink-e "$mntdir/dst/step${where:4}")${target}"
> > > + ;;
> > > + step-[1-9]|step-[1-9][0-9]|step-[1-9][0-9][0-9])
> > > + case "$destdir" in
> > > + "$mntdir"/dst/step[0-9]*)
> > > + n="${destdir##*/}"
> > > + n="$(( ${n:4} - ${where:5} ))"
> > > + ;;
> > > + *)
> > > + return 0
> > > + ;;
> > > + esac
> > > + [ "$n" -ge 0 ] && [ -d "$mntdir/dst/step$n" ] ||
> > > + return 0
> > > + target="$(readlink-e "$mntdir/dst/step$n")${target}"
> > > ;;
> > > *)
> > > if [ -z "${prevdir-}" ]; then
> > > - message "no previous stop to use"
> > > - return
> > > + message "no previous step results to use with $name"
> > > + return 0
> > > + fi
> > > + if [ -z "$target" ] &&
> > > + [ "$where" = DEVNAME ] &&
> > > + [ -s "$prevdir"/DEVNAME ]
> > > + then
> > > + read -r target <"$prevdir"/DEVNAME ||:
> > > + else
> > > + target="$prevdir/${where#/}${target}"
> > > fi
> > > - target="$prevdir/${target#/}"
> > > ;;
> > > esac
> > > --
> > > 2.24.1
> > >
> > > _______________________________________________
> > > Make-initrd mailing list
> > > Make-initrd@lists.altlinux.org
> > > https://lists.altlinux.org/mailman/listinfo/make-initrd
> > >
>
> --
> Best regards,
> Leonid Krivoshein.
>
> _______________________________________________
> Make-initrd mailing list
> Make-initrd@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/make-initrd
--
Rgrds, legion
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities
2021-10-26 13:58 ` Alexey Gladkov
@ 2021-10-29 23:50 ` Gleb Fotengauer-Malinovskiy
2021-10-30 2:13 ` Leonid Krivoshein
0 siblings, 1 reply; 7+ messages in thread
From: Gleb Fotengauer-Malinovskiy @ 2021-10-29 23:50 UTC (permalink / raw)
To: Alexey Gladkov; +Cc: make-initrd
[-- Attachment #1: Type: text/plain, Size: 2686 bytes --]
On Tue, Oct 26, 2021 at 03:58:34PM +0200, Alexey Gladkov wrote:
> On Tue, Oct 26, 2021 at 02:28:53PM +0300, Leonid Krivoshein wrote:
> >
> >
> > 26.10.2021 14:12, Alexey Gladkov пишет:
> > > On Sun, Oct 24, 2021 at 08:21:28PM +0300, Leonid Krivoshein wrote:
> > > > Adds support for reverse addressing relative to the current step,
> > > > as well as calculating the path to the special device node obtained
> > > > in the previous step.
> > > >
> > > > Signed-off-by: Leonid Krivoshein <klark.devel@gmail.com>
> > > > ---
> > > > features/bootchain-core/README.md | 6 +++
> > > > .../data/bin/bootchain-sh-functions | 37 ++++++++++++++++---
> > > > 2 files changed, 38 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/features/bootchain-core/README.md b/features/bootchain-core/README.md
> > > > index 8d341e0..ba66259 100644
> > > > --- a/features/bootchain-core/README.md
> > > > +++ b/features/bootchain-core/README.md
> > > > @@ -49,6 +49,12 @@ us to optimize fill in `initramfs` only which we are need.
> > > > - Modularity: loading methods are initially separated from the common
> > > > code and daemon.
> > > > +- Via resolve_target() supports not only forward, but also reverse addressing,
> > > > + relative to the current step. For example, a record like `step-3/dir1/dev`
> > > > + will process the result of `dir1/dev`, made in the third step from the current
> > > > + one. Together with the overload of the chain of steps, direct addressing is safe
> > > > + only when storing the numbers of the completed steps in files, whereas reverse
> > > > + relative addressing it is safe in any case and can often be more convenient.
> > > На мой взгляд очень непонятный синтаксис. step1 и step-1 кажется
> > > одинаковым. Хотя бы current-1
> >
> > OK. Давай переделаю так:
> >
> > step<N> = pipe<N> -- прямая адресация, так первоначально и было.
> > curr-<N> -- обратная относительная адресация.
> >
> > Так будет лучше?
>
> Мне будет понятнее. Но я хотел бы спросить помощи зала.
>
> Глеб, Антон, как вы думаете, как будет понятнее ?
Если из предложенного выбирать, то curr-<N> однозначно лучше.
Но мне кажется, что тут - не читается как минус. Я бы скорее предложил
что-то вроде prev<N> или back<N>.
--
glebfm
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities
2021-10-29 23:50 ` Gleb Fotengauer-Malinovskiy
@ 2021-10-30 2:13 ` Leonid Krivoshein
2021-11-06 12:47 ` Alexey Gladkov
0 siblings, 1 reply; 7+ messages in thread
From: Leonid Krivoshein @ 2021-10-30 2:13 UTC (permalink / raw)
To: make-initrd
30.10.2021 2:50, Gleb Fotengauer-Malinovskiy пишет:
> On Tue, Oct 26, 2021 at 03:58:34PM +0200, Alexey Gladkov wrote:
>> On Tue, Oct 26, 2021 at 02:28:53PM +0300, Leonid Krivoshein wrote:
>>> 26.10.2021 14:12, Alexey Gladkov пишет:
>>>> On Sun, Oct 24, 2021 at 08:21:28PM +0300, Leonid Krivoshein wrote:
>>>>> Adds support for reverse addressing relative to the current step,
>>>>> as well as calculating the path to the special device node obtained
>>>>> in the previous step.
>>>>>
>>>>> Signed-off-by: Leonid Krivoshein <klark.devel@gmail.com>
>>>>> ---
>>>>> features/bootchain-core/README.md | 6 +++
>>>>> .../data/bin/bootchain-sh-functions | 37 ++++++++++++++++---
>>>>> 2 files changed, 38 insertions(+), 5 deletions(-)
>>>>>
>>>>> diff --git a/features/bootchain-core/README.md b/features/bootchain-core/README.md
>>>>> index 8d341e0..ba66259 100644
>>>>> --- a/features/bootchain-core/README.md
>>>>> +++ b/features/bootchain-core/README.md
>>>>> @@ -49,6 +49,12 @@ us to optimize fill in `initramfs` only which we are need.
>>>>> - Modularity: loading methods are initially separated from the common
>>>>> code and daemon.
>>>>> +- Via resolve_target() supports not only forward, but also reverse addressing,
>>>>> + relative to the current step. For example, a record like `step-3/dir1/dev`
>>>>> + will process the result of `dir1/dev`, made in the third step from the current
>>>>> + one. Together with the overload of the chain of steps, direct addressing is safe
>>>>> + only when storing the numbers of the completed steps in files, whereas reverse
>>>>> + relative addressing it is safe in any case and can often be more convenient.
>>>> На мой взгляд очень непонятный синтаксис. step1 и step-1 кажется
>>>> одинаковым. Хотя бы current-1
>>> OK. Давай переделаю так:
>>>
>>> step<N> = pipe<N> -- прямая адресация, так первоначально и было.
>>> curr-<N> -- обратная относительная адресация.
>>>
>>> Так будет лучше?
>> Мне будет понятнее. Но я хотел бы спросить помощи зала.
>>
>> Глеб, Антон, как вы думаете, как будет понятнее ?
> Если из предложенного выбирать, то curr-<N> однозначно лучше.
>
> Но мне кажется, что тут - не читается как минус. Я бы скорее предложил
> что-то вроде prev<N> или back<N>.
Отлично, тогда переделаю на back<N> !
Как я понял, по остальным моментам Алексей пока взял паузу...
--
Best regards,
Leonid Krivoshein.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities
2021-10-30 2:13 ` Leonid Krivoshein
@ 2021-11-06 12:47 ` Alexey Gladkov
2021-11-06 14:26 ` Leonid Krivoshein
0 siblings, 1 reply; 7+ messages in thread
From: Alexey Gladkov @ 2021-11-06 12:47 UTC (permalink / raw)
To: make-initrd
On Sat, Oct 30, 2021 at 05:13:49AM +0300, Leonid Krivoshein wrote:
>
> 30.10.2021 2:50, Gleb Fotengauer-Malinovskiy пишет:
> > On Tue, Oct 26, 2021 at 03:58:34PM +0200, Alexey Gladkov wrote:
> > > On Tue, Oct 26, 2021 at 02:28:53PM +0300, Leonid Krivoshein wrote:
> > > > 26.10.2021 14:12, Alexey Gladkov пишет:
> > > > > On Sun, Oct 24, 2021 at 08:21:28PM +0300, Leonid Krivoshein wrote:
> > > > > > Adds support for reverse addressing relative to the current step,
> > > > > > as well as calculating the path to the special device node obtained
> > > > > > in the previous step.
> > > > > >
> > > > > > Signed-off-by: Leonid Krivoshein <klark.devel@gmail.com>
> > > > > > ---
> > > > > > features/bootchain-core/README.md | 6 +++
> > > > > > .../data/bin/bootchain-sh-functions | 37 ++++++++++++++++---
> > > > > > 2 files changed, 38 insertions(+), 5 deletions(-)
> > > > > >
> > > > > > diff --git a/features/bootchain-core/README.md b/features/bootchain-core/README.md
> > > > > > index 8d341e0..ba66259 100644
> > > > > > --- a/features/bootchain-core/README.md
> > > > > > +++ b/features/bootchain-core/README.md
> > > > > > @@ -49,6 +49,12 @@ us to optimize fill in `initramfs` only which we are need.
> > > > > > - Modularity: loading methods are initially separated from the common
> > > > > > code and daemon.
> > > > > > +- Via resolve_target() supports not only forward, but also reverse addressing,
> > > > > > + relative to the current step. For example, a record like `step-3/dir1/dev`
> > > > > > + will process the result of `dir1/dev`, made in the third step from the current
> > > > > > + one. Together with the overload of the chain of steps, direct addressing is safe
> > > > > > + only when storing the numbers of the completed steps in files, whereas reverse
> > > > > > + relative addressing it is safe in any case and can often be more convenient.
> > > > > На мой взгляд очень непонятный синтаксис. step1 и step-1 кажется
> > > > > одинаковым. Хотя бы current-1
> > > > OK. Давай переделаю так:
> > > >
> > > > step<N> = pipe<N> -- прямая адресация, так первоначально и было.
> > > > curr-<N> -- обратная относительная адресация.
> > > >
> > > > Так будет лучше?
> > > Мне будет понятнее. Но я хотел бы спросить помощи зала.
> > >
> > > Глеб, Антон, как вы думаете, как будет понятнее ?
> > Если из предложенного выбирать, то curr-<N> однозначно лучше.
> >
> > Но мне кажется, что тут - не читается как минус. Я бы скорее предложил
> > что-то вроде prev<N> или back<N>.
>
> Отлично, тогда переделаю на back<N> !
>
> Как я понял, по остальным моментам Алексей пока взял паузу...
В прошлый раз я вроде всё прокомментировал, что нашёл.
--
Rgrds, legion
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities
2021-11-06 12:47 ` Alexey Gladkov
@ 2021-11-06 14:26 ` Leonid Krivoshein
0 siblings, 0 replies; 7+ messages in thread
From: Leonid Krivoshein @ 2021-11-06 14:26 UTC (permalink / raw)
To: make-initrd
06.11.2021 15:47, Alexey Gladkov пишет:
> On Sat, Oct 30, 2021 at 05:13:49AM +0300, Leonid Krivoshein wrote:
>> 30.10.2021 2:50, Gleb Fotengauer-Malinovskiy пишет:
>>> On Tue, Oct 26, 2021 at 03:58:34PM +0200, Alexey Gladkov wrote:
>>>> On Tue, Oct 26, 2021 at 02:28:53PM +0300, Leonid Krivoshein wrote:
>>>>> 26.10.2021 14:12, Alexey Gladkov пишет:
>>>>>> On Sun, Oct 24, 2021 at 08:21:28PM +0300, Leonid Krivoshein wrote:
>>>>>>> Adds support for reverse addressing relative to the current step,
>>>>>>> as well as calculating the path to the special device node obtained
>>>>>>> in the previous step.
>>>>>>>
>>>>>>> Signed-off-by: Leonid Krivoshein <klark.devel@gmail.com>
>>>>>>> ---
>>>>>>> features/bootchain-core/README.md | 6 +++
>>>>>>> .../data/bin/bootchain-sh-functions | 37 ++++++++++++++++---
>>>>>>> 2 files changed, 38 insertions(+), 5 deletions(-)
>>>>>>>
>>>>>>> diff --git a/features/bootchain-core/README.md b/features/bootchain-core/README.md
>>>>>>> index 8d341e0..ba66259 100644
>>>>>>> --- a/features/bootchain-core/README.md
>>>>>>> +++ b/features/bootchain-core/README.md
>>>>>>> @@ -49,6 +49,12 @@ us to optimize fill in `initramfs` only which we are need.
>>>>>>> - Modularity: loading methods are initially separated from the common
>>>>>>> code and daemon.
>>>>>>> +- Via resolve_target() supports not only forward, but also reverse addressing,
>>>>>>> + relative to the current step. For example, a record like `step-3/dir1/dev`
>>>>>>> + will process the result of `dir1/dev`, made in the third step from the current
>>>>>>> + one. Together with the overload of the chain of steps, direct addressing is safe
>>>>>>> + only when storing the numbers of the completed steps in files, whereas reverse
>>>>>>> + relative addressing it is safe in any case and can often be more convenient.
>>>>>> На мой взгляд очень непонятный синтаксис. step1 и step-1 кажется
>>>>>> одинаковым. Хотя бы current-1
>>>>> OK. Давай переделаю так:
>>>>>
>>>>> step<N> = pipe<N> -- прямая адресация, так первоначально и было.
>>>>> curr-<N> -- обратная относительная адресация.
>>>>>
>>>>> Так будет лучше?
>>>> Мне будет понятнее. Но я хотел бы спросить помощи зала.
>>>>
>>>> Глеб, Антон, как вы думаете, как будет понятнее ?
>>> Если из предложенного выбирать, то curr-<N> однозначно лучше.
>>>
>>> Но мне кажется, что тут - не читается как минус. Я бы скорее предложил
>>> что-то вроде prev<N> или back<N>.
>> Отлично, тогда переделаю на back<N> !
>>
>> Как я понял, по остальным моментам Алексей пока взял паузу...
> В прошлый раз я вроде всё прокомментировал, что нашёл.
Тогда перехожу к финальной итерации? Просто, мне показалось, что
остались какие-то спорные моменты.
--
Best regards,
Leonid Krivoshein.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-11-06 14:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 11:12 ` [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities Alexey Gladkov
2021-10-26 11:28 ` Leonid Krivoshein
2021-10-26 13:58 ` Alexey Gladkov
2021-10-29 23:50 ` Gleb Fotengauer-Malinovskiy
2021-10-30 2:13 ` Leonid Krivoshein
2021-11-06 12:47 ` Alexey Gladkov
2021-11-06 14:26 ` Leonid Krivoshein
Make-initrd development discussion
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/make-initrd/0 make-initrd/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 make-initrd make-initrd/ http://lore.altlinux.org/make-initrd \
make-initrd@lists.altlinux.org make-initrd@lists.altlinux.ru make-initrd@lists.altlinux.com
public-inbox-index make-initrd
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.make-initrd
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git