From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on sa.int.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3 Date: Tue, 29 Apr 2008 04:07:16 +0400 From: Pavlov Konstantin To: smoke-room@lists.altlinux.org Message-ID: <20080429000716.GA20848@cryo.net.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline X-Operating-System: ALT Linux 4.0 Server (Walnut) User-Agent: Mutt/1.5.17 (2007-11-01) Subject: [room] well at first i was like... but then i lol'd. X-BeenThere: smoke-room@lists.altlinux.org X-Mailman-Version: 2.1.10b3 Precedence: list Reply-To: =?koi8-r?b?69XM2NTV0s7ZyiDPxtTP0MnL?= List-Id: =?koi8-r?b?69XM2NTV0s7ZyiDPxtTP0MnL?= List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Apr 2008 00:07:42 -0000 Archived-At: List-Archive: --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable ----- Forwarded message from M=E5ns Rullg=E5rd ----- Date: Tue, 29 Apr 2008 00:57:56 +0100 =46rom: M=E5ns Rullg=E5rd To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] fix issue434 User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.21 (Educational Televisi= on, linux) Michael Niedermayer writes: > On Mon, Apr 28, 2008 at 11:28:23PM +0100, M=E5ns Rullg=E5rd wrote: >> Michael Niedermayer writes: >>=20 >> > On Mon, Apr 21, 2008 at 02:04:08AM +0200, Michael Niedermayer wrote: >> >> On Mon, Apr 21, 2008 at 12:21:07AM +0100, M=E5ns Rullg=E5rd wrote: >> >> > Michael Niedermayer writes: >> >> >=20 >> >> > > Hi >> >> > > >> >> > > The patch below fixes issue434, i will commit it in 24h unless >> >> > > mans objects >> >> > > >> >> > > Index: libavformat/mpeg.c >> >> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> > > --- libavformat/mpeg.c (revision 12867) >> >> > > +++ libavformat/mpeg.c (working copy) >> >> > > @@ -341,12 +341,13 @@ >> >> > > if (flags & 0x01) { /* PES extension */ >> >> > > pes_ext =3D get_byte(s->pb); >> >> > > header_len--; >> >> > > - if (pes_ext & 0x40) { /* pack header - should be zer= o in PS */ >> >> > > - goto error_redo; >> >> > > - } >> >> > > /* Skip PES private data, program packet sequence co= unter and P-STD buffer */ >> >> > > skip =3D (pes_ext >> 4) & 0xb; >> >> > > skip +=3D skip & 0x9; >> >> > > + if (pes_ext & 0x40 || skip > header_len){ >> >> > > + av_log(s, AV_LOG_WARNING, "pes_ext %X is invalid= \n", pes_ext); >> >> > > + pes_ext=3Dskip=3D0; >> >> > > + } >> >> > > url_fskip(s->pb, skip); >> >> > > header_len -=3D skip; >> >> >=20 >> >> > Workarounds for out-of-spec streams are only acceptable if explicit= ly >> >> > requested. Does lavf have something equivalent to lavc's >> >> > AVCodecContext.strict_std_compliance? >> >>=20 >> >> No, also strict_std_compliance is a pure encoder side thing. Used for >> >> preventing users to shoot themselfs in their foot (encoding experment= al >> >> codecs like snow, storing non jpeg YUV in jpeg, ...). >> >>=20 >> >> The variable with a matching purpose is error_resilience (bad name, y= es ...) >> >> It does select between how much spec non compliance should be ignored= and >> >> how much should be considered an error. Thus its a tradeoff between e= arly >> >> detection of errors in damaged streams vs. supporting streams which d= ont >> >> conform to the specs. >> >>=20 >> >> We certainly could add such a variable to AVFormatContext as well. >> > >> > ping >> > What shall be done about this issue? >> > * This does not affect valid files >> > * It does print a big and nasty "blah is invalid" >> > * Its ffmpegs "policy" to support broken files by default >> > >> > I can add a error_resilience variable to AVFormatContext if you want, = but >> > its default would be what has the highest chance to result in correct >> > playaback. >>=20 >> You may apply this if you give me the head of a vdr author on a silver >> plate first. There is no excuse for knowingly creating invalid files. > > No problem > > _||||||_ > / VDR DEV\ > | X X | > O| | |O > | /_ | > ---\ -=3D=3D=3D- /---- > ---- | U | ---- > -=3D=3D |______| =3D=3D- > ---- SILVER PLATE ---- > ------------------ What can I say? Go ahead and commit. --=20 M=E5ns Rullg=E5rd mans.mansr.com _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel ----- End forwarded message ----- --=20 Do your part to help preserve life on Earth -- by trying to preserve your o= wn. --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFIFmaxR0cP4/qrkIQRAoiYAJ9kgSr46EFijx40oj94IfFh1WZptgCgjVnV 32KqDpImFz8DA3tZEhFeTMo= =p5dw -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--