From: Michael Shigorin <mike@osdn.org.ua> To: sisyphus@lists.altlinux.org Subject: [sisyphus] [JT] Fwd: Re: packages: dmenu/dmenu.spec (NEW) - initial Date: Sun, 31 May 2009 20:21:30 +0300 Message-ID: <20090531172130.GV12156@osdn.org.ua> (raw) 1) интересно, чем именно "much more secure" 2) а что за filter-out? в федориных патчах видел, у нас нет ----- Forwarded message from Przemyslaw Iskra <sparky/pld-linux.org> ----- Date: Sun, 31 May 2009 19:04:13 +0200 From: Przemyslaw Iskra <sparky/pld-linux.org> To: pld-devel-en/lists.pld-linux.org Subject: Re: packages: dmenu/dmenu.spec (NEW) - initial On Sun, May 31, 2009 at 06:45:28PM +0200, uzsolt wrote: > Author: uzsolt Date: Sun May 31 16:45:28 2009 GMT > Module: packages Tag: HEAD > ---- Log message: > - initial > +%prep > +%setup -q > +sed -i "s/^PREFIX.*/PREFIX=%{_prefix}/" config.mk > +sed -i "s/^\(CFLAGS.*\)-Os\(.*\)/\1 \2 %{rpmcflags}/" config.mk > +sed -i "s/^\(LDFLAGS.*\)/\1 %{rpmldflags}/" config.mk You shouldn't be defining these at %prep stage, doing so in %build is much more secure. And there must be much a simpler way than using sed to do it. You could pass options in %__make invocation, or append them at the end of config.mk file: %build cat << 'EOF' >> config.mk PREFIX = %{_prefix} CFLAGS := %{rpmcflags} $(filter-out -Os,$(CFLAGS)) LDFLAGS = %{rpmldflags} EOF %{__make} BTW, appropriate sed BR is missing. -- ____ Sparky{PI] -- Przemyslaw _ ___ _ _ ........... LANG...Pl..Ca..Es..En /____) ___ ___ _ _ || Iskra | | _ \| | | : WWW........ppcrcd.pld-linux.org \____\| -_)'___| ||^'||//\\// < | _/| | | : JID......sparky<at>jabberes.org (____/|| (_-_|_|| ||\\ || |_ |_| |_| _| : Mail....sparky<at>pld-linux.org _______________________________________________ pld-devel-en mailing list pld-devel-en/lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en ----- End forwarded message ----- -- ---- WBR, Michael Shigorin <mike@altlinux.ru> ------ Linux.Kiev http://www.linux.kiev.ua/
reply other threads:[~2009-05-31 17:21 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090531172130.GV12156@osdn.org.ua \ --to=mike@osdn.org.ua \ --cc=shigorin@gmail.com \ --cc=sisyphus@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
ALT Linux Sisyphus discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/sisyphus/0 sisyphus/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 sisyphus sisyphus/ http://lore.altlinux.org/sisyphus \ sisyphus@altlinux.ru sisyphus@altlinux.org sisyphus@lists.altlinux.org sisyphus@lists.altlinux.ru sisyphus@lists.altlinux.com sisyphus@linuxteam.iplabs.ru sisyphus@list.linux-os.ru public-inbox-index sisyphus Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.sisyphus AGPL code for this site: git clone https://public-inbox.org/public-inbox.git