From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <klark.devel@gmail.com>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no
 version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1684111625; x=1686703625;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :from:to:cc:subject:date:message-id:reply-to;
 bh=pCUWTwQcgcc4e9F8C6J9edll250qEMzhmW6pfA3SeLY=;
 b=CHb8HyZQs2RSc1EX1SZWpxZFifNHxxb3362vNNBt7dyvUfKBA4Er31QsggLaxOqC7H
 8o5RveUqcgwKgK48x4ExpWC09vb3uRCul/kXbX1gsg/q5yyIJsqczW5dhejs2WoRZDYX
 xb/GaxL6wqkunFLSVXNNZu6G5Jkyz6sFD/qp8xu54I1bCzuLjgng+ezId0A1OlQbNCUh
 nPqbKaEA3o7LIj1iwEFZm2kIlaNPm4yEhPaY4/WDg1rsqTAPXVTZuLMVFgXOmtWtdCRO
 V15PRKogz6Ebk/cM1ypgbxifBKL1rDrUll7lRbE3mJlQ5KjLHzO6YtChsX4s2LYOCW9e
 HYcg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1684111625; x=1686703625;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=pCUWTwQcgcc4e9F8C6J9edll250qEMzhmW6pfA3SeLY=;
 b=j917eYNLACwcbEyarCo/37vNswT+oJjo2MPqW3kOQlyQSxAsTESKGVxWK3/njxba51
 tbuCiPm/hDdgdiDJf0nocjDWxCxqmTpsGqBJoqO2dwV3S0RYDNXYbRSZ3B1tYE5P3NTW
 BGxafRSeeQuTIcLgXl7LSvZ8rpffdQzcIVtJXQyjniRaxYmJqFpkW0z9Oi3VogInEkAP
 on+cNRQsUNiYcrabEGTUuKUT0bgWdon4+na0JPoAfz4mZQxw6pmELDnCq62KLJrv5IvM
 iMI3PaRo/SPBry/FVcPCBfzDVzCgsb21x//NDFPTXLKROfx2lohIwxK5aLDLFDDn99q3
 iwrg==
X-Gm-Message-State: AC+VfDzbu11XNrLsElBeriQc/poYWubGpZSDFDldKKZ5bPG0qRykdQak
 Pz5MsNZa2WdF8BQDqot/oRVw0t2XFCk=
X-Google-Smtp-Source: ACHHUZ7fICDTwAidAF9ABFMO8ZUKMm2L3MMzr4Uzlq+KbmyI+eoCLv98Pez03he1+0kGlxIVToXNDg==
X-Received: by 2002:a05:6808:482:b0:38d:e623:bb1c with SMTP id
 z2-20020a056808048200b0038de623bb1cmr10312348oid.58.1684111624706; 
 Sun, 14 May 2023 17:47:04 -0700 (PDT)
Message-ID: <fcd48eb6-9cef-e608-20fc-3cf226743413@gmail.com>
Date: Mon, 15 May 2023 03:47:03 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Content-Language: ru, en-US
To: make-initrd@lists.altlinux.org
References: <cover.1683200226.git.gladkov.alexey@gmail.com>
 <6b444ed922286eb3df8f5322b1bddf9c55753eb8.1683200226.git.gladkov.alexey@gmail.com>
From: Leonid Krivoshein <klark.devel@gmail.com>
In-Reply-To: <6b444ed922286eb3df8f5322b1bddf9c55753eb8.1683200226.git.gladkov.alexey@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [make-initrd] [PATCH 1/3] Reimplement ueventd
X-BeenThere: make-initrd@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: make-initrd@lists.altlinux.org
List-Id: <make-initrd.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/make-initrd>,
 <mailto:make-initrd-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/make-initrd>
List-Post: <mailto:make-initrd@lists.altlinux.org>
List-Help: <mailto:make-initrd-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/make-initrd>,
 <mailto:make-initrd-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Mon, 15 May 2023 00:47:08 -0000
Archived-At: <http://lore.altlinux.org/make-initrd/fcd48eb6-9cef-e608-20fc-3cf226743413@gmail.com/>
List-Archive: <http://lore.altlinux.org/make-initrd/>


On 5/4/23 16:42, Alexey Gladkov wrote:
> [...]
> diff --git a/datasrc/ueventd/logging.c b/datasrc/ueventd/logging.c
> new file mode 100644
> index 00000000..671f6814
> --- /dev/null
> +++ b/datasrc/ueventd/logging.c
> @@ -0,0 +1,63 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +
> +#include <stdio.h>
> +#include <stdarg.h>
> +#include <strings.h>
> +#include <errno.h>
> +#include <time.h>
> +
> +#include "ueventd.h"
> +
> +#define default_logfile "/var/log/ueventd.log"
> +
> +int log_priority = LOG_INFO;

Переменная не объявлена здесь как static и она никак не объявлена в 
заголовочном файле. Просто, на всякий случай.


> +
> +int logging_level(const char *name)
> +{
> +	if (!strcasecmp(name, "debug"))   return LOG_DEBUG;
> +	if (!strcasecmp(name, "info"))    return LOG_INFO;
> +	if (!strcasecmp(name, "warning")) return LOG_WARNING;
> +	if (!strcasecmp(name, "error"))   return LOG_ERR;
> +	return log_priority;

Понятно, что такая обработка, видимо писавшаяся под парсер в ueventd.c:

loglevel = logging_level(optarg);

упрощает код. Но тогда его правильней сделать локальной частью 
ueventd.c, как мне кажется. Потому что сейчас любое невалидное значение 
name просто не меняет текущего значения log_priority, а я не уверен, что 
это правильно. Если же функция остаётся в logging.c с таким дефолтом, то 
вроде как анализ "info" кажется лишним.


> +}
> +
> [...]


-- 
WBR, Leonid Krivoshein.