From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=XAzRtdmsfTbh/XL2uxd2jhF4BZ7Auuc1iUTzfuhCido=; b=pmkmDDdifE2zdFDQXYOU1E1gZMwr38t4Eaz2JBGsvfg7WAqdEOGxARIlS1kFLFr9oL bLminOdydt+4G+VSw/UVoQDogCBA5uM4myE0JaTFiGKPiktSUGVD0nQOEWVmI2sQeiTR YRceHthduetCOF6DzE3AydtCpCpp5NRgAblu0kYx+KLG3vmYpRaue61q9E+tbc4Zf2Wv jm6IC5lIGQAq7Ov6ggbQxWiy0KChLgwVYJfeQc1Q7jEiy4/KHAIJaPA1deppGSa7PHgY 1SRh8pgIzB7GkqAT2Zx7fiB6SDw3T+Whntk7BFUfVkELCeQgWusLA1hVnu8iecMInTk1 e2FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=XAzRtdmsfTbh/XL2uxd2jhF4BZ7Auuc1iUTzfuhCido=; b=sWS8+/1rYPYpSJtLeLWYqbKKzeDnWyI5DyUooRDSQ7+T/N//eiU3dlj6/iD1j75lp9 Iu8LqCpOd5c6zaJ+6XboEXbrPPc02FuQs4e3bjVaPK1DQPaf8cczXModN/fDcCVWGKmP W93qmPJpnlcUxIoYhBISQ/qjrCpU/Zry4/BvNHtFuu3qkf6G4mbc+wt7wTE4Lkv+rKgX 9SPPW0grtkXcfGotKmzx8EhqoEVErGXRU87aoeHNR5uW1ymj/TAk/d3aahiPCCL0fehr p+Bm/s4z/UKMnFududxueZKtCcaWm7827t2d1NtkIs+dGVIOwDnvIfn/tqGRoB/hc7/8 lbVw== X-Gm-Message-State: AOAM532zRJIXIVce8gLuc+HiQgXLRjVlKy3TCtGjG/7KFkWrK173zuvB 9ZIIYgrlFi4fk79j+k7QxRs57Pegam4= X-Google-Smtp-Source: ABdhPJyV3NbjpEDgoj0QZHW8z0AYUXdXZMpvfvhGuuGgHkbhlQaVQE/3jzGY/tH9t6a+2acCHgSAWQ== X-Received: by 2002:a2e:a4a9:: with SMTP id g9mr18672226ljm.175.1636208789369; Sat, 06 Nov 2021 07:26:29 -0700 (PDT) To: make-initrd@lists.altlinux.org References: <20211024172128.744EFA5E4C@lists.altlinux.org> <20211026111221.2bay4wh2xfvxq2vr@example.org> <5fea746a-25c2-01ee-3403-ed4a4815968f@gmail.com> <20211026135834.wvsbihztce6466sz@example.org> <2f91b485-6744-cd07-b1b8-46fcb250c713@gmail.com> <20211106124743.nfdo5qhrymgbkugk@example.org> From: Leonid Krivoshein Message-ID: <2e24ddde-b756-68e1-2e37-fb0d4c4154b8@gmail.com> Date: Sat, 6 Nov 2021 17:26:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20211106124743.nfdo5qhrymgbkugk@example.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru Subject: Re: [make-initrd] [PATCH v6 10/22] bootchain-core: expanded addressing capabilities X-BeenThere: make-initrd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: make-initrd@lists.altlinux.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2021 14:26:32 -0000 Archived-At: List-Archive: 06.11.2021 15:47, Alexey Gladkov пишет: > On Sat, Oct 30, 2021 at 05:13:49AM +0300, Leonid Krivoshein wrote: >> 30.10.2021 2:50, Gleb Fotengauer-Malinovskiy пишет: >>> On Tue, Oct 26, 2021 at 03:58:34PM +0200, Alexey Gladkov wrote: >>>> On Tue, Oct 26, 2021 at 02:28:53PM +0300, Leonid Krivoshein wrote: >>>>> 26.10.2021 14:12, Alexey Gladkov пишет: >>>>>> On Sun, Oct 24, 2021 at 08:21:28PM +0300, Leonid Krivoshein wrote: >>>>>>> Adds support for reverse addressing relative to the current step, >>>>>>> as well as calculating the path to the special device node obtained >>>>>>> in the previous step. >>>>>>> >>>>>>> Signed-off-by: Leonid Krivoshein >>>>>>> --- >>>>>>> features/bootchain-core/README.md | 6 +++ >>>>>>> .../data/bin/bootchain-sh-functions | 37 ++++++++++++++++--- >>>>>>> 2 files changed, 38 insertions(+), 5 deletions(-) >>>>>>> >>>>>>> diff --git a/features/bootchain-core/README.md b/features/bootchain-core/README.md >>>>>>> index 8d341e0..ba66259 100644 >>>>>>> --- a/features/bootchain-core/README.md >>>>>>> +++ b/features/bootchain-core/README.md >>>>>>> @@ -49,6 +49,12 @@ us to optimize fill in `initramfs` only which we are need. >>>>>>> - Modularity: loading methods are initially separated from the common >>>>>>> code and daemon. >>>>>>> +- Via resolve_target() supports not only forward, but also reverse addressing, >>>>>>> + relative to the current step. For example, a record like `step-3/dir1/dev` >>>>>>> + will process the result of `dir1/dev`, made in the third step from the current >>>>>>> + one. Together with the overload of the chain of steps, direct addressing is safe >>>>>>> + only when storing the numbers of the completed steps in files, whereas reverse >>>>>>> + relative addressing it is safe in any case and can often be more convenient. >>>>>> На мой взгляд очень непонятный синтаксис. step1 и step-1 кажется >>>>>> одинаковым. Хотя бы current-1 >>>>> OK. Давай переделаю так: >>>>> >>>>> step = pipe -- прямая адресация, так первоначально и было. >>>>> curr- -- обратная относительная адресация. >>>>> >>>>> Так будет лучше? >>>> Мне будет понятнее. Но я хотел бы спросить помощи зала. >>>> >>>> Глеб, Антон, как вы думаете, как будет понятнее ? >>> Если из предложенного выбирать, то curr- однозначно лучше. >>> >>> Но мне кажется, что тут - не читается как минус. Я бы скорее предложил >>> что-то вроде prev или back. >> Отлично, тогда переделаю на back ! >> >> Как я понял, по остальным моментам Алексей пока взял паузу... > В прошлый раз я вроде всё прокомментировал, что нашёл. Тогда перехожу к финальной итерации? Просто, мне показалось, что остались какие-то спорные моменты. -- Best regards, Leonid Krivoshein.