From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 13 Oct 2021 20:19:07 +0200 From: Alexey Gladkov To: make-initrd@lists.altlinux.org Message-ID: <20211013181907.u5brmwsks7tuxqjg@example.org> References: <90978b29-a2f6-ff0d-afdb-2bc3b4f7933c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <90978b29-a2f6-ff0d-afdb-2bc3b4f7933c@gmail.com> Subject: Re: [make-initrd] [PATCH v4 0/4] split pipeline into 4 features X-BeenThere: make-initrd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: make-initrd@lists.altlinux.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 18:19:09 -0000 Archived-At: List-Archive: On Wed, Oct 13, 2021 at 08:20:53PM +0300, Leonid Krivoshein wrote: > Привет! > > > Пробный шар -- не чтобы апстримить, а чтобы оценить самую сложную часть. > Если всё хорошо, за ней будут ещё коммиты, которые разделяются довольно > просто. Но первые четыре коммита -- это разделение pipeline на четыре части, > нет смысл такое апстримить как форк ради форка, в таком виде не добавляется > дополнительная функциональность. Сейчас получилось гораздо понятнее. Я с этим патчсетом согласен. Придираться к README не буду. Потом можно будет исправить. > > > > Leonid Krivoshein (4): > Separate new feature of bootchain-core from pipeline > kickstart: fix feature to work with bootchain-core > bootchain-core: move bootchain-sh-function to /bin > bootchain: separate getimage and waitdev features > > features/bootchain-core/README.md | 81 +++++++++++++++++++ > features/bootchain-core/config.mk | 5 ++ > .../data/bin/bootchain-sh-functions} | 12 +-- > .../data/etc/initrd/cmdline.d/bootchain-core | 4 + > .../data/etc/rc.d/init.d/bootchain} | 22 +---- > .../data/lib/bootchain}/mountfs | 2 +- > .../data/lib/bootchain}/overlayfs | 2 +- > .../data/lib/bootchain}/rootfs | 2 +- > .../data/lib/initrd/cmdline.d/bootchain | 6 ++ > .../data/lib/initrd/cmdline.d/pipeline | 2 +- > .../data/sbin/bootchained} | 22 ++--- > features/bootchain-core/rules.mk | 3 + > features/bootchain-getimage/README.md | 24 ++++++ > features/bootchain-getimage/config.mk | 5 ++ > .../etc/initrd/cmdline.d/bootchain-getimage | 1 + > .../data/lib/bootchain}/getimage | 2 +- > features/bootchain-getimage/rules.mk | 2 + > features/bootchain-waitdev/README.md | 22 +++++ > features/bootchain-waitdev/config.mk | 6 ++ > .../etc/initrd/cmdline.d/bootchain-waitdev | 1 + > .../udev/rules.d/50-bootchain-waitdev.rules} | 2 +- > .../data/lib/bootchain}/waitdev | 4 +- > .../data/lib/initrd/pre/bootchain/300-waitdev | 12 +++ > .../lib/uevent/filters/bootchain-waitdev} | 4 +- > features/bootchain-waitdev/rules.mk | 2 + > .../lib/{pipeline => bootchain}/kickstart | 2 +- > features/pipeline/config.mk | 9 +-- > .../data/etc/initrd/cmdline.d/pipeline | 5 -- > features/pipeline/rules.mk | 6 -- > 29 files changed, 207 insertions(+), 65 deletions(-) > create mode 100644 features/bootchain-core/README.md > create mode 100644 features/bootchain-core/config.mk > rename features/{pipeline/data/sbin/pipeline-sh-functions => > bootchain-core/data/bin/bootchain-sh-functions} (70%) > create mode 100644 > features/bootchain-core/data/etc/initrd/cmdline.d/bootchain-core > rename features/{pipeline/data/etc/rc.d/init.d/pipeline => > bootchain-core/data/etc/rc.d/init.d/bootchain} (63%) > rename features/{pipeline/data/lib/pipeline => > bootchain-core/data/lib/bootchain}/mountfs (91%) > rename features/{pipeline/data/lib/pipeline => > bootchain-core/data/lib/bootchain}/overlayfs (95%) > rename features/{pipeline/data/lib/pipeline => > bootchain-core/data/lib/bootchain}/rootfs (86%) > create mode 100755 > features/bootchain-core/data/lib/initrd/cmdline.d/bootchain > rename features/{pipeline => > bootchain-core}/data/lib/initrd/cmdline.d/pipeline (64%) > rename features/{pipeline/data/sbin/pipelined => > bootchain-core/data/sbin/bootchained} (78%) > create mode 100644 features/bootchain-core/rules.mk > create mode 100644 features/bootchain-getimage/README.md > create mode 100644 features/bootchain-getimage/config.mk > create mode 100644 > features/bootchain-getimage/data/etc/initrd/cmdline.d/bootchain-getimage > rename features/{pipeline/data/lib/pipeline => > bootchain-getimage/data/lib/bootchain}/getimage (93%) > create mode 100644 features/bootchain-getimage/rules.mk > create mode 100644 features/bootchain-waitdev/README.md > create mode 100644 features/bootchain-waitdev/config.mk > create mode 100644 > features/bootchain-waitdev/data/etc/initrd/cmdline.d/bootchain-waitdev > rename features/{pipeline/data/etc/udev/rules.d/50-pipeline-waitdev.rules > => bootchain-waitdev/data/etc/udev/rules.d/50-bootchain-waitdev.rules} (77%) > rename features/{pipeline/data/lib/pipeline => > bootchain-waitdev/data/lib/bootchain}/waitdev (83%) > create mode 100755 > features/bootchain-waitdev/data/lib/initrd/pre/bootchain/300-waitdev > rename features/{pipeline/data/lib/uevent/filters/pipeline-waitdev => > bootchain-waitdev/data/lib/uevent/filters/bootchain-waitdev} (77%) > create mode 100644 features/bootchain-waitdev/rules.mk > rename features/kickstart/data/lib/{pipeline => bootchain}/kickstart (93%) > delete mode 100644 features/pipeline/data/etc/initrd/cmdline.d/pipeline > > -- > 2.24.1 > > > _______________________________________________ > Make-initrd mailing list > Make-initrd@lists.altlinux.org > https://lists.altlinux.org/mailman/listinfo/make-initrd -- Rgrds, legion