From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gladkov.alexey@gmail.com>
Date: Sun, 26 Sep 2021 15:56:15 +0200
From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: make-initrd@lists.altlinux.org
Message-ID: <20210926135615.gtoxoddn3sev4gj6@example.org>
References: <146dd20e-866c-0e26-8071-8ba3a643a1f7@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <146dd20e-866c-0e26-8071-8ba3a643a1f7@gmail.com>
Subject: Re: [make-initrd] [PATCH v1 12/41] fork pipeline: overlayfs step
 modified
X-BeenThere: make-initrd@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: make-initrd@lists.altlinux.org
List-Id: <make-initrd.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/make-initrd>,
 <mailto:make-initrd-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/make-initrd>
List-Post: <mailto:make-initrd@lists.altlinux.org>
List-Help: <mailto:make-initrd-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/make-initrd>,
 <mailto:make-initrd-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Sep 2021 13:56:17 -0000
Archived-At: <http://lore.altlinux.org/make-initrd/20210926135615.gtoxoddn3sev4gj6@example.org/>
List-Archive: <http://lore.altlinux.org/make-initrd/>

On Fri, Sep 24, 2021 at 06:56:41PM +0300, Leonid Krivoshein wrote:
> ---
>  .../data/lib/bootchain/overlayfs              | 21 ++++++++++---------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git
> a/make-initrd/features/bootchain-core/data/lib/bootchain/overlayfs
> b/make-initrd/features/bootchain-core/data/lib/bootchain/overlayfs
> index 23b869b..48f9b7c 100755
> --- a/make-initrd/features/bootchain-core/data/lib/bootchain/overlayfs
> +++ b/make-initrd/features/bootchain-core/data/lib/bootchain/overlayfs
> @@ -1,26 +1,27 @@
>  #!/bin/bash -efu
>  -. pipeline-sh-functions
> +. bootchain-sh-functions
>   target="$(get_parameter OVERLAYFS)"
>   [ -n "$target" ] || [ -n "$prevdir" ] ||
> -	fatal "no previous step to use as lower directory"
> +	fatal "no previous step results to use as lower directory"
>  -pipe="${target:-$prevdir}"
> +chain="${target:-$prevdir}"
>  lowerdirs=
>  -while [ -n "$pipe" ]; do
> -	name="${pipe%%,*}"
> +while [ -n "$chain" ]; do
> +	name="${chain%%,*}"
>   	dir="$(resolve_target "$name")"
>  	lowerdirs="${lowerdirs:+$lowerdirs,}$dir"
>  -	pipe="${pipe#$name}"
> -	pipe="${pipe#,}"
> +	chain="${chain#$name}"
> +	chain="${chain#,}"
>  done
>  -mkdir -p -- "$datadir/rw" "$datadir/work"
> +run mkdir -p -- "$datadir/rw" "$datadir/work"
>  -run mount -o
> "lowerdir=$lowerdirs,upperdir=$datadir/rw,workdir=$datadir/work" \
> -	-t overlay overlay "$destdir"
> +opts="lowerdir=$lowerdirs,upperdir=$datadir/rw,workdir=$datadir/work"
> +
> +run mount -t overlay -o "$opts" -- overlay "$destdir"

Очередной "intermediate commit" (c) ? В описании одна строчка:

overlayfs step modified

То что он modified говорит сам патч, да я это вижу. Добавился
bootchain-sh-functions, какие-то переименования ...

Что это за изменения ?
Зачем это делается ?
Что это решает ?

Леонид, такие патчи не возможно ревьювить. Это какая-то нарезка каких-то
логически необоснованных изменений.

-- 
Rgrds, legion