From: Alexey Gladkov <legion@altlinux.ru>
To: Michael Shigorin <mike@altlinux.org>
Cc: make-initrd@lists.altlinux.org
Subject: Re: [make-initrd] [PATCH 2/2] [e2k] ftbfs workaround (disable TLS)
Date: Wed, 18 Aug 2021 19:36:30 +0200
Message-ID: <20210818173630.hphy4uaq5zy3cfxs@example.org> (raw)
In-Reply-To: <20210818162115.2813079-3-mike@altlinux.org>
On Wed, Aug 18, 2021 at 07:21:15PM +0300, Michael Shigorin wrote:
> The problem looks like this:
>
> lcc: "/usr/include/bits/byteswap.h", line 105: error #1348: declaration hides
> variable "__x" (declared at line 706 of
> "/usr/src/RPM/BUILD/make-initrd-2.20.1/external/busybox/upstream/networking/tls.c")
> [-Werror=shadow=global]
> ({ register __uint64_t __v, __x = (x); \
> ^
> in expansion of macro "__bswap_64" at line 37 of "/usr/include/byteswap.h"
> in expansion of macro "bswap_64" at line 198 of
> "/usr/src/RPM/BUILD/make-initrd-2.20.1/external/busybox/upstream/include/platform.h"
> in expansion of macro "bb_bswap_64" at line 214 of
> "/usr/src/RPM/BUILD/make-initrd-2.20.1/external/busybox/upstream/include/platform.h"
> in expansion of macro "SWAP_BE64" at line 706 of
> "/usr/src/RPM/BUILD/make-initrd-2.20.1/external/busybox/upstream/networking/tls.c"
> in expansion of macro "SWAP_BE64" at line 706 of
> "/usr/src/RPM/BUILD/make-initrd-2.20.1/external/busybox/upstream/networking/tls.c"
> tls->write_seq64_be = SWAP_BE64(1 + SWAP_BE64(tls->write_seq64_be));
> ^
>
> We think it's improper for toolchain to define
> quite common single-character symbols like this,
> thus I've filed mcst bug #6061.
Это что, шутка ?
> ---
> make-initrd.spec | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/make-initrd.spec b/make-initrd.spec
> index bc48e97..907d3ed 100644
> --- a/make-initrd.spec
> +++ b/make-initrd.spec
> @@ -204,6 +204,11 @@ Feature adds smart card daemon and smart card utilities.
>
> %prep
> %setup
> +%ifarch %e2k
> +# avoid ftbfs due to __v shadowing in /usr/include/bits/byteswap.h (mcst#6061)
> +sed -i -r 's,^CONFIG_(TLS|SSL_CLIENT|FEATURE_WGET_HTTPS)=y,CONFIG_\1=n,' \
> + external/busybox/config
> +%endif
Миш, это неправильно и я не могу с этим согласиться даже с %ifarch.
Выключать tls только из-за глючнсти /usr/include/bits/byteswap.h в
какой-то закрытой реализации libc я не буду. Почините byteswap.h.
--
Rgrds, legion
prev parent reply other threads:[~2021-08-18 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 16:21 [make-initrd] [PATCH 0/2] make-initrd: E2K ftbfs workaround; minor spec cleanup Michael Shigorin
2021-08-18 16:21 ` [make-initrd] [PATCH 1/2] spec: minor cleanup Michael Shigorin
2021-08-18 17:05 ` Alexey Gladkov
2021-08-18 17:10 ` Michael Shigorin
2021-08-18 17:40 ` Alexey Gladkov
2021-08-18 16:21 ` [make-initrd] [PATCH 2/2] [e2k] ftbfs workaround (disable TLS) Michael Shigorin
2021-08-18 17:36 ` Alexey Gladkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818173630.hphy4uaq5zy3cfxs@example.org \
--to=legion@altlinux.ru \
--cc=make-initrd@lists.altlinux.org \
--cc=mike@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Make-initrd development discussion
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/make-initrd/0 make-initrd/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 make-initrd make-initrd/ http://lore.altlinux.org/make-initrd \
make-initrd@lists.altlinux.org make-initrd@lists.altlinux.ru make-initrd@lists.altlinux.com
public-inbox-index make-initrd
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.make-initrd
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git