Make-initrd development discussion
 help / color / mirror / Atom feed
From: "Антон Мидюков" <antohami@basealt.ru>
To: make-initrd@lists.altlinux.org
Subject: Re: [make-initrd] [PATCH 1/2] plymouth: fix plymouth showing when drm is not ready yet
Date: Fri, 26 Apr 2024 14:20:31 +0700
Message-ID: <11ccd0a8-9e05-4ff1-9a01-7cb03526a13c@basealt.ru> (raw)
In-Reply-To: <ZiehQ3VxExqhAP0d@example.org>

23.04.2024 18:53, Alexey Gladkov пишет:
> On Tue, Apr 23, 2024 at 06:35:06PM +0700, Антон Мидюков wrote:
>> 23.04.2024 18:20, Alexey Gladkov пишет:
>>> On Tue, Apr 23, 2024 at 12:51:37PM +0700, antohami@basealt.ru wrote:
>>>> From: Anton Midyukov <antohami@altlinux.org>
>>>>
>>>> Fix waiting for a real video card when simpledrm is available.
>>>> card0 will disappear when the DRM module of the real video card is
>>>> loaded. Because of this, by the time Plymouth was shown, simpledrm
>>>> was no longer there, and there was no real video card yet.
>>>>
>>>> Instead of waiting for devices to appear, is proposed to launch
>>>> triggers for subsystems, as is uses in dracut.
>>>>
>>>> Signed-off-by: Anton Midyukov <antohami@altlinux.org>
>>>> ---
>>>>  features/plymouth/data/etc/rc.d/init.d/plymouth | 13 +++++++++++--
>>>>  1 file changed, 11 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/features/plymouth/data/etc/rc.d/init.d/plymouth b/features/plymouth/data/etc/rc.d/init.d/plymouth
>>>> index 20d64011..27d91876 100755
>>>> --- a/features/plymouth/data/etc/rc.d/init.d/plymouth
>>>> +++ b/features/plymouth/data/etc/rc.d/init.d/plymouth
>>>> @@ -19,8 +19,17 @@ start() {
>>>>  	[ -z "${NOSPLASH-}" ] && [ -z "${RDSHELL-}" ] ||
>>>>  		return 0
>>>>  
>>>> -	udevadm settle --timeout=30 --exit-if-exists=/sys/class/drm/card0/dev
>>>> -	udevadm settle --timeout=30 --exit-if-exists=/sys/class/graphics/fb0/dev
>>>> +	# first trigger graphics subsystem
>>>> +	udevadm trigger --action=add --attr-match=class=0x030000 > /dev/null 2>&1
>>>> +	# first trigger graphics and tty subsystem
>>>> +	udevadm trigger --action=add \
>>>> +		--subsystem-match=graphics \
>>>> +		--subsystem-match=drm \
>>>> +		--subsystem-match=tty \
>>>> +		--subsystem-match=acpi \
>>>> +		> /dev/null 2>&1
>>>> +
>>>> +	udevadm settle --timeout=60 2>&1
>>>>  
>>>>  	local pidfile=/run/plymouth/pid
>>>
>>> Хоть подход не нравится, но я смирился, что фича plymouth это чёрная дыра.
>>>
>>> У меня другой вопрос раз мы смотрим на dracut.
>>>
>>> Не стоит ли также скопировать у них код по вычислению tty вместо
>>> хардкода  --tty=/dev/tty1 ?
>>>
>>> https://github.com/dracutdevs/dracut/blob/master/modules.d/50plymouth/plymouth-pretrigger.sh#L19-L21
>>>
>>
>> Не знаю. Что это нам даст?
> 
> Отсутствие хардкода. Но раз ты не знаешь, то вопрос снимается.
> 

Патчи будут приняты или требуется сделать по-другому?

-- 
С уважением, Антон Мидюков <antohami@basealt.ru>



  reply	other threads:[~2024-04-26  7:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23  5:51 [make-initrd] [PATCH 0/2] Fix show plymouth antohami
2024-04-23  5:51 ` [make-initrd] [PATCH 1/2] plymouth: fix plymouth showing when drm is not ready yet antohami
2024-04-23 11:20   ` Alexey Gladkov
2024-04-23 11:35     ` Антон Мидюков
2024-04-23 11:53       ` Alexey Gladkov
2024-04-26  7:20         ` Антон Мидюков [this message]
2024-04-27 14:07           ` Alexey Gladkov
2024-05-15 15:06             ` Антон Мидюков
2024-05-15 16:50               ` Alexey Gladkov
2024-04-23  5:51 ` [make-initrd] [PATCH 2/2] udev: do not show the error that it is impossible to set the log level antohami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11ccd0a8-9e05-4ff1-9a01-7cb03526a13c@basealt.ru \
    --to=antohami@basealt.ru \
    --cc=make-initrd@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Make-initrd development discussion

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/make-initrd/0 make-initrd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 make-initrd make-initrd/ http://lore.altlinux.org/make-initrd \
		make-initrd@lists.altlinux.org make-initrd@lists.altlinux.ru make-initrd@lists.altlinux.com
	public-inbox-index make-initrd

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.make-initrd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git