From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS autolearn=no autolearn_force=no version=3.4.1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XJz/FRW5OFODuhZ3euwber9Nnkdwp0ukSPoVEU1CvM8=; b=gldQW67ulhCu1eUoi6x9L44Sl4bEWtqK2etNryhLxfMyLQs25JOJ/8OzZqwt53uiAv EMOI9FJ1X98Yr+Pk2NSN8NTZO+HwHsSxkGuSlwvKoCMG/YG7yY6AKGV7x01+CBaQCwg6 jhD42mV1U8WxjwLb9RKhAW+/8pqB3Cb1TVc+44KsOTo8+QHopR0ajCql6CXI4n9TUIr7 DjkqEWFJUsSTeITAaLpJbu+cdCrUuEs+JlDb7J3hpUVg6E0V0XhnABqsnVsvNrHujn3i 38J3cxFPCqMFFzWExgrBThEVY5BzPDp7PY7S5CfIzK8+hqgQ7brzmUhcUaGNEnIu/yZN eryA== X-Gm-Message-State: ANoB5plvF2W7TLLI5/OrbN6D5YkzNE17vi7Af9O4WXYOiWLzVCFAq3cB fdOisBf5ofvPbmJFvUHa1cE= X-Google-Smtp-Source: AA0mqf45M3rzpWrei/tYnNcGzn6REcHQ6s3opWUw+U01Xnxuyc3vCNfYjG3oxXj4zSvZq+YWAhzLgg== X-Received: by 2002:a17:906:d782:b0:7bc:9d14:a2db with SMTP id pj2-20020a170906d78200b007bc9d14a2dbmr44105534ejb.770.1670398759779; Tue, 06 Dec 2022 23:39:19 -0800 (PST) Message-ID: Date: Wed, 7 Dec 2022 08:39:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Samuel Thibault , Greg Kroah-Hartman , kbd@lists.altlinux.org, linux-kernel@vger.kernel.org References: <20221205000739.583233140@ens-lyon.org> <20221205000807.751605665@ens-lyon.org> <27ade063-79df-dad9-0427-e16f1ddb43ef@kernel.org> <20221206203947.5yifmkntf4uy7lt6@begin> From: Jiri Slaby In-Reply-To: <20221206203947.5yifmkntf4uy7lt6@begin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [kbd] [patch 1/3] VT: Add height parameter to con_font_get/set consw operations X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2022 07:39:21 -0000 Archived-At: List-Archive: On 06. 12. 22, 21:39, Samuel Thibault wrote: > Jiri Slaby, le mar. 06 déc. 2022 07:40:30 +0100, a ecrit: >> On 05. 12. 22, 1:07, Samuel Thibault wrote: >>> --- linux-6.0.orig/drivers/usb/misc/sisusbvga/sisusb_con.c >>> +++ linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c >> ... >>> @@ -1268,7 +1271,7 @@ sisusbcon_font_get(struct vc_data *c, st >>> } >>> /* Copy 256 chars only, like vgacon */ >>> - memcpy(font->data, sisusb->font_backup, 256 * 32); >>> + memcpy(font->data, sisusb->font_backup, 256 * height); >> >> Have you tested this? > > Ah, no, I had assumed that this was for a specific arch. But actually I > wasn't getting it because it depends on BROKEN. Hmm, for two years... I will remove the con support completely next week if noone beats me to it. thanks, -- js suse labs