From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gregkh@linuxfoundation.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
 s=korg; t=1670401281;
 bh=AHYARf/KLi6/VS3V2qrLnnBM6L3OOASJ3QfbNSJr3v4=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=gZGIe60FWKXP45dBXICPi7LeOroY6MUvczqbZPpmq6lSJAK4VPWND04yyHI0Yb7Uh
 SOIfA8o9Qc6g1DtF5JGJAYNoO2o5ZiVbKk25gzRtGa7G2lVGqOo0xadjhjmxib97r/
 DnZwJSXcI12HjJPRHr0Ad/twnSiAc7SSnNbfWjhM=
Date: Wed, 7 Dec 2022 09:21:18 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Message-ID: <Y5BM/q4K2a9V6SvR@kroah.com>
References: <20221205000739.583233140@ens-lyon.org>
 <20221205000807.751605665@ens-lyon.org>
 <27ade063-79df-dad9-0427-e16f1ddb43ef@kernel.org>
 <20221206203947.5yifmkntf4uy7lt6@begin>
 <fa5d6cbc-8f83-9e41-0513-adcb32422d2f@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fa5d6cbc-8f83-9e41-0513-adcb32422d2f@kernel.org>
X-Mailman-Approved-At: Wed, 07 Dec 2022 14:41:37 +0300
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 linux-kernel@vger.kernel.org, kbd@lists.altlinux.org
Subject: Re: [kbd] [patch 1/3] VT: Add height parameter to con_font_get/set
 consw operations
X-BeenThere: kbd@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Linux console tools development discussion <kbd@lists.altlinux.org>
List-Id: Linux console tools development discussion <kbd.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/kbd>
List-Post: <mailto:kbd@lists.altlinux.org>
List-Help: <mailto:kbd-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2022 08:21:29 -0000
Archived-At: <http://lore.altlinux.org/kbd/Y5BM%2Fq4K2a9V6SvR@kroah.com/>
List-Archive: <http://lore.altlinux.org/kbd/>

On Wed, Dec 07, 2022 at 08:39:18AM +0100, Jiri Slaby wrote:
> On 06. 12. 22, 21:39, Samuel Thibault wrote:
> > Jiri Slaby, le mar. 06 déc. 2022 07:40:30 +0100, a ecrit:
> > > On 05. 12. 22, 1:07, Samuel Thibault wrote:
> > > > --- linux-6.0.orig/drivers/usb/misc/sisusbvga/sisusb_con.c
> > > > +++ linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
> > > ...
> > > > @@ -1268,7 +1271,7 @@ sisusbcon_font_get(struct vc_data *c, st
> > > >    	}
> > > >    	/* Copy 256 chars only, like vgacon */
> > > > -	memcpy(font->data, sisusb->font_backup, 256 * 32);
> > > > +	memcpy(font->data, sisusb->font_backup, 256 * height);
> > > 
> > > Have you tested this?
> > 
> > Ah, no, I had assumed that this was for a specific arch. But actually I
> > wasn't getting it because it depends on BROKEN.
> 
> Hmm, for two years... I will remove the con support completely next week if
> noone beats me to it.

If you do it this week we can get it into 6.2 :)