From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on sa.local.altlinux.org X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DNS_FROM_AHBL_RHSBL,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.0 Message-ID: <554280BE.7080706@gmail.com> Date: Thu, 30 Apr 2015 22:21:34 +0300 From: Alexey Gladkov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Felix Janda References: <20150422190649.GE3170@euler> <554004DA.3060108@gmail.com> <20150429181152.GC1364@euler> In-Reply-To: <20150429181152.GC1364@euler> OpenPGP: id=4CFFD434; url=http://pgp.mit.edu:11371/pks/lookup?op=vindex&fingerprint=on&search=0xA45ABA544CFFD434 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kbd@lists.altlinux.org Subject: Re: [kbd] [PATCH 5/5] Replace error() by fprintf() and perror() X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 19:21:09 -0000 Archived-At: List-Archive: 29.04.2015 21:11, Felix Janda пишет: > Thanks for applying the other patches and for kbd_error()! Now everything > compiles fine with musl libc. > > However kbd_error() does not behave correctly in the case that the first > argument is 0 (EXIT_SUCCESS). error() does _not_ terminate the program > if the first argument is EXIT_SUCCESS. Maybe have in addition a > kbd_warn() so that the __attribute__((noreturn)) can stay for kbd_error() > (then the exitnum argument would also become superfluous). You right. I missed it. Fixed. > My excuse [1] for changing the error messages (no more program name) was > because the source is inconsistent. For example init_vt() in vlock/vt.c > or main() in kbdinfo.c mix fprintf(stderr) and error(). It seems to me > that error was mainly used as a convenient shorthand for > fprint(stderr) && exit(). (Having a shorthand makes sense.) Agree. It will be necessary to bring messages to one format. > PS: Could you maybe note on the webpage that git.altlinux.org is the > main git repository and might be ahead of the git.kernel.org repo? I usually send changes to both the repository. > [1]: http://lists.altlinux.org/pipermail/kbd/2014-December/000487.html -- Rgrds, legion