From: Alexey Gladkov <gladkov.alexey@gmail.com> To: Linux console tools development discussion <kbd@lists.altlinux.org> Subject: Re: [kbd] [PATCH] loadkeys: Auto-convert “traditional”/Unicode keysyms Date: Fri, 17 Apr 2009 03:01:09 +0400 Message-ID: <49E7B8B5.5000302@gmail.com> (raw) In-Reply-To: <20090416154504.GA8180@graeme> [-- Attachment #1: Type: text/plain, Size: 2727 bytes --] 16.04.2009 19:45, Michael Schutte wrote: > Do you do this right after the above commands, or after you restored > Unicode mode? I guess it’s the latter; at least as far as I can see, > the two commands behave identically when they are run in immediate > succession. I tested exactly like that: <user>$ src/unicode_stop <user>$ export LANG=ru_RU.koi8r <user>$ setfont data/consolefonts/koi8r-8x16 <root># loadkeys data/keymaps/i386/qwerty/ruwin_cplk-KOI8-R.map <user>$ < I getting correct chars when I typing a russian text > <user>$ dumpkeys -n > dump-loadkeys.old <root># src/loadkeys data/keymaps/i386/qwerty/ruwin_cplk-KOI8-R.map <user>$ < I getting wrong chars when I typing a russian text > <user>$ dumpkeys -n > dump-loadkeys.new <root># loadkeys data/keymaps/i386/qwerty/ruwin_cplk-KOI8-R.map <user>$ < correct chars again > > charset "koi8-r" > > at the beginning of ruwin_cplk-KOI8-R.map. Can you confirm this? It does not help. But the broken simbols are different. I see difference in "dumpkeys -n" output (see attach). Did I miss something? >> How do you test this patch? > Pretty much the way you do: loadkeys, typing some things, Hmmm ... you typing in what language? > verifying that dumpkeys doesn’t show different results (and if so, whether the > differences are intended by my patch). see attach. > I’d say it should be used just the same way as before, just that it > should work regardless of the input file’s encoding. As long as this > keymap file has a “charset” specification, that is; I have to admit that > I didn’t consider that so many .map files don’t feature such a line. > Still, this shouldn’t be a regression: When the input encoding and the > console mode (XLATE/Unicode) are compatible, my patch shouldn’t change > the behaviour. Your patch will change the behaviour. At least for the russian keymaps will need to add "charset" directive. We have 4 charsets (koi8-r, cp1251, cp855, iso8859-5 and utf8). Without "charset" you do not know what encoding is used in keymap. > The true reason why I want to push this, though, is that Debian’s > version of kbd has had a similar patch since 2004. I want to be completely sure it's working with old keymaps. > I’d like to get rid of this divergence without losing its useful features. This is a good reason. :) > This is why I’ve cleaned it up and why I’m discussing it with you now. I am concerned keymaps legacy. We have a lot of keymaps that are not added to the kbd package. Your patch should support the old behaviour for them. Probably would be better to implement a new option to enable/disable autodetection. > Thanks for you patience :-) No problem :) -- Rgrds, legion [-- Attachment #2: dump-loadkeys.new.bz2 --] [-- Type: application/x-bzip2, Size: 4951 bytes --] [-- Attachment #3: dump-loadkeys.old.bz2 --] [-- Type: application/x-bzip2, Size: 5035 bytes --]
next prev parent reply other threads:[~2009-04-16 23:01 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-04-14 17:45 Michael Schutte 2009-04-14 21:37 ` Alexey Gladkov 2009-04-15 13:53 ` Michael Schutte 2009-04-16 0:07 ` Alexey Gladkov 2009-04-16 15:45 ` Michael Schutte 2009-04-16 23:01 ` Alexey Gladkov [this message] 2009-04-17 13:44 ` Alexey Gladkov 2009-04-17 20:01 ` Michael Schutte 2009-04-19 15:59 ` Alexey Gladkov 2009-04-19 16:50 ` Michael Schutte 2009-04-19 17:14 ` Alexey Gladkov 2009-04-20 18:39 ` Michael Schutte 2009-04-21 10:08 ` Alexey Gladkov 2009-04-21 13:20 ` Michael Schutte 2009-04-16 23:36 ` Alexey Gladkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=49E7B8B5.5000302@gmail.com \ --to=gladkov.alexey@gmail.com \ --cc=kbd@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux console tools development discussion This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \ kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com public-inbox-index kbd Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.kbd AGPL code for this site: git clone https://public-inbox.org/public-inbox.git