From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS autolearn=no autolearn_force=no version=3.4.1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JV4BRkcw7J2X95dDZsQQ3oLBuX11q5eUftbrluM0Dh0=; b=T0Tkr7V3DaA8hlvyvHAyMDJoSVKs2CX0zdtcCUrQENOPiyzlylvOmpwyIP/SUy5jI8 Aw/tkjhF71kndQMWu8bR1Xc2C2Waoql+HbUiACZ5yx9j2zJAnk81lyAkj/AL3VBgNz+i jtG6k/7wLQkPO9qzk9Il5kmH3vl/4MzpqHMckUu1paeXK5gtqK/4MfFmSTEbYVlYyKdY t3uYTSczipcwUchBpjzxJTn5PmHVSMxmrXUUVtANurtkOaAni+FXakZu3V5PEokplS6v DOluNFwlAkAxr5awtBtezuwmo8aV8NLv0tPJvWIJ1BXMR0PoMmORXPhvUrR3hwWKl9OW UfpA== X-Gm-Message-State: ANoB5plGHs/wYv5PyyfWcB0AtXwHpDMnBSju4zZ23Qd3gXt4YRikAPXz A5vzv0Xm9GNnVWthGYoG3lFRoO+4wi0= X-Google-Smtp-Source: AA0mqf4d4dBaMsLlYCr5A7hjQB4AHXV7Mgl/bM4ChBIFIJeXuKLvPppdkNZh7idDsmJVUnZmfUjHLg== X-Received: by 2002:a05:6402:2912:b0:46a:c132:8a25 with SMTP id ee18-20020a056402291200b0046ac1328a25mr44300824edb.205.1670309319238; Mon, 05 Dec 2022 22:48:39 -0800 (PST) Message-ID: <45c09e48-9e69-2371-70d2-8a0b1e9f4899@kernel.org> Date: Tue, 6 Dec 2022 07:48:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Samuel Thibault , Greg Kroah-Hartman , kbd@lists.altlinux.org References: <20221205000739.583233140@ens-lyon.org> <20221205000807.896278194@ens-lyon.org> From: Jiri Slaby In-Reply-To: <20221205000807.896278194@ens-lyon.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 06 Dec 2022 15:07:26 +0300 Cc: linux-kernel@vger.kernel.org Subject: Re: [kbd] [patch 3/3] VT: Bump font size limitation to 64x128 pixels X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2022 06:48:41 -0000 Archived-At: List-Archive: On 05. 12. 22, 1:07, Samuel Thibault wrote: > This moves 32x32 font size limitation checking down to drivers, so that > fbcon can allow large fonts. > > We still keep a limitation to 64x128 pixels so as to have a simple bounded > allocation for con_font_get and in the userland kbd tool. That glyph size > will however be enough to have 128x36 characters on a "16/9 8K display". > > Signed-off-by: Samuel Thibault > > Index: linux-6.0/drivers/tty/vt/vt.c > =================================================================== > --- linux-6.0.orig/drivers/tty/vt/vt.c > +++ linux-6.0/drivers/tty/vt/vt.c > @@ -4575,17 +4575,20 @@ void reset_palette(struct vc_data *vc) ... > -#define max_font_size 65536 > +#define max_font_width 64 > +#define max_font_height 128 > +#define max_font_glyphs 512 > +#define max_font_size (max_font_glyphs*max_font_width*max_font_height) So this is 64K -> 4M switch. We should likely convert to kvmalloc() too. regards, -- js suse labs