From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Alexey Gladkov <legion@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org,
Linux console tools development discussion
<kbd@lists.altlinux.org>
Subject: Re: [kbd] [patch] font: Leverage KD_FONT_OP_GET/SET_TALL font operations
Date: Mon, 16 Jan 2023 23:44:34 +0100
Message-ID: <20230116224434.sjo2ez4j6l4av4bc@begin> (raw)
In-Reply-To: <Y78VRTF6cxHhio+s@example.org>
Alexey Gladkov, le mer. 11 janv. 2023 21:00:05 +0100, a ecrit:
> > @@ -54,13 +55,13 @@ do_loadfont(struct kfont_context *ctx, i
> > int bad_video_erase_char = 0;
> > int ret;
> >
> > - if (height < 1 || height > 32) {
> > - KFONT_ERR(ctx, _("Bad character height %d"), height);
> > + if (height < 1 || height > 64) {
> > + KFONT_ERR(ctx, _("Bad character height %d (limit is 64)"), height);
>
> Hm. But max_font_height is 128. Shouldn't it be height > 128 ?
>
> > return -EX_DATAERR;
> > }
> >
> > - if (width < 1 || width > 32) {
> > - KFONT_ERR(ctx, _("Bad character width %d"), width);
> > + if (width < 1 || width > 128) {
> > + KFONT_ERR(ctx, _("Bad character width %d (limit is 128)"), width);
>
> Same here. max_font_width is 64.
Oops, sure, fixed it, will send an updated kbd patch for that.
Samuel
next prev parent reply other threads:[~2023-01-16 22:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 0:32 [kbd] [patchv2 0/3] VT: Support >32x32 fonts for hidpi displays Samuel Thibault
2022-12-18 0:32 ` [kbd] [patchv2 1/3] VT: Add height parameter to con_font_get/set consw operations Samuel Thibault
2023-01-19 15:09 ` Greg Kroah-Hartman
2023-01-19 15:20 ` Samuel Thibault
2022-12-18 0:32 ` [kbd] [patchv2 2/3] VT: Add KD_FONT_OP_SET/GET_TALL operations Samuel Thibault
2022-12-18 0:32 ` [kbd] [patchv2 3/3] VT: Bump font size limitation to 64x128 pixels Samuel Thibault
2022-12-18 14:39 ` Alexey Gladkov
2022-12-18 14:55 ` Samuel Thibault
2022-12-18 15:25 ` Alexey Gladkov
2022-12-18 15:28 ` Samuel Thibault
2022-12-18 15:38 ` Alexey Gladkov
2023-01-19 14:55 ` Greg Kroah-Hartman
2022-12-18 0:33 ` [kbd] [patch] font: Leverage KD_FONT_OP_GET/SET_TALL font operations Samuel Thibault
2023-01-11 20:00 ` Alexey Gladkov
2023-01-16 22:44 ` Samuel Thibault [this message]
2023-01-10 20:55 ` [kbd] [patchv2 0/3] VT: Support >32x32 fonts for hidpi displays Samuel Thibault
2023-01-18 14:00 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116224434.sjo2ez4j6l4av4bc@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kbd@lists.altlinux.org \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux console tools development discussion
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
public-inbox-index kbd
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.kbd
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git