From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,FSL_HELO_HOME autolearn=no autolearn_force=no version=3.4.1 Date: Sun, 18 Dec 2022 16:28:57 +0100 From: Samuel Thibault To: Alexey Gladkov Message-ID: <20221218152857.qle75c6lhexkdoym@begin> Mail-Followup-To: Samuel Thibault , Alexey Gladkov , Greg Kroah-Hartman , Jiri Slaby , kbd@lists.altlinux.org, linux-kernel@vger.kernel.org References: <20221218003209.503539532@ens-lyon.org> <20221218003237.503424466@ens-lyon.org> <20221218145532.syqzu76q23rz4tx6@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Cc: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, kbd@lists.altlinux.org Subject: Re: [kbd] [patchv2 3/3] VT: Bump font size limitation to 64x128 pixels X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2022 19:06:44 -0000 Archived-At: List-Archive: Alexey Gladkov, le dim. 18 déc. 2022 16:25:01 +0100, a ecrit: > On Sun, Dec 18, 2022 at 03:55:32PM +0100, Samuel Thibault wrote: > > Alexey Gladkov, le dim. 18 déc. 2022 15:39:38 +0100, a ecrit: > > > On Sun, Dec 18, 2022 at 01:32:12AM +0100, Samuel Thibault wrote: > > > > -#define max_font_size 65536 > > > > +#define max_font_width 64 > > > > +#define max_font_height 128 > > > > +#define max_font_glyphs 512 > > > > +#define max_font_size (max_font_glyphs*max_font_width*max_font_height) > > > > > > As a suggestion that you can safely ignore. Maybe make max_font_glyphs a > > > sysctl parameter to be able to use larger fonts ? > > > > > > I get requests from time to time in kbd that it is not possible to load a > > > larger font. > > > > 64KiB was really low, while the theoretically possible max was > > 32*32*512 = 512KB, so I understand there used to be such requests :) > > > > Here, by setting the max to 64x128*512, I don't think we'll need more. > > I was not talking about the size of one glyph, but about the number of > glyphs in the font. Right now the font cannot have more than 512 glyphs. That one is unfortunately *very* hardcoded in the VT code, since it's the very representation of the console text in vc_screenbuf which is set to the VGA-based 16bits per glyph, with a 8+8 or 9+7 separation between glyph number and color number. Lifting that would be way more involved. Samuel