From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=o4NH=4E=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00
 autolearn=unavailable autolearn_force=no version=3.4.1
Date: Tue, 6 Dec 2022 21:39:47 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Jiri Slaby <jirislaby@kernel.org>
Message-ID: <20221206203947.5yifmkntf4uy7lt6@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 Jiri Slaby <jirislaby@kernel.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 kbd@lists.altlinux.org, linux-kernel@vger.kernel.org
References: <20221205000739.583233140@ens-lyon.org>
 <20221205000807.751605665@ens-lyon.org>
 <27ade063-79df-dad9-0427-e16f1ddb43ef@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <27ade063-79df-dad9-0427-e16f1ddb43ef@kernel.org>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-kernel@vger.kernel.org, kbd@lists.altlinux.org
Subject: Re: [kbd] [patch 1/3] VT: Add height parameter to con_font_get/set
 consw operations
X-BeenThere: kbd@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Linux console tools development discussion <kbd@lists.altlinux.org>
List-Id: Linux console tools development discussion <kbd.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/kbd>
List-Post: <mailto:kbd@lists.altlinux.org>
List-Help: <mailto:kbd-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2022 01:27:11 -0000
Archived-At: <http://lore.altlinux.org/kbd/20221206203947.5yifmkntf4uy7lt6@begin/>
List-Archive: <http://lore.altlinux.org/kbd/>

Jiri Slaby, le mar. 06 déc. 2022 07:40:30 +0100, a ecrit:
> On 05. 12. 22, 1:07, Samuel Thibault wrote:
> > --- linux-6.0.orig/drivers/usb/misc/sisusbvga/sisusb_con.c
> > +++ linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
> ...
> > @@ -1268,7 +1271,7 @@ sisusbcon_font_get(struct vc_data *c, st
> >   	}
> >   	/* Copy 256 chars only, like vgacon */
> > -	memcpy(font->data, sisusb->font_backup, 256 * 32);
> > +	memcpy(font->data, sisusb->font_backup, 256 * height);
> 
> Have you tested this?

Ah, no, I had assumed that this was for a specific arch. But actually I
wasn't getting it because it depends on BROKEN.

> What does this 'height' refer to?

It was meant to be vpitch actually, I will fix it.

Samuel