From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kbd@lists.altlinux.org
Subject: Re: [kbd] [patch 1/3] VT: Add height parameter to con_font_get/set consw operations
Date: Tue, 6 Dec 2022 21:39:47 +0100
Message-ID: <20221206203947.5yifmkntf4uy7lt6@begin> (raw)
In-Reply-To: <27ade063-79df-dad9-0427-e16f1ddb43ef@kernel.org>
Jiri Slaby, le mar. 06 déc. 2022 07:40:30 +0100, a ecrit:
> On 05. 12. 22, 1:07, Samuel Thibault wrote:
> > --- linux-6.0.orig/drivers/usb/misc/sisusbvga/sisusb_con.c
> > +++ linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
> ...
> > @@ -1268,7 +1271,7 @@ sisusbcon_font_get(struct vc_data *c, st
> > }
> > /* Copy 256 chars only, like vgacon */
> > - memcpy(font->data, sisusb->font_backup, 256 * 32);
> > + memcpy(font->data, sisusb->font_backup, 256 * height);
>
> Have you tested this?
Ah, no, I had assumed that this was for a specific arch. But actually I
wasn't getting it because it depends on BROKEN.
> What does this 'height' refer to?
It was meant to be vpitch actually, I will fix it.
Samuel
next prev parent reply other threads:[~2022-12-06 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 0:07 [kbd] [patch 0/3] VT: Support >32x32 fonts for hidpi displays Samuel Thibault
2022-12-05 0:07 ` [kbd] [patch 1/3] VT: Add height parameter to con_font_get/set consw operations Samuel Thibault
2022-12-06 6:40 ` Jiri Slaby
2022-12-06 20:39 ` Samuel Thibault [this message]
2022-12-07 7:39 ` Jiri Slaby
2022-12-07 8:21 ` Greg Kroah-Hartman
2022-12-05 0:07 ` [kbd] [patch 2/3] VT: Add KD_FONT_OP_SET/GET_TALL operations Samuel Thibault
2022-12-05 0:07 ` [kbd] [patch 3/3] VT: Bump font size limitation to 64x128 pixels Samuel Thibault
2022-12-06 6:48 ` Jiri Slaby
2022-12-06 20:47 ` Samuel Thibault
2022-12-05 0:09 ` [kbd] [patch 1/1] font: Leverage KD_FONT_OP_GET/SET_TALL font operations Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206203947.5yifmkntf4uy7lt6@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kbd@lists.altlinux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux console tools development discussion
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
public-inbox-index kbd
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.kbd
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git