[kbd] PPKB map file

[kbd] PPKB map file

[Peter Thomason]

Hi KBD,

I made keymap for the PinePhone Keyboard (Linux based smartphone) and
was wondering if I could get it included into the package. I have
included the links to my repo for the keymap file:
https://codeberg.org/HazardChem/PinePhone_Keyboard/src/branch/main/tty

And the phone:
https://wiki.pine64.org/wiki/PinePhone_(Pro)_Keyboard

The whole keyboard can be moved apart from the meta key, space bar, and
the enter key, so I used that basis to write a map that can be adjusted
so the user can move the keys around and still get the configuration
options that they should expect from using the internal firmware on the
keyboard to change what the OS sees from the keyboard.

Pleaase let me know if you have any other questions and have a good
day!

-- 
Regards, 

Peter Thomason
Mobile: +61 458 738 370
Email: pthom44@live.com.au

Re: [kbd] PPKB map file

[Alexey Gladkov]

On Mon, May 23, 2022 at 11:26:30AM +1000, Peter Thomason wrote:
> Hi KBD,
> 
> I made keymap for the PinePhone Keyboard (Linux based smartphone) and
> was wondering if I could get it included into the package. I have
> included the links to my repo for the keymap file:
> https://codeberg.org/HazardChem/PinePhone_Keyboard/src/branch/main/tty
> 
> And the phone:
> https://wiki.pine64.org/wiki/PinePhone_(Pro)_Keyboard
> 
> The whole keyboard can be moved apart from the meta key, space bar, and
> the enter key, so I used that basis to write a map that can be adjusted
> so the user can move the keys around and still get the configuration
> options that they should expect from using the internal firmware on the
> keyboard to change what the OS sees from the keyboard.
> 
> Pleaase let me know if you have any other questions and have a good
> day!

I don't mind to add this keymap but the keymap name should match the
language i.e. in your case kbd/keymap/pine/en.map .

If you have no objections, then I will add a keymap.

-- 
Rgrds, legion

Re: [kbd] PPKB map file

[Alexey Gladkov]

On Sun, May 29, 2022 at 01:46:01PM +1000, pthom44@live.com.au wrote:
> Hi Legion,
> 
> I have made some quick adjustments to remove some comments that I left.
> 
> That is a good idea, I did update the name to reflect english qwerty layout.
> Would that be a suitable name? The file location you mentioned sounds
> suitable to me as well.

If you assume that there can be not only qwerty keymaps, then it is better
to make it a subdirectory, as it is done in i386.

In this case, I suggest calling kbd/data/pine/qwerty/en.map

-- 
Rgrds, legion

Re: [kbd] PPKB map file

[Alexey Gladkov]

On Sat, May 28, 2022 at 05:41:04PM +0200, Alexey Gladkov wrote:
> On Mon, May 23, 2022 at 11:26:30AM +1000, Peter Thomason wrote:
> > Hi KBD,
> > 
> > I made keymap for the PinePhone Keyboard (Linux based smartphone) and
> > was wondering if I could get it included into the package. I have
> > included the links to my repo for the keymap file:
> > https://codeberg.org/HazardChem/PinePhone_Keyboard/src/branch/main/tty
> > 
> > And the phone:
> > https://wiki.pine64.org/wiki/PinePhone_(Pro)_Keyboard
> > 
> > The whole keyboard can be moved apart from the meta key, space bar, and
> > the enter key, so I used that basis to write a map that can be adjusted
> > so the user can move the keys around and still get the configuration
> > options that they should expect from using the internal firmware on the
> > keyboard to change what the OS sees from the keyboard.
> > 
> > Pleaase let me know if you have any other questions and have a good
> > day!
> 
> I don't mind to add this keymap but the keymap name should match the
> language i.e. in your case kbd/keymap/pine/en.map .
> 
> If you have no objections, then I will add a keymap.

Sorry that I didn't think about it and didn't say it earlier.

-- 
Rgrds, legion

Re: [kbd] PPKB map file

[Alexey Gladkov]

On Sun, May 29, 2022 at 09:43:02PM +1000, pthom44@live.com.au wrote:
> I think the original suggestion will be better, in kbd/keymap/pine/en.map
> There is only one variant that gets manufactured by pine64. I have updated
> the codeberg repo to reflect that name change to just en.map.
> 
> If you agree with that thinking then I'm happy to proceed with you adding
> the keymap.

Applied. Thanks!

https://git.kernel.org/pub/scm/linux/kernel/git/legion/kbd.git/commit/?id=1589e9e1019756b5287b41dddcd7285271c5990e

> On Sun, May 29 2022 at 12:46:41 PM +0200, Alexey Gladkov
> <gladkov.alexey@gmail.com> wrote:
> > On Sat, May 28, 2022 at 05:41:04PM +0200, Alexey Gladkov wrote:
> > >  On Mon, May 23, 2022 at 11:26:30AM +1000, Peter Thomason wrote:
> > >  > Hi KBD,
> > >  >
> > >  > I made keymap for the PinePhone Keyboard (Linux based smartphone)
> > > and
> > >  > was wondering if I could get it included into the package. I have
> > >  > included the links to my repo for the keymap file:
> > >  > <https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodeberg.org%2FHazardChem%2FPinePhone_Keyboard%2Fsrc%2Fbranch%2Fmain%2Ftty&data=05%7C01%7C%7C190f3a73cdda45818d7708da41608808%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637894180126748563%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=0F9GqoFQKcSsdMO7Zzfj6ygHeR2VUjAGbp5MhEUUYSA%3D&reserved=0>
> > >  >
> > >  > And the phone:
> > >  > <https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwiki.pine64.org%2Fwiki%2FPinePhone_&data=05%7C01%7C%7C190f3a73cdda45818d7708da41608808%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637894180126748563%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gnSLW0JhRGVki9XPSSVnyhzahPGQjG4vRKQ8amtEGkU%3D&reserved=0(Pro)_Keyboard>
> > >  >
> > >  > The whole keyboard can be moved apart from the meta key, space
> > > bar, and
> > >  > the enter key, so I used that basis to write a map that can be
> > > adjusted
> > >  > so the user can move the keys around and still get the
> > > configuration
> > >  > options that they should expect from using the internal firmware
> > > on the
> > >  > keyboard to change what the OS sees from the keyboard.
> > >  >
> > >  > Pleaase let me know if you have any other questions and have a
> > > good
> > >  > day!
> > > 
> > >  I don't mind to add this keymap but the keymap name should match the
> > >  language i.e. in your case kbd/keymap/pine/en.map .
> > > 
> > >  If you have no objections, then I will add a keymap.
> > 
> > Sorry that I didn't think about it and didn't say it earlier.
> > 
> > --
> > Rgrds, legion
> > 
> 

-- 
Rgrds, legion