From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gladkov.alexey@gmail.com>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,
 FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no
 version=3.4.1
Date: Wed, 3 Mar 2021 19:59:30 +0100
From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: Anisse Astier <anisse@astier.eu>
Message-ID: <20210303185930.hjzwzymjdus5xizk@example.org>
References: <20210302004727.kcmcofcmw6ki5atc@example.org>
 <20210303170943.28797-1-anisse@astier.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210303170943.28797-1-anisse@astier.eu>
Cc: kbd@lists.altlinux.org
Subject: Re: [kbd] [PATCH] src/libkeymap: better error message on
 unsupported unicode value
X-BeenThere: kbd@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Linux console tools development discussion <kbd@lists.altlinux.org>
List-Id: Linux console tools development discussion <kbd.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/kbd>
List-Post: <mailto:kbd@lists.altlinux.org>
List-Help: <mailto:kbd-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Mar 2021 18:59:46 -0000
Archived-At: <http://lore.altlinux.org/kbd/20210303185930.hjzwzymjdus5xizk@example.org/>
List-Archive: <http://lore.altlinux.org/kbd/>

On Wed, Mar 03, 2021 at 06:09:43PM +0100, Anisse Astier wrote:
> The auto-generated (with ckbcomp) file fr-bepo_afnor did not load (even
> partially), because of an U+1f12f (copyleft symbol) that is wrongly
> parsed, generating this error message:
> 	too many (160) entries on one line
> 
> Fix libkeymap so that the symbol can be parsed, and later generate a
> better error message:
> 	unicode keysym out of range: U+1f12f
> 
> At least users will know what is wrong with their keymap.
> 
> Signed-off-by: Anisse Astier <anisse@astier.eu>

Applied. Thanks!

> ---
>  src/libkeymap/analyze.l | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libkeymap/analyze.l b/src/libkeymap/analyze.l
> index 9e76eae..4f9a6fa 100644
> --- a/src/libkeymap/analyze.l
> +++ b/src/libkeymap/analyze.l
> @@ -319,7 +319,7 @@ Include			include[ \t]*
>  Decimal			[1-9][0-9]*
>  Octal			0[0-7]*
>  Hex			0[xX][0-9a-fA-F]+
> -Unicode			U\+([0-9a-fA-F]){4}
> +Unicode			U\+([0-9a-fA-F]){4,6}
>  Literal			[a-zA-Z][a-zA-Z_0-9]*
>  Octa			([0-7]){1,3}
>  Charset			charset|Charset|CharSet|CHARSET
> -- 
> 2.29.2
> 

-- 
Rgrds, legion