From: Alexey Gladkov <gladkov.alexey@gmail.com> To: Anisse Astier <anisse@astier.eu> Cc: kbd@lists.altlinux.org Subject: Re: [kbd] [PATCH] src/libkeymap: add support for parsing more unicode values Date: Tue, 2 Mar 2021 01:47:27 +0100 Message-ID: <20210302004727.kcmcofcmw6ki5atc@example.org> (raw) In-Reply-To: <20210301144952.5dpy7fjwkduqsjzu@bifrost> On Mon, Mar 01, 2021 at 03:49:52PM +0100, Anisse Astier wrote: > On Mon, Mar 01, 2021 at 03:09:39PM +0100, Alexey Gladkov wrote: > > On Sat, Feb 27, 2021 at 03:36:11PM +0100, Anisse Astier wrote: > > > The auto-generated (with ckbcomp) file fr-bepo_afnor did not load (even > > > partially), because of an U+1f12f (copyleft symbol) that is wrongly > > > parsed, generating this error message: > > > > > > too many (160) entries on one line > > > > > > Fix libkeymap so that the keymap can be parsed, even if the offending > > > character won't be loaded because of the ushort limitation of the > > > kb_value KDSKBENT uapi. > > > > > > It's better to have the keymap partially loaded than not at all. > > > > Nop. Partially keymap loading is very dangerous. You can get a completely > > unusable console. The libkeymap shouldn't break the console if it is known > > By partially, I meant that only a single character of a single key > wouldn't load. I'm curious, what would be the implications here ? How > could it break ? In this particular case, nothing will happen. An unicode character will not be loaded and the user will probably see a warning. And this approach is the best way to do it. > I tried loading this keymap, and didn't see any averse effect. The > character was missing, and that's about it. Why wouldn't we want that ? >From the point of view of keymap processing in the kernel, such a keymap is not valid. I believe that the library should report the fact of an error in the keymap as early as possible. Speaking of such restrictions, I would like to remind you that libkeymap also has a restriction on the number of keys, but technically libkeymap could parse more keys. > > in advance that the keymap is not correct. You should fix ckbcomp so that > > it generates the correct keymap. > > > > I thought about doing this too, but it would mean not recognizing a > valid (albeit unsupported) unicode symbol. At least here the parsing > works, even if this particular symbol isn't loaded because of kernel > console limitations. > > It feels weird to use the U+ unicode symbol notation, and then refuse to > load 2/3rd of those. >From the point of view of the kernel, unicode symbols greater than 0xf000 are not valid. -- Rgrds, legion
next prev parent reply other threads:[~2021-03-02 0:47 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-27 14:36 Anisse Astier 2021-03-01 14:09 ` Alexey Gladkov 2021-03-01 14:49 ` Anisse Astier 2021-03-02 0:47 ` Alexey Gladkov [this message] 2021-03-03 17:09 ` [kbd] [PATCH] src/libkeymap: better error message on unsupported unicode value Anisse Astier 2021-03-03 18:59 ` Alexey Gladkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210302004727.kcmcofcmw6ki5atc@example.org \ --to=gladkov.alexey@gmail.com \ --cc=anisse@astier.eu \ --cc=kbd@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux console tools development discussion This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \ kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com public-inbox-index kbd Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.kbd AGPL code for this site: git clone https://public-inbox.org/public-inbox.git