From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=astier-eu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=avqXgsFEM50uSd7E5Hdnuk0qGiewgDG4+0maoqN2+k4=; b=zGEJEdD5HxNatfLS55iMU6xp2PD19sPJRn1cbNa7dhgkpPvXWYcQULytn+PnYwH2KE ved46C/Ty4Is1i2xLhTvFHCkuPb+080COKfdmBt5wsfQl8bWFT9rdQULO0OqMRQnhwD5 CUsZl2By6o1cGWoTEtR191RAbXhLMNcwscId9DSf1CcmiRLCjjMoqHDLCWzq7JxIndkK wajugDoqsznq9kDKihtr8A7u4mjDTbFKGUM6YPHvyyQOS23qMGTCUaCn6ep5yBhHEAg8 hknrkAkzZU8y50r1C6c1wbi4+45YLNt1GLuPS3OCgxRw+EZdyVcCUTSvOZ30J5mpayTJ aP4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=avqXgsFEM50uSd7E5Hdnuk0qGiewgDG4+0maoqN2+k4=; b=WXUzmYEOP8VMLNyNBN3PLTbPxhvIbyET7QGW6QkfX84NZ94F7PXPUFVxHIgwLdikHI 6+eOOlPb8+X5L/ptR4Biz4Jypr8wDSfD7J9VOj04ypFe9pVapSBNqz0xU8uUdZar5yrD nPGOhsnCX8rU5BHkB0edICv4DfJ/VoNtcPcOW3LTmeayDtdQdRkr2UIDqOhekdspu87E +xoS2tVTW37Jk93EXybk7UixBlUa5QdPrKXVH1CmrkT3CjFJDluiwoqBcCED891k/t6h VfqGPubqHMd3G81/OIlGvasP/iUWl0e+AoyVgVm50/Wgi0QmfwMrZMmWr5yNVrNRLakG KagQ== X-Gm-Message-State: AOAM531Me4E6dixOhVbr+u6KSGsUjr5AjQ1ztNFcdCbwl9vD2inoHRkW t4RraA6H06FrDCRw+8UiSwaMjg== X-Google-Smtp-Source: ABdhPJzlln/71USL8+IND6O6/lHTwVVQYkIu6uMON1hCRfdcNLOZQpTAL2LoTkmQTXwji7wxjGJlZQ== X-Received: by 2002:a5d:55c2:: with SMTP id i2mr17509419wrw.340.1614610194982; Mon, 01 Mar 2021 06:49:54 -0800 (PST) Date: Mon, 1 Mar 2021 15:49:52 +0100 From: Anisse Astier To: Alexey Gladkov Message-ID: <20210301144952.5dpy7fjwkduqsjzu@bifrost> References: <20210227143611.94982-1-anisse@astier.eu> <20210301140939.e2lby2uau4nm3apv@example.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301140939.e2lby2uau4nm3apv@example.org> User-Agent: NeoMutt/20170113 (1.7.2) Cc: kbd@lists.altlinux.org Subject: Re: [kbd] [PATCH] src/libkeymap: add support for parsing more unicode values X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 14:49:58 -0000 Archived-At: List-Archive: On Mon, Mar 01, 2021 at 03:09:39PM +0100, Alexey Gladkov wrote: > On Sat, Feb 27, 2021 at 03:36:11PM +0100, Anisse Astier wrote: > > The auto-generated (with ckbcomp) file fr-bepo_afnor did not load (even > > partially), because of an U+1f12f (copyleft symbol) that is wrongly > > parsed, generating this error message: > > > > too many (160) entries on one line > > > > Fix libkeymap so that the keymap can be parsed, even if the offending > > character won't be loaded because of the ushort limitation of the > > kb_value KDSKBENT uapi. > > > > It's better to have the keymap partially loaded than not at all. > > Nop. Partially keymap loading is very dangerous. You can get a completely > unusable console. The libkeymap shouldn't break the console if it is known By partially, I meant that only a single character of a single key wouldn't load. I'm curious, what would be the implications here ? How could it break ? I tried loading this keymap, and didn't see any averse effect. The character was missing, and that's about it. Why wouldn't we want that ? > in advance that the keymap is not correct. You should fix ckbcomp so that > it generates the correct keymap. > I thought about doing this too, but it would mean not recognizing a valid (albeit unsupported) unicode symbol. At least here the parsing works, even if this particular symbol isn't loaded because of kernel console limitations. It feels weird to use the U+ unicode symbol notation, and then refuse to load 2/3rd of those. Regards, Anisse