From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gladkov.alexey@gmail.com>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,
 FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no
 version=3.4.1
Date: Mon, 8 Jun 2020 12:49:27 +0200
From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: Linux console tools development discussion <kbd@lists.altlinux.org>
Message-ID: <20200608104927.scpcjnoxa65dlnt3@comp-core-i7-2640m-0182e6>
References: <20200604131233.386721-1-rafaelff@gnome.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200604131233.386721-1-rafaelff@gnome.org>
Subject: Re: [kbd] [PATCH] dumpkeys: avoid translating empty string
X-BeenThere: kbd@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Linux console tools development discussion <kbd@lists.altlinux.org>
List-Id: Linux console tools development discussion <kbd.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/kbd>
List-Post: <mailto:kbd@lists.altlinux.org>
List-Help: <mailto:kbd-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2020 10:49:34 -0000
Archived-At: <http://lore.altlinux.org/kbd/20200608104927.scpcjnoxa65dlnt3@comp-core-i7-2640m-0182e6/>
List-Archive: <http://lore.altlinux.org/kbd/>

On Thu, Jun 04, 2020 at 10:12:33AM -0300, Rafael Fontenelle wrote:
> Empty string marked for translation receives the header fields
> of translation files, which is not the output desired in the case
> ---
>  src/dumpkeys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dumpkeys.c b/src/dumpkeys.c
> index 9395db9..abd32bd 100644
> --- a/src/dumpkeys.c
> +++ b/src/dumpkeys.c
> @@ -110,7 +110,7 @@ int main(int argc, char *argv[])
>  		{ "-n, --numeric",          _("display keytable in hexadecimal notation.") },
>  		{ "-f, --full-table",       _("don't use short-hand notations, one row per keycode.") },
>  		{ "-1, --separate-lines",   _("one line per (modifier,keycode) pair.") },
> -		{ "-S, --shape={2|4|8|16}", _("") },
> +		{ "-S, --shape={2|4|8|16}", "" },
>  		{ "-t, --funcs-only",       _("display only the function key strings.") },
>  		{ "-k, --keys-only",        _("display only key bindings.") },
>  		{ "-d, --compose-only",     _("display only compose key combinations.") },
> -- 
> 2.27.0

Applied, thanks!

-- 
Rgrds, legion