From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 Date: Thu, 27 Jun 2019 11:17:14 +0200 From: Alexey Gladkov To: Linux console tools development discussion Message-ID: <20190627091714.GB10907@localhost.localdomain> References: <20190627030719.4116-1-mforney@mforney.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190627030719.4116-1-mforney@mforney.org> Subject: Re: [kbd] [PATCH] libkeymap: Avoid pointer arithmetic on `void *` X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jun 2019 09:17:20 -0000 Archived-At: List-Archive: On Wed, Jun 26, 2019 at 08:07:19PM -0700, Michael Forney wrote: > Another option with less casting is to change the type of the `array` > member of `struct lk_array` from `void *` to `char *`. Let me know > if you would prefer this approach: > > https://github.com/michaelforney/kbd/commit/5554deb1df4263d5d6b782a484dbb78b1b3ad569 Applied. -- Rgrds, legion