From: Alexey Gladkov <gladkov.alexey@gmail.com>
To: Linux console tools development discussion <kbd@lists.altlinux.org>
Subject: Re: [kbd] [Fwd: Re: [Pkg-kbd-devel] kbd -b needlessly requires VT access]
Date: Tue, 6 Sep 2016 17:49:31 +0200
Message-ID: <20160906154931.GG31992@comp-core-i7-2640m-0182e6.fortress> (raw)
In-Reply-To: <41945c929b9cb3612b962988d4a3df23.squirrel@vsta.org>
On Mon, Aug 29, 2016 at 08:17:29AM -0700, Andy Valencia wrote:
> At the request of Andreas, I am forwarding this bug I reported on Debian.
> Briefly, loadkeys in -b mode is just a file utility, converting text
> format to binary. And yet the code is structured so that a console
> FD must be opened, needlessly requiring the file conversion to be run
> in a console environment.
Thanks for report! Good catch!
http://git.kernel.org/cgit/linux/kernel/git/legion/kbd.git/commit/?id=2740f65352e3806dac56e16e5856eac5702caf6e
> ---------------------------- Original Message ----------------------------
> Subject: Re: [Pkg-kbd-devel] kbd -b needlessly requires VT access
> From: "Andreas Henriksson" <andreas@fatal.se>
> Date: Sun, August 28, 2016 4:59 am
> --------------------------------------------------------------------------
>
> Hello Andy Valencia.
>
> On Fri, Aug 26, 2016 at 08:54:53AM -0700, Andy Valencia wrote:
> > When generating a binary map using "loadkeys -b" to target a smaller
> > device, the command fails unless run in an environment where it can
> > access a console device for itself. This is due to its unconditional
> > use of getfd(), even when all the command is going to do is write
> > out a binary version of its input file.
>
> I see that the fd returned from getfd is only conditionally used, but
> the call to getfd will result in exit(1) being called if getfd is
> about to fail. This indeed sounds suboptimal.
> Not sure if moving the getfd call to where fd is used, or if guarding
> the early call to getfd with the same guards that will make use
> of getfd, is the best option.
>
> Could you please try to contact the upstream development list about
> this issue?
>
> https://lists.altlinux.org/mailman/listinfo/kbd
>
> Regards,
> Andreas Henriksson
>
>
> _______________________________________________
> kbd mailing list
> kbd@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/kbd
--
Rgrds, legion
prev parent reply other threads:[~2016-09-06 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 15:17 Andy Valencia
2016-09-06 15:49 ` Alexey Gladkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906154931.GG31992@comp-core-i7-2640m-0182e6.fortress \
--to=gladkov.alexey@gmail.com \
--cc=kbd@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux console tools development discussion
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
public-inbox-index kbd
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.kbd
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git