From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, DNS_FROM_AHBL_RHSBL, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,RP_MATCHES_RCVD,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Date: Wed, 6 May 2015 21:34:09 +0200 From: Felix Janda To: Alexey Gladkov Message-ID: <20150506193409.GA30407@euler> References: <20150422190649.GE3170@euler> <554004DA.3060108@gmail.com> <20150429181152.GC1364@euler> <5547BCB9.3030200@gmail.com> <20150504195148.GA3967@euler> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150504195148.GA3967@euler> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: kbd@lists.altlinux.org Subject: Re: [kbd] [PATCH 5/5] Replace error() by fprintf() and perror() X-BeenThere: kbd@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Linux console tools development discussion List-Id: Linux console tools development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 May 2015 19:34:21 -0000 Archived-At: List-Archive: Alexey Gladkov wrote: > I prefer to save compatibility with the error() function. It costs > nothing, but it does not require to keep in mind the difference > between two implementations. There is a small cost (which might not be relevant for kbd): The compiler does not know that kbd_error() will not return in most cases and might emit warnings about possibly uninitialized variables because of that. Just to mentoin it... Felix