From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <felix.janda@posteo.de>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, DNS_FROM_AHBL_RHSBL,
 RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,
 SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Date: Thu, 30 Apr 2015 22:36:12 +0200
From: Felix Janda <felix.janda@posteo.de>
To: Alexey Gladkov <gladkov.alexey@gmail.com>
Message-ID: <20150430203612.GA3117@euler>
References: <20150422190649.GE3170@euler> <554004DA.3060108@gmail.com>
 <20150429181152.GC1364@euler> <554280BE.7080706@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <554280BE.7080706@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Mailman-Approved-At: Fri, 01 May 2015 00:13:13 +0300
Cc: kbd@lists.altlinux.org
Subject: Re: [kbd] [PATCH 5/5] Replace error() by fprintf() and perror()
X-BeenThere: kbd@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Linux console tools development discussion <kbd@lists.altlinux.org>
List-Id: Linux console tools development discussion <kbd.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/kbd>
List-Post: <mailto:kbd@lists.altlinux.org>
List-Help: <mailto:kbd-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/kbd>,
 <mailto:kbd-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2015 20:36:22 -0000
Archived-At: <http://lore.altlinux.org/kbd/20150430203612.GA3117@euler/>
List-Archive: <http://lore.altlinux.org/kbd/>

Alexey Gladkov wrote:
> 29.04.2015 21:11, Felix Janda пишет:
> > Thanks for applying the other patches and for kbd_error()! Now everything
> > compiles fine with musl libc.
> > 
> > However kbd_error() does not behave correctly in the case that the first
> > argument is 0 (EXIT_SUCCESS). error() does _not_ terminate the program
> > if the first argument is EXIT_SUCCESS. Maybe have in addition a
> > kbd_warn() so that the __attribute__((noreturn)) can stay for kbd_error()
> > (then the exitnum argument would also become superfluous).
> 
> You right. I missed it. Fixed.

Thanks, now the replacement should be equivalent to what it is replacing.

Felix