Linux console tools development discussion
 help / color / mirror / Atom feed
From: Felix Janda <felix.janda@posteo.de>
To: kbd@lists.altlinux.org
Subject: [kbd] [PATCH 3/5] setvtrgb: simplify loop
Date: Wed, 22 Apr 2015 21:06:30 +0200
Message-ID: <20150422190630.GC3170@euler> (raw)

---
 src/setvtrgb.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/setvtrgb.c b/src/setvtrgb.c
index b398615..94501ef 100644
--- a/src/setvtrgb.c
+++ b/src/setvtrgb.c
@@ -72,9 +72,7 @@ parse_file(FILE *fd, const char *filename)
 	unsigned int rows, cols, val;
 
 	for (rows = 0; rows < 3; rows++) {
-		cols = 0;
-
-		while (cols < 16) {
+		for (cols = 0; cols < 16; cols++) {
 			if ((c = fscanf(fd, "%u", &val)) != 1) {
 				if (c == EOF)
 					error(EXIT_FAILURE, errno, "fscanf");
@@ -88,7 +86,6 @@ parse_file(FILE *fd, const char *filename)
 			if (cols < 15 && fgetc(fd) != ',')
 				error(EXIT_FAILURE, 0, _("Error: %s: Insufficient number of fields in line %u."),
 				      filename, rows + 1);
-			cols++;
 		}
 
 		if ((c = fgetc(fd)) == EOF)
-- 
2.0.5


                 reply	other threads:[~2015-04-22 19:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150422190630.GC3170@euler \
    --to=felix.janda@posteo.de \
    --cc=kbd@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux console tools development discussion

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
		kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
	public-inbox-index kbd

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.kbd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git